From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Date: Wed, 08 Apr 2020 10:19:27 +0000 Subject: Re: [PATCH] video: fbdev: mb862xx: remove set but not used variable 'mdr' Message-Id: <20200408101927.GD20795@ravnborg.org> List-Id: References: <20200403022553.33320-1-yanaijie@huawei.com> In-Reply-To: <20200403022553.33320-1-yanaijie@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Jason Yan Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, b.zolnierkie@samsung.com Hi Jason. On Fri, Apr 03, 2020 at 10:25:53AM +0800, Jason Yan wrote: > Fix the following gcc warning: > > drivers/video/fbdev/mb862xx/mb862xxfb_accel.c:187:6: warning: variable > ‘mdr’ set but not used [-Wunused-but-set-variable] > int mdr; > ^~~ > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Thanks, committed to drm-misc-next. The fix will show up durign the next merge window. Sam > --- > drivers/video/fbdev/mb862xx/mb862xxfb_accel.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c > index 42569264801f..d40b806461ca 100644 > --- a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c > +++ b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c > @@ -184,7 +184,6 @@ static void mb86290fb_imageblit16(u32 *cmd, u16 step, u16 dx, u16 dy, > static void mb86290fb_imageblit(struct fb_info *info, > const struct fb_image *image) > { > - int mdr; > u32 *cmd = NULL; > void (*cmdfn) (u32 *, u16, u16, u16, u16, u16, u32, u32, > const struct fb_image *, struct fb_info *) = NULL; > @@ -196,7 +195,6 @@ static void mb86290fb_imageblit(struct fb_info *info, > u16 dx = image->dx, dy = image->dy; > int x2, y2, vxres, vyres; > > - mdr = (GDC_ROP_COPY << 9); > x2 = image->dx + image->width; > y2 = image->dy + image->height; > vxres = info->var.xres_virtual; > -- > 2.17.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DE8CC2D0EA for ; Wed, 8 Apr 2020 10:19:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25A8A20768 for ; Wed, 8 Apr 2020 10:19:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25A8A20768 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6EED36EA13; Wed, 8 Apr 2020 10:19:31 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC1796EA13 for ; Wed, 8 Apr 2020 10:19:30 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id A011D20027; Wed, 8 Apr 2020 12:19:28 +0200 (CEST) Date: Wed, 8 Apr 2020 12:19:27 +0200 From: Sam Ravnborg To: Jason Yan Subject: Re: [PATCH] video: fbdev: mb862xx: remove set but not used variable 'mdr' Message-ID: <20200408101927.GD20795@ravnborg.org> References: <20200403022553.33320-1-yanaijie@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200403022553.33320-1-yanaijie@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=i0EeH86SAAAA:8 a=e5mUnYsNAAAA:8 a=fKMPv7tiX5XEn72-Iu4A:9 a=QEXdDO2ut3YA:10 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, b.zolnierkie@samsung.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgSmFzb24uCgpPbiBGcmksIEFwciAwMywgMjAyMCBhdCAxMDoyNTo1M0FNICswODAwLCBKYXNv biBZYW4gd3JvdGU6Cj4gRml4IHRoZSBmb2xsb3dpbmcgZ2NjIHdhcm5pbmc6Cj4gCj4gZHJpdmVy cy92aWRlby9mYmRldi9tYjg2Mnh4L21iODYyeHhmYl9hY2NlbC5jOjE4Nzo2OiB3YXJuaW5nOiB2 YXJpYWJsZQo+IOKAmG1kcuKAmSBzZXQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1idXQtc2V0LXZh cmlhYmxlXQo+ICAgaW50IG1kcjsKPiAgICAgICBefn4KPiAKPiBSZXBvcnRlZC1ieTogSHVsayBS b2JvdCA8aHVsa2NpQGh1YXdlaS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSmFzb24gWWFuIDx5YW5h aWppZUBodWF3ZWkuY29tPgoKVGhhbmtzLCBjb21taXR0ZWQgdG8gZHJtLW1pc2MtbmV4dC4KVGhl IGZpeCB3aWxsIHNob3cgdXAgZHVyaWduIHRoZSBuZXh0IG1lcmdlIHdpbmRvdy4KCglTYW0KCj4g LS0tCj4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvbWI4NjJ4eC9tYjg2Mnh4ZmJfYWNjZWwuYyB8IDIg LS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvdmlkZW8vZmJkZXYvbWI4NjJ4eC9tYjg2Mnh4ZmJfYWNjZWwuYyBiL2RyaXZlcnMvdmlk ZW8vZmJkZXYvbWI4NjJ4eC9tYjg2Mnh4ZmJfYWNjZWwuYwo+IGluZGV4IDQyNTY5MjY0ODAxZi4u ZDQwYjgwNjQ2MWNhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdmlkZW8vZmJkZXYvbWI4NjJ4eC9t Yjg2Mnh4ZmJfYWNjZWwuYwo+ICsrKyBiL2RyaXZlcnMvdmlkZW8vZmJkZXYvbWI4NjJ4eC9tYjg2 Mnh4ZmJfYWNjZWwuYwo+IEBAIC0xODQsNyArMTg0LDYgQEAgc3RhdGljIHZvaWQgbWI4NjI5MGZi X2ltYWdlYmxpdDE2KHUzMiAqY21kLCB1MTYgc3RlcCwgdTE2IGR4LCB1MTYgZHksCj4gIHN0YXRp YyB2b2lkIG1iODYyOTBmYl9pbWFnZWJsaXQoc3RydWN0IGZiX2luZm8gKmluZm8sCj4gIAkJCQlj b25zdCBzdHJ1Y3QgZmJfaW1hZ2UgKmltYWdlKQo+ICB7Cj4gLQlpbnQgbWRyOwo+ICAJdTMyICpj bWQgPSBOVUxMOwo+ICAJdm9pZCAoKmNtZGZuKSAodTMyICosIHUxNiwgdTE2LCB1MTYsIHUxNiwg dTE2LCB1MzIsIHUzMiwKPiAgCQkgICAgICAgY29uc3Qgc3RydWN0IGZiX2ltYWdlICosIHN0cnVj dCBmYl9pbmZvICopID0gTlVMTDsKPiBAQCAtMTk2LDcgKzE5NSw2IEBAIHN0YXRpYyB2b2lkIG1i ODYyOTBmYl9pbWFnZWJsaXQoc3RydWN0IGZiX2luZm8gKmluZm8sCj4gIAl1MTYgZHggPSBpbWFn ZS0+ZHgsIGR5ID0gaW1hZ2UtPmR5Owo+ICAJaW50IHgyLCB5MiwgdnhyZXMsIHZ5cmVzOwo+ICAK PiAtCW1kciA9IChHRENfUk9QX0NPUFkgPDwgOSk7Cj4gIAl4MiA9IGltYWdlLT5keCArIGltYWdl LT53aWR0aDsKPiAgCXkyID0gaW1hZ2UtPmR5ICsgaW1hZ2UtPmhlaWdodDsKPiAgCXZ4cmVzID0g aW5mby0+dmFyLnhyZXNfdmlydHVhbDsKPiAtLSAKPiAyLjE3LjIKPiAKPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==