All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-team@vger.kernel.org,
	cgroups@vger.kernel.org, newella@fb.com, josef@toxicpanda.com
Subject: Re: [PATCH 2/5] block: add request->io_data_len
Date: Thu, 9 Apr 2020 09:44:06 +0800	[thread overview]
Message-ID: <20200409014406.GA370295@localhost.localdomain> (raw)
In-Reply-To: <20200408201450.3959560-3-tj@kernel.org>

Hi Tejun,

On Wed, Apr 08, 2020 at 04:14:47PM -0400, Tejun Heo wrote:
> Currently, at the time of completeion, there's no way of knowing how big a
> request was. blk-iocost will need this information to account for IO size when
> calculating expected latencies.
> 
> This patch adds rq->io_data_len which remembers blk_rq_bytes() at the time the
> request gets issued. The field is enabled iff CONFIG_BLK_IO_DATA_LEN is set and
> doesn't increase the size of the struct even when enabled.

Almost all __blk_mq_end_request() follow blk_update_request(), so the
completed bytes can be passed to __blk_mq_end_request(), then we can
avoid to introduce this field.

Also there is just 20 callers of __blk_mq_end_request(), looks this kind
of change shouldn't be too big.


Thanks, 
Ming


  reply	other threads:[~2020-04-09  1:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08 20:14 [PATCHSET block/for-5.8] iocost: improve use_delay and latency target handling Tejun Heo
2020-04-08 20:14 ` [PATCH 1/5] blk-iocost: switch to fixed non-auto-decaying use_delay Tejun Heo
     [not found] ` <20200408201450.3959560-1-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-04-08 20:14   ` [PATCH 2/5] block: add request->io_data_len Tejun Heo
2020-04-08 20:14     ` Tejun Heo
2020-04-09  1:44     ` Ming Lei [this message]
     [not found]       ` <20200409014406.GA370295-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2020-04-09  2:11         ` Tejun Heo
2020-04-09  2:11           ` Tejun Heo
     [not found]           ` <20200409021119.GJ162390-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2020-04-09  2:38             ` Ming Lei
2020-04-09  2:38               ` Ming Lei
     [not found]               ` <20200409023857.GB370295-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2020-04-09  5:08                 ` Pavel Begunkov
2020-04-09  5:08                   ` Pavel Begunkov
2020-04-13 14:02                   ` Tejun Heo
2020-04-13 13:56                 ` Tejun Heo
2020-04-13 13:56                   ` Tejun Heo
2020-04-09  3:44     ` Bart Van Assche
     [not found]       ` <b027a718-1c76-6e34-1edb-5435a5605d35-HInyCGIudOg@public.gmane.org>
2020-04-13 13:52         ` Tejun Heo
2020-04-13 13:52           ` Tejun Heo
2020-04-08 20:14   ` [PATCH 4/5] iocost_monitor: exit successfully if interval is zero Tejun Heo
2020-04-08 20:14     ` Tejun Heo
2020-04-08 20:14 ` [PATCH 3/5] blk-iocost: account for IO size when testing latencies Tejun Heo
2020-04-08 20:14 ` [PATCH 5/5] iocost_monitor: drop string wrap around numbers when outputting json Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200409014406.GA370295@localhost.localdomain \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=newella@fb.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.