From: "Bruce Ashfield" <bruce.ashfield@gmail.com>
To: Chandana kalluri <ckalluri@xilinx.com>
Cc: meta-virtualization@lists.yoctoproject.org,
Sai Hari Chandana Kalluri <chandana.kalluri@xilinx.com>,
Bruce Ashfield <bruce.ashfield@xilinx.com>
Subject: Re: [meta-virtualization][master][PATCH 1/2] go-build: Set up dependencies and GOPATH before do_compile
Date: Wed, 8 Apr 2020 23:08:35 -0400 [thread overview]
Message-ID: <20200409030834.GA9313@gmail.com> (raw)
In-Reply-To: <1586364761-16281-2-git-send-email-chandana.kalluri@xilinx.com> <1586364761-16281-1-git-send-email-chandana.kalluri@xilinx.com>
merged
Bruce
In message: [meta-virtualization][master][PATCH 1/2] go-build: Set up dependencies and GOPATH before do_compile
on 08/04/2020 Chandana kalluri wrote:
> go-build recipe depends on runc source and during compilation tries to run the
> command: go get github.com/opencontainers/runc.
>
> This is incorrect as a source fetch shouldn't occur during compilation. Also,
> even after a fetch occurs during compilation, the go build path GOPATH points
> to the incorrect path hence the runc source is never found.
>
> Fetch the opencontainers/runc source and create links in the correct GOPATH
> before compilation for a successful build.
>
> Signed-off-by: Sai Hari Chandana Kalluri <chandana.kalluri@xilinx.com>
> ---
> recipes-devtools/go/go-build_git.bb | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/recipes-devtools/go/go-build_git.bb b/recipes-devtools/go/go-build_git.bb
> index c11ad99..f94a722 100644
> --- a/recipes-devtools/go/go-build_git.bb
> +++ b/recipes-devtools/go/go-build_git.bb
> @@ -3,8 +3,11 @@ SUMMARY = "console for runx"
> DESCRIPTION = "Xen Runtime for OCI"
>
> SRCREV_runx = "da0c75c58ae5232d19b1791c33545db3225e1ea9"
> +SRCREV_runc = "e4363b038787addfa12e8b0acf5417d4fba01693"
> +
> SRC_URI = "\
> git://github.com/lf-edge/runx;nobranch=1;name=runx \
> + git://github.com/opencontainers/runc.git;nobranch=1;destsuffix=runc;name=runc \
> "
> SRC_URI[md5sum] = "0d701ac1e2a67d47ce7127432df2c32b"
> SRC_URI[sha256sum] = "5a26478906d5005f4f809402e981518d2b8844949199f60c4b6e1f986ca2a769"
> @@ -29,6 +32,9 @@ do_compile() {
>
> export GOARCH="${TARGET_GOARCH}"
> cd ${S}/src/import/gobuild
> + mkdir -p go/src/github.com/opencontainers
> + ln -s ${WORKDIR}/runc ${S}/src/import/gobuild/go/src/github.com/opencontainers/runc
> + export GOPATH="${S}/src/import/gobuild/go/src/github.com/opencontainers/runc"
> oe_runmake
> }
>
> --
> 2.7.4
>
>
prev parent reply other threads:[~2020-04-09 3:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 16:52 [meta-virtualization][master][PATCH 1/2] go-build: Set up dependencies and GOPATH before do_compile Chandana kalluri
2020-04-08 16:52 ` [meta-virtualization][master][PATCH 2/2] go-build_git.bb: go-build: set GO_PARALLEL_BUILD to default value Chandana kalluri
2020-04-09 3:08 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409030834.GA9313@gmail.com \
--to=bruce.ashfield@gmail.com \
--cc=bruce.ashfield@xilinx.com \
--cc=chandana.kalluri@xilinx.com \
--cc=ckalluri@xilinx.com \
--cc=meta-virtualization@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.