From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3AF4C2D0EA for ; Thu, 9 Apr 2020 06:19:20 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B7E0206A1 for ; Thu, 9 Apr 2020 06:19:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B7E0206A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jMQWa-0002m9-Nc; Thu, 09 Apr 2020 06:18:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jMQWZ-0002m4-6p for xen-devel@lists.xenproject.org; Thu, 09 Apr 2020 06:18:51 +0000 X-Inumbo-ID: f93bf2e8-7a29-11ea-8290-12813bfff9fa Received: from verein.lst.de (unknown [213.95.11.211]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f93bf2e8-7a29-11ea-8290-12813bfff9fa; Thu, 09 Apr 2020 06:18:48 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 7A3A668C4E; Thu, 9 Apr 2020 08:18:46 +0200 (CEST) Date: Thu, 9 Apr 2020 08:18:46 +0200 From: Christoph Hellwig To: Wei Liu Subject: Use of VM_IOREMAP in xenbus Message-ID: <20200409061846.GA30241@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Konrad Wilk , linux-kernel@vger.kernel.org, Bob Liu , Paul Durrant , David Vrabel , xen-devel@lists.xenproject.org, Boris Ostrovsky Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi Wei, commit ccc9d90a9a8b5 ("xenbus_client: Extend interface to support multi-page ring") addes a use of vmap in what is now xenbus_map_ring_valloc_hvm, and uses the VM_IOREMAP flag that is only really intended for implementing ioremap. Do you remember what the reason is that this flag was used? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D1BFC2D0EA for ; Thu, 9 Apr 2020 06:18:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6AD5B2072F for ; Thu, 9 Apr 2020 06:18:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726523AbgDIGSs (ORCPT ); Thu, 9 Apr 2020 02:18:48 -0400 Received: from verein.lst.de ([213.95.11.211]:45306 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725828AbgDIGSs (ORCPT ); Thu, 9 Apr 2020 02:18:48 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 7A3A668C4E; Thu, 9 Apr 2020 08:18:46 +0200 (CEST) Date: Thu, 9 Apr 2020 08:18:46 +0200 From: Christoph Hellwig To: Wei Liu Cc: Bob Liu , Paul Durrant , Konrad Wilk , Boris Ostrovsky , David Vrabel , Juergen Gross , Stefano Stabellini , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Use of VM_IOREMAP in xenbus Message-ID: <20200409061846.GA30241@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wei, commit ccc9d90a9a8b5 ("xenbus_client: Extend interface to support multi-page ring") addes a use of vmap in what is now xenbus_map_ring_valloc_hvm, and uses the VM_IOREMAP flag that is only really intended for implementing ioremap. Do you remember what the reason is that this flag was used?