From: Hannes Reinecke <hare@suse.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Damien LeMoal <damien.lemoal@wdc.com>,
Bob Liu <bob.liu@oracle.com>,
dm-devel@redhat.com
Subject: [PATCH 08/11] dm-zoned: use dmz_zone_to_dev() when handling metadata I/O
Date: Thu, 9 Apr 2020 08:45:24 +0200 [thread overview]
Message-ID: <20200409064527.82992-9-hare@suse.de> (raw)
In-Reply-To: <20200409064527.82992-1-hare@suse.de>
Use accessors to retrieve the device pointer in preparation
for adding an additional block device.
Signed-off-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
---
drivers/md/dm-zoned-metadata.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
index cd4a8093da24..34dc5f3abf09 100644
--- a/drivers/md/dm-zoned-metadata.c
+++ b/drivers/md/dm-zoned-metadata.c
@@ -1305,6 +1305,7 @@ static int dmz_update_zone_cb(struct blk_zone *blkz, unsigned int idx,
*/
static int dmz_update_zone(struct dmz_metadata *zmd, struct dm_zone *zone)
{
+ struct dmz_dev *dev = dmz_zone_to_dev(zmd, zone);
unsigned int noio_flag;
int ret;
@@ -1315,16 +1316,16 @@ static int dmz_update_zone(struct dmz_metadata *zmd, struct dm_zone *zone)
* GFP_NOIO was specified.
*/
noio_flag = memalloc_noio_save();
- ret = blkdev_report_zones(zmd->dev->bdev, dmz_start_sect(zmd, zone), 1,
+ ret = blkdev_report_zones(dev->bdev, dmz_start_sect(zmd, zone), 1,
dmz_update_zone_cb, zone);
memalloc_noio_restore(noio_flag);
if (ret == 0)
ret = -EIO;
if (ret < 0) {
- dmz_dev_err(zmd->dev, "Get zone %u report failed",
+ dmz_dev_err(dev, "Get zone %u report failed",
zone->id);
- dmz_check_bdev(zmd->dev);
+ dmz_check_bdev(dev);
return ret;
}
@@ -1338,6 +1339,7 @@ static int dmz_update_zone(struct dmz_metadata *zmd, struct dm_zone *zone)
static int dmz_handle_seq_write_err(struct dmz_metadata *zmd,
struct dm_zone *zone)
{
+ struct dmz_dev *dev = dmz_zone_to_dev(zmd, zone);
unsigned int wp = 0;
int ret;
@@ -1346,7 +1348,7 @@ static int dmz_handle_seq_write_err(struct dmz_metadata *zmd,
if (ret)
return ret;
- dmz_dev_warn(zmd->dev, "Processing zone %u write error (zone wp %u/%u)",
+ dmz_dev_warn(dev, "Processing zone %u write error (zone wp %u/%u)",
zone->id, zone->wp_block, wp);
if (zone->wp_block < wp) {
@@ -1379,7 +1381,7 @@ static int dmz_reset_zone(struct dmz_metadata *zmd, struct dm_zone *zone)
return 0;
if (!dmz_is_empty(zone) || dmz_seq_write_err(zone)) {
- struct dmz_dev *dev = zmd->dev;
+ struct dmz_dev *dev = dmz_zone_to_dev(zmd, zone);
ret = blkdev_zone_mgmt(dev->bdev, REQ_OP_ZONE_RESET,
dmz_start_sect(zmd, zone),
--
2.25.0
next prev parent reply other threads:[~2020-04-09 6:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 6:45 [PATCHv3 00/11] dm-zoned: metadata version 2 Hannes Reinecke
2020-04-09 6:45 ` [PATCH 01/11] dm-zoned: store zone id within the zone structure and kill dmz_id() Hannes Reinecke
2020-04-10 6:37 ` Damien Le Moal
2020-04-14 6:31 ` Hannes Reinecke
2020-04-09 6:45 ` [PATCH 02/11] dm-zoned: use array for superblock zones Hannes Reinecke
2020-04-09 6:45 ` [PATCH 03/11] dm-zoned: store device in struct dmz_sb Hannes Reinecke
2020-04-09 6:45 ` [PATCH 04/11] dm-zoned: move fields from struct dmz_dev to dmz_metadata Hannes Reinecke
2020-04-09 6:45 ` [PATCH 05/11] dm-zoned: introduce dmz_metadata_label() to format device name Hannes Reinecke
2020-04-09 6:45 ` [PATCH 06/11] dm-zoned: remove 'dev' argument from reclaim Hannes Reinecke
2020-04-10 6:43 ` Damien Le Moal
2020-04-14 6:34 ` Hannes Reinecke
2020-04-14 6:37 ` Damien Le Moal
2020-04-09 6:45 ` [PATCH 07/11] dm-zoned: replace 'target' pointer in the bio context Hannes Reinecke
2020-04-10 6:52 ` Damien Le Moal
2020-04-14 6:36 ` Hannes Reinecke
2020-04-09 6:45 ` Hannes Reinecke [this message]
2020-04-09 6:45 ` [PATCH 09/11] dm-zoned: add metadata logging functions Hannes Reinecke
2020-04-09 6:45 ` [PATCH 10/11] dm-zoned: ignore metadata zone in dmz_alloc_zone() Hannes Reinecke
2020-04-09 6:45 ` [PATCH 11/11] dm-zoned: metadata version 2 Hannes Reinecke
2020-04-13 4:55 ` Damien Le Moal
2020-04-14 5:46 ` Hannes Reinecke
2020-04-14 5:58 ` Damien Le Moal
2020-04-11 12:30 ` [PATCHv3 00/11] " Bob Liu
2020-04-14 6:38 ` Hannes Reinecke
2020-04-14 15:13 ` Mike Snitzer
2020-04-15 0:07 ` Bob Liu
-- strict thread matches above, loose matches on Subject: below --
2020-04-06 14:34 [PATCHv2 " Hannes Reinecke
2020-04-06 14:35 ` [PATCH 08/11] dm-zoned: use dmz_zone_to_dev() when handling metadata I/O Hannes Reinecke
2020-04-07 2:52 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409064527.82992-9-hare@suse.de \
--to=hare@suse.de \
--cc=bob.liu@oracle.com \
--cc=damien.lemoal@wdc.com \
--cc=dm-devel@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.