All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Alan Cooper <alcooperx@gmail.com>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Alan Stern" <stern@rowland.harvard.edu>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	devicetree <devicetree@vger.kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	USB <linux-usb@vger.kernel.org>,
	"Mathias Nyman" <mathias.nyman@intel.com>,
	"Rob Herring" <robh+dt@kernel.org>
Subject: Re: [PATCH v3 4/4] usb: host: Add ability to build new Broadcom STB USB drivers
Date: Thu, 9 Apr 2020 15:30:05 +0300	[thread overview]
Message-ID: <20200409123005.GZ3676135@smile.fi.intel.com> (raw)
In-Reply-To: <CAOGqxeXQE0z=+6yuEME48am__2vtJhBpetYd_sZamJmm1h_TLQ@mail.gmail.com>

On Thu, Apr 09, 2020 at 07:49:52AM -0400, Alan Cooper wrote:
> On Thu, Apr 9, 2020 at 5:08 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > On Thu, Apr 9, 2020 at 12:52 AM Al Cooper <alcooperx@gmail.com> wrote:
> > >
> > > Add the build system changes needed to get the Broadcom STB XHCI,
> > > EHCI and OHCI functionality working. The OHCI support does not
> > > require anything unique to Broadcom so the standard ohci-platform
> > > driver is being used. The link order for XHCI was changed in the
> > > Makefile because of the way STB XHCI, EHCI and OHCI controllers
> > > share a port which requires that the XHCI driver be initialized
> > > first. Also update MAINTAINERS.
> >
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -3477,6 +3477,14 @@ S:       Supported
> > >  F:     drivers/i2c/busses/i2c-brcmstb.c
> > >  F:     Documentation/devicetree/bindings/i2c/brcm,brcmstb-i2c.yaml
> > >
> > > +BROADCOM BRCMSTB USB EHCI DRIVER
> > > +M:     Al Cooper <alcooperx@gmail.com>
> > > +L:     linux-usb@vger.kernel.org
> > > +L:     bcm-kernel-feedback-list@broadcom.com
> > > +S:     Maintained
> > > +F:     drivers/usb/host/ehci-brcm.*
> > > +F:     Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml
> >
> > This has ordering issues.
> > Run parse-maintainer.pl to fix. (Note, it creates by default a new
> > file, you might need to run diff manually to see the difference).
> 
> I'm not sure what you mean.
> I ran "./scripts/parse-maintainers.pl" and did "diff MAINTAINERS
> MAINTAINERS.new" and there are no differences in or around my entry.

Perhaps --order should be added.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2020-04-09 12:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08 18:14 [PATCH v3 0/4] Add XHCI, EHCI and OHCI support for Broadcom STB SoS's Al Cooper
2020-04-08 18:14 ` [PATCH v3 1/4] dt-bindings: Add Broadcom STB USB support Al Cooper
2020-04-14 13:50   ` Rob Herring
2020-04-08 18:14 ` [PATCH v3 2/4] usb: xhci: xhci-plat: Add support for Broadcom STB SoC's Al Cooper
2020-04-09  7:25   ` Mathias Nyman
2020-04-08 18:14 ` [PATCH v3 3/4] usb: ehci: Add new EHCI driver " Al Cooper
2020-04-08 18:14 ` [PATCH v3 4/4] usb: host: Add ability to build new Broadcom STB USB drivers Al Cooper
2020-04-09  9:08   ` Andy Shevchenko
2020-04-09 11:49     ` Alan Cooper
2020-04-09 12:30       ` Andy Shevchenko [this message]
2020-04-09 18:15         ` Alan Cooper
2020-04-09 18:47           ` Andy Shevchenko
2020-04-08 18:25 ` [PATCH v3 0/4] Add XHCI, EHCI and OHCI support for Broadcom STB SoS's Andy Shevchenko
2020-04-08 19:00   ` Alan Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200409123005.GZ3676135@smile.fi.intel.com \
    --to=andy.shevchenko@gmail.com \
    --cc=alcooperx@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=j.neuschaefer@gmx.net \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=robh+dt@kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.