From: Brian Foster <bfoster@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
Dave Chinner <dchinner@redhat.com>,
Eric Sandeen <sandeen@redhat.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: stop CONFIG_XFS_DEBUG from changing compiler flags
Date: Thu, 9 Apr 2020 08:51:25 -0400 [thread overview]
Message-ID: <20200409125125.GA38767@bfoster> (raw)
In-Reply-To: <20200409080909.3646059-1-arnd@arndb.de>
On Thu, Apr 09, 2020 at 10:08:56AM +0200, Arnd Bergmann wrote:
> I ran into a linker warning in XFS that originates from a mismatch
> between libelf, binutils and objtool when certain files in the kernel
> are built with "gcc -g":
>
> x86_64-linux-ld: fs/xfs/xfs_trace.o: unable to initialize decompress status for section .debug_info
>
> After some discussion, nobody could identify why xfs sets this flag
> here. CONFIG_XFS_DEBUG used to enable lots of unrelated settings, but
> now its main purpose is to enable extra consistency checks and assertions
> that are unrelated to the debug info.
>
> Remove the Makefile logic to set the flag here. If anyone relies
> on the debug info, this can simply be enabled again with the global
> CONFIG_DEBUG_INFO option.
>
> Suggested-by: Christoph Hellwig <hch@infradead.org>
> Link: https://lore.kernel.org/lkml/20200409074130.GD21033@infradead.org/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Seems reasonable.
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
> index 4f95df476181..ff94fb90a2ee 100644
> --- a/fs/xfs/Makefile
> +++ b/fs/xfs/Makefile
> @@ -7,8 +7,6 @@
> ccflags-y += -I $(srctree)/$(src) # needed for trace events
> ccflags-y += -I $(srctree)/$(src)/libxfs
>
> -ccflags-$(CONFIG_XFS_DEBUG) += -g
> -
> obj-$(CONFIG_XFS_FS) += xfs.o
>
> # this one should be compiled first, as the tracing macros can easily blow up
> --
> 2.26.0
>
next prev parent reply other threads:[~2020-04-09 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 8:08 [PATCH] xfs: stop CONFIG_XFS_DEBUG from changing compiler flags Arnd Bergmann
2020-04-09 12:51 ` Brian Foster [this message]
2020-04-09 15:50 ` Allison Collins
2020-04-10 1:01 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409125125.GA38767@bfoster \
--to=bfoster@redhat.com \
--cc=arnd@arndb.de \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.