From: Mark Brown <broonie@kernel.org>
To: Baolin Wang <baolin.wang7@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/3] mfd: syscon: Add reg_update_bits() callback support
Date: Thu, 9 Apr 2020 15:27:15 +0100 [thread overview]
Message-ID: <20200409142715.GF5399@sirena.org.uk> (raw)
In-Reply-To: <CADBw62oh6juAqUR1-U1D73H0oeW1x0gk0XJ01h47ko_Dxy7eEQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 594 bytes --]
On Thu, Apr 09, 2020 at 10:13:58PM +0800, Baolin Wang wrote:
> On Thu, Apr 9, 2020 at 6:48 PM Mark Brown <broonie@kernel.org> wrote:
> > > + int (*reg_update_bits)(void *context, unsigned int reg,
> > > + unsigned int mask, unsigned int val);
> > This is fine, we already have this operation for buses, but why is this
> > munged in with the MFD patch?
> Originally I want to show a example usage of the new callback, but I
> can spilt them into 2 patches as you suggested. Thanks.
Yes, it's good to have an example user - just not as part of the same
patch!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-04-09 14:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 8:57 [RFC PATCH 0/3] Add new reg_update_bits() support Baolin Wang
2020-04-09 8:57 ` [RFC PATCH 1/3] mfd: syscon: Add reg_update_bits() callback support Baolin Wang
2020-04-09 10:48 ` Mark Brown
2020-04-09 14:13 ` Baolin Wang
2020-04-09 14:27 ` Mark Brown [this message]
2020-04-10 2:15 ` Baolin Wang
2020-04-09 19:23 ` kbuild test robot
2020-04-09 8:57 ` [RFC PATCH 2/3] regmap: Add reg_update_bits() support Baolin Wang
2020-04-09 10:45 ` Mark Brown
2020-04-09 14:12 ` Baolin Wang
2020-04-09 14:26 ` Mark Brown
2020-04-10 2:55 ` Baolin Wang
2020-04-09 8:57 ` [RFC PATCH 3/3] soc: sprd: Add Spreadtrum special bits updating support Baolin Wang
2020-04-09 9:15 ` [RFC PATCH 0/3] Add new reg_update_bits() support Arnd Bergmann
2020-04-09 9:40 ` Baolin Wang
2020-04-09 9:52 ` Arnd Bergmann
2020-04-09 9:56 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409142715.GF5399@sirena.org.uk \
--to=broonie@kernel.org \
--cc=arnd@arndb.de \
--cc=baolin.wang7@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.