From: Alexey Dobriyan <adobriyan@gmail.com>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: [PATCH] zbd: fix sequential verify with max_open_zones=1
Date: Thu, 9 Apr 2020 20:14:01 +0300 [thread overview]
Message-ID: <20200409171401.GA3220@avx2> (raw)
In-Reply-To: <BY5PR04MB6900B4F8DFDDBB498EDA8768E7C10@BY5PR04MB6900.namprd04.prod.outlook.com>
On Thu, Apr 09, 2020 at 01:58:13AM +0000, Damien Le Moal wrote:
> On 2020/04/09 7:16, Alexey Dobriyan wrote:
> > Sequential write with max_open_zones=1 has interesting (read: buggy)
> > interaction with verify=.
> > + if (f->zbd_info->open_zones[i] == nz) {
> > + zbd_close_zone(td, f, i);
> > + }
>
> nit: you do not need the {} brackets for the if here.
I started to use {} everywhere, it is less thinking that way.
> With the nits above fixed, this looks OK to me.
>
> It would be good to add a test case for this to t/zbd/test-zbd-support. Can you
> send something please ?
I'll try. This needs a test with blktrace parsing and eveything.
next prev parent reply other threads:[~2020-04-09 17:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 22:16 [PATCH] zbd: fix sequential verify with max_open_zones=1 Alexey Dobriyan
2020-04-09 1:58 ` Damien Le Moal
2020-04-09 17:14 ` Alexey Dobriyan [this message]
2020-04-09 22:41 ` Damien Le Moal
2020-04-10 18:46 ` Alexey Dobriyan
2020-04-11 20:18 ` Jens Axboe
2020-04-13 18:51 ` [PATCH v2] zbd: fix sequential write pattern with verify= and max_open_zones= Alexey Dobriyan
2020-04-13 23:13 ` Damien Le Moal
2020-04-13 23:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409171401.GA3220@avx2 \
--to=adobriyan@gmail.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.