From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [RESEND PATCH] drm/i915: do AUD_FREQ_CNTRL state save on all gen9+ platforms
Date: Thu, 9 Apr 2020 21:04:18 +0300 [thread overview]
Message-ID: <20200409180418.GY6112@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2004091657320.2957@eliteleevi.tm.intel.com>
On Thu, Apr 09, 2020 at 05:14:01PM +0300, Kai Vehmanen wrote:
> Hey,
>
> On Mon, 30 Mar 2020, Kai Vehmanen wrote:
>
> > Replace the TGL/ICL specific platform checks with a more generic check
> > using INTEL_GEN(). Fixes bug with broken audio after S3 resume on JSL
> > platforms.
>
> I would be (gently) beaten with a stick on alsa-devel for sending this
> type of content free ping, but I still dare to seek your input on what is
> the proper way to get attention to a patch that are seemingly forever
> stuck on the review sideline.
And what is this?
https://patchwork.freedesktop.org/patch/347148/?series=71527&rev=1
>
> I've sent this on 13.3., resend on 30.3.. Should I just keep on sending
> resends and let the system work (this is the alsa-devel practise), or
> should I start to contact potential reviewers with more direct asks?
Just ping on original patch or ping someone on irc. Resending
the same patch over and over does no good. At least my brain just
ignores anything that looks like it's just a resend w/o any clear
justification.
>
> Tests seem to all pass and this is pretty important for anyone using JSL
> platforms (you lose HDMI/DP audio after first S3 suspend otherwise):
> https://patchwork.freedesktop.org/series/74664/
>
> Br, Kai
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-04-09 18:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 14:44 [Intel-gfx] [RESEND PATCH] drm/i915: do AUD_FREQ_CNTRL state save on all gen9+ platforms Kai Vehmanen
2020-03-30 21:11 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: do AUD_FREQ_CNTRL state save on all gen9+ platforms (rev2) Patchwork
2020-03-31 8:25 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-04-09 14:14 ` [Intel-gfx] [RESEND PATCH] drm/i915: do AUD_FREQ_CNTRL state save on all gen9+ platforms Kai Vehmanen
2020-04-09 18:04 ` Ville Syrjälä [this message]
2020-04-14 10:32 ` Kai Vehmanen
2020-04-14 16:54 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409180418.GY6112@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=kai.vehmanen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.