Re: [PATCH][RFC] sched/isolation: allow isolcpus and nohz_full for different cpus

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 6429 bytes --]

Hi Li,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on tip/sched/core]
[also build test ERROR on v5.6 next-20200409]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Li-RongQing/sched-isolation-allow-isolcpus-and-nohz_full-for-different-cpus/20200409-174606
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 313f16e2e35abb833eab5bdebc6ae30699adca18
config: x86_64-defconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

>> kernel/sched/isolation.c:24:22: error: 'housekeeping_get_mask' declared as function returning an array
    static cpumask_var_t housekeeping_get_mask(enum hk_flags flags)
                         ^~~~~~~~~~~~~~~~~~~~~
   kernel/sched/isolation.c: In function 'housekeeping_get_mask':
>> kernel/sched/isolation.c:27:10: warning: return makes integer from pointer without a cast [-Wint-conversion]
      return housekeeping_mask_isolcpus;
             ^~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/sched/isolation.c:31:10: warning: return makes integer from pointer without a cast [-Wint-conversion]
      return housekeeping_mask_isolcpus;
             ^~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/sched/isolation.c:33:9: warning: return makes integer from pointer without a cast [-Wint-conversion]
     return housekeeping_mask_nohz_full;
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/sched/isolation.c: In function 'housekeeping_any_cpu':
>> kernel/sched/isolation.c:43:22: error: assignment to expression with array type
       housekeeping_mask = housekeeping_get_mask(flags);
                         ^
   kernel/sched/isolation.c: In function 'housekeeping_cpumask':
>> kernel/sched/isolation.c:59:11: warning: return makes pointer from integer without a cast [-Wint-conversion]
       return housekeeping_get_mask(flags);
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/sched/isolation.c: In function 'housekeeping_affine':
   kernel/sched/isolation.c:70:22: error: assignment to expression with array type
       housekeeping_mask = housekeeping_get_mask(flags);
                         ^
   kernel/sched/isolation.c: In function 'housekeeping_test_cpu':
   kernel/sched/isolation.c:82:22: error: assignment to expression with array type
       housekeeping_mask = housekeeping_get_mask(flags);
                         ^
   kernel/sched/isolation.c: In function 'housekeeping_init':
>> kernel/sched/isolation.c:100:6: warning: the address of 'housekeeping_mask_isolcpus' will always evaluate as 'true' [-Waddress]
     if (housekeeping_mask_isolcpus)
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/sched/isolation.c:102:6: warning: the address of 'housekeeping_mask_nohz_full' will always evaluate as 'true' [-Waddress]
     if (housekeeping_mask_nohz_full)
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/housekeeping_get_mask +24 kernel/sched/isolation.c

    23	
  > 24	static cpumask_var_t housekeeping_get_mask(enum hk_flags flags)
    25	{
    26		if (flags & (HK_FLAG_DOMAIN | HK_FLAG_MANAGED_IRQ))
  > 27			return housekeeping_mask_isolcpus;
    28	
    29		/* set by isolcpus=nohz only */
    30		if ((flags & HK_FLAG_TICK) && !(housekeeping_flags & HK_FLAG_RCU))
    31			return housekeeping_mask_isolcpus;
    32	
    33		return housekeeping_mask_nohz_full;
    34	}
    35	
    36	int housekeeping_any_cpu(enum hk_flags flags)
    37	{
    38		cpumask_var_t housekeeping_mask;
    39		int cpu;
    40	
    41		if (static_branch_unlikely(&housekeeping_overridden)) {
    42			if (housekeeping_flags & flags) {
  > 43				housekeeping_mask = housekeeping_get_mask(flags);
    44				cpu = sched_numa_find_closest(housekeeping_mask, smp_processor_id());
    45				if (cpu < nr_cpu_ids)
    46					return cpu;
    47	
    48				return cpumask_any_and(housekeeping_mask, cpu_online_mask);
    49			}
    50		}
    51		return smp_processor_id();
    52	}
    53	EXPORT_SYMBOL_GPL(housekeeping_any_cpu);
    54	
    55	const struct cpumask *housekeeping_cpumask(enum hk_flags flags)
    56	{
    57		if (static_branch_unlikely(&housekeeping_overridden))
    58			if (housekeeping_flags & flags)
  > 59				return housekeeping_get_mask(flags);
    60		return cpu_possible_mask;
    61	}
    62	EXPORT_SYMBOL_GPL(housekeeping_cpumask);
    63	
    64	void housekeeping_affine(struct task_struct *t, enum hk_flags flags)
    65	{
    66		if (static_branch_unlikely(&housekeeping_overridden))
    67			if (housekeeping_flags & flags) {
    68				cpumask_var_t housekeeping_mask;
    69	
    70				housekeeping_mask = housekeeping_get_mask(flags);
    71				set_cpus_allowed_ptr(t, housekeeping_mask);
    72			}
    73	}
    74	EXPORT_SYMBOL_GPL(housekeeping_affine);
    75	
    76	bool housekeeping_test_cpu(int cpu, enum hk_flags flags)
    77	{
    78		if (static_branch_unlikely(&housekeeping_overridden))
    79			if (housekeeping_flags & flags) {
    80				cpumask_var_t housekeeping_mask;
    81	
    82				housekeeping_mask = housekeeping_get_mask(flags);
    83				return cpumask_test_cpu(cpu, housekeeping_mask);
    84			}
    85		return true;
    86	}
    87	EXPORT_SYMBOL_GPL(housekeeping_test_cpu);
    88	
    89	void __init housekeeping_init(void)
    90	{
    91		if (!housekeeping_flags)
    92			return;
    93	
    94		static_branch_enable(&housekeeping_overridden);
    95	
    96		if (housekeeping_flags & HK_FLAG_TICK)
    97			sched_tick_offload_init();
    98	
    99		/* We need at least one CPU to handle housekeeping work */
 > 100		if (housekeeping_mask_isolcpus)
   101			WARN_ON_ONCE(cpumask_empty(housekeeping_mask_isolcpus));
 > 102		if (housekeeping_mask_nohz_full)
   103			WARN_ON_ONCE(cpumask_empty(housekeeping_mask_nohz_full));
   104	}
   105	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28982 bytes --]