From: Danh Doan <congdanhqx@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Alba Mendez via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Alba Mendez <me@alba.sh>
Subject: Re: [PATCH] pack-format: document missing fields
Date: Fri, 10 Apr 2020 08:19:25 +0700 [thread overview]
Message-ID: <20200410011925.GB2462@danh.dev> (raw)
In-Reply-To: <xmqqlfn4mjm3.fsf@gitster.c.googlers.com>
On 2020-04-09 14:31:32-0700, Junio C Hamano <gitster@pobox.com> wrote:
> "Alba Mendez via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > 4-byte version number (network byte order):
> > - Git currently accepts version number 2 or 3 but
> > + Git currently accepts version number 2 or 3 but
> > generates version 2 only.
>
> Hmph, what is this hunk about?
The original line is "<TAB><SPACE>Git", she changed to 9 <SPACE>
to match with other lines.
I guess she set tabstop=4, this paragraph will be mis-aligned on that.
> > - (undeltified representation)
> > - n-byte type and length (3-bit type, (n-1)*7+4-bit length)
> > - compressed data
> > -
> > - (deltified representation)
> > - n-byte type and length (3-bit type, (n-1)*7+4-bit length)
> > - 20-byte base object name if OBJ_REF_DELTA or a negative relative
> > - offset from the delta object's position in the pack if this
> > - is an OBJ_OFS_DELTA object
Alba, if you gonna change the above <TAB> to 8 <SPACE> above, you may
want to change here, too.
This paragraph was written with tabstop=4 in mind.
And it's in the context of below hunk.
I'm not sure if changing <TAB> to 8 <SPACE> was expected in this
file because <TAB> and <SPACE> is also mixed in "Pack file entry"
section.
--
Danh
prev parent reply other threads:[~2020-04-10 1:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 19:11 [PATCH] pack-format: document missing fields Alba Mendez via GitGitGadget
2020-04-09 21:31 ` Junio C Hamano
2020-04-10 1:19 ` Danh Doan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200410011925.GB2462@danh.dev \
--to=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=me@alba.sh \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.