From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext2fs: Fix error checking in dx_link()
Date: Thu, 9 Apr 2020 23:52:35 -0400 [thread overview]
Message-ID: <20200410035235.GK45598@mit.edu> (raw)
In-Reply-To: <20200330090932.29445-2-jack@suse.cz>
On Mon, Mar 30, 2020 at 11:09:31AM +0200, Jan Kara wrote:
> dx_lookup() uses errcode_t return values. As such anything non-zero is
> an error, not values less than zero. Fix the error checking to avoid
> crashes on corrupted filesystems.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
next prev parent reply other threads:[~2020-04-10 3:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 9:09 [PATCH 0/2] Fixes for dir_index support in libext2fs Jan Kara
2020-03-30 9:09 ` [PATCH 1/2] ext2fs: Fix error checking in dx_link() Jan Kara
2020-03-30 13:24 ` Lukas Czerner
2020-03-30 13:48 ` Lukas Czerner
2020-03-30 14:55 ` Jan Kara
2020-04-10 3:52 ` Theodore Y. Ts'o [this message]
2020-03-30 9:09 ` [PATCH 2/2] ext2fs: Fix off-by-one in dx_grow_tree() Jan Kara
2020-03-30 13:27 ` Lukas Czerner
2020-03-30 14:55 ` Jan Kara
2020-03-31 11:33 ` Lukas Czerner
2020-03-31 14:30 ` Jan Kara
2020-04-10 4:33 ` Theodore Y. Ts'o
2020-04-10 15:09 ` Jan Kara
2020-04-10 4:32 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200410035235.GK45598@mit.edu \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.