All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH for 4.4.y] x86/vdso: Fix lsl operand order
Date: Fri, 10 Apr 2020 10:42:01 +0200	[thread overview]
Message-ID: <20200410084201.GA1670984@kroah.com> (raw)
In-Reply-To: <20200408082430.4132299-1-nobuhiro1.iwamatsu@toshiba.co.jp>

On Wed, Apr 08, 2020 at 05:24:30PM +0900, Nobuhiro Iwamatsu wrote:
> From: Samuel Neves <sneves@dei.uc.pt>
> 
> commit e78e5a91456fcecaa2efbb3706572fe043766f4d upstream.
> 
> In the __getcpu function, lsl is using the wrong target and destination
> registers. Luckily, the compiler tends to choose %eax for both variables,
> so it has been working so far.
> 
> Fixes: a582c540ac1b ("x86/vdso: Use RDPID in preference to LSL when available")
> Signed-off-by: Samuel Neves <sneves@dei.uc.pt>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Acked-by: Andy Lutomirski <luto@kernel.org>
> Cc: stable@vger.kernel.org
> Link: https://lkml.kernel.org/r/20180901201452.27828-1-sneves@dei.uc.pt
> Signed-off-by: Nobuhiro Iwamatsu (CIP) <nobuhiro1.iwamatsu@toshiba.co.jp>
> ---
>  arch/x86/include/asm/vgtod.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

What about 4.9?  I can't take a patch for 4.4 without also it being in
newer kernels.

ANd always cc: all the people involved in a patch, let them have a say
if this is ok or not.

Please fix up and resend for both trees.

thanks,

greg k-h

  reply	other threads:[~2020-04-10  8:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08  8:24 [PATCH for 4.4.y] x86/vdso: Fix lsl operand order Nobuhiro Iwamatsu
2020-04-10  8:42 ` Greg KH [this message]
2020-04-13  4:50   ` nobuhiro1.iwamatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200410084201.GA1670984@kroah.com \
    --to=greg@kroah.com \
    --cc=nobuhiro1.iwamatsu@toshiba.co.jp \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.