From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Date: Fri, 10 Apr 2020 12:14:06 +0000 Subject: Re: drm/tve200: Checking for a failed platform_get_irq() call in tve200_probe() Message-Id: <20200410121406.GA31761@ravnborg.org> List-Id: References: <0263f4fb-c349-7651-b590-8722cdd30c85@web.de> <20200410101831.GA27723@ravnborg.org> <235b500a-0e5e-9ca3-4be5-9026c7d9f87f@web.de> In-Reply-To: <235b500a-0e5e-9ca3-4be5-9026c7d9f87f@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Markus Elfring Cc: Tang Bin , David Airlie , kernel-janitors@vger.kernel.org, LKML , dri-devel@lists.freedesktop.org Hi Markus. On Fri, Apr 10, 2020 at 12:56:25PM +0200, Markus Elfring wrote: > > The right way to check for errors is to check if the return value is > > less than 0. > > Thanks for your constructive feedback. > > I was unsure if I noticed another programming mistake. > > > > Could you please audit all uses of platform_get_irq() in drivers/gpu/ > > I found 20 source files from the software “Linux next-20200408” > which seem to contain similar update candidates. > Would you like to clarify any extensions for improved applications > of scripts with the semantic patch language (Coccinelle software) > for corresponding analysis and transformation purposes? Please just send a series of patches, one for each driver. Each changelog needs to explain the rationale behind the change. Look at how this is often done. As for coccinelle - I cannot help you. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BCDAC2BB1D for ; Fri, 10 Apr 2020 12:14:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF3472083E for ; Fri, 10 Apr 2020 12:14:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF3472083E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 45BBA6E2A0; Fri, 10 Apr 2020 12:14:13 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5DC506E2A0 for ; Fri, 10 Apr 2020 12:14:12 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 6B5A080530; Fri, 10 Apr 2020 14:14:08 +0200 (CEST) Date: Fri, 10 Apr 2020 14:14:06 +0200 From: Sam Ravnborg To: Markus Elfring Subject: Re: drm/tve200: Checking for a failed platform_get_irq() call in tve200_probe() Message-ID: <20200410121406.GA31761@ravnborg.org> References: <0263f4fb-c349-7651-b590-8722cdd30c85@web.de> <20200410101831.GA27723@ravnborg.org> <235b500a-0e5e-9ca3-4be5-9026c7d9f87f@web.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <235b500a-0e5e-9ca3-4be5-9026c7d9f87f@web.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=XpTUx2N9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=JsGlSLdvelpcWIy28Y0A:9 a=QEXdDO2ut3YA:10 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tang Bin , David Airlie , kernel-janitors@vger.kernel.org, LKML , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgTWFya3VzLgoKT24gRnJpLCBBcHIgMTAsIDIwMjAgYXQgMTI6NTY6MjVQTSArMDIwMCwgTWFy a3VzIEVsZnJpbmcgd3JvdGU6Cj4gPiBUaGUgcmlnaHQgd2F5IHRvIGNoZWNrIGZvciBlcnJvcnMg aXMgdG8gY2hlY2sgaWYgdGhlIHJldHVybiB2YWx1ZSBpcwo+ID4gbGVzcyB0aGFuIDAuCj4gCj4g VGhhbmtzIGZvciB5b3VyIGNvbnN0cnVjdGl2ZSBmZWVkYmFjay4KPiAKPiBJIHdhcyB1bnN1cmUg aWYgSSBub3RpY2VkIGFub3RoZXIgcHJvZ3JhbW1pbmcgbWlzdGFrZS4KPiAKPiAKPiA+IENvdWxk IHlvdSBwbGVhc2UgYXVkaXQgYWxsIHVzZXMgb2YgcGxhdGZvcm1fZ2V0X2lycSgpIGluIGRyaXZl cnMvZ3B1Lwo+IAo+IEkgZm91bmQgMjAgc291cmNlIGZpbGVzIGZyb20gdGhlIHNvZnR3YXJlIOKA nExpbnV4IG5leHQtMjAyMDA0MDjigJ0KPiB3aGljaCBzZWVtIHRvIGNvbnRhaW4gc2ltaWxhciB1 cGRhdGUgY2FuZGlkYXRlcy4KPiBXb3VsZCB5b3UgbGlrZSB0byBjbGFyaWZ5IGFueSBleHRlbnNp b25zIGZvciBpbXByb3ZlZCBhcHBsaWNhdGlvbnMKPiBvZiBzY3JpcHRzIHdpdGggdGhlIHNlbWFu dGljIHBhdGNoIGxhbmd1YWdlIChDb2NjaW5lbGxlIHNvZnR3YXJlKQo+IGZvciBjb3JyZXNwb25k aW5nIGFuYWx5c2lzIGFuZCB0cmFuc2Zvcm1hdGlvbiBwdXJwb3Nlcz8KUGxlYXNlIGp1c3Qgc2Vu ZCBhIHNlcmllcyBvZiBwYXRjaGVzLCBvbmUgZm9yIGVhY2ggZHJpdmVyLgpFYWNoIGNoYW5nZWxv ZyBuZWVkcyB0byBleHBsYWluIHRoZSByYXRpb25hbGUgYmVoaW5kIHRoZSBjaGFuZ2UuCkxvb2sg YXQgaG93IHRoaXMgaXMgb2Z0ZW4gZG9uZS4KCkFzIGZvciBjb2NjaW5lbGxlIC0gSSBjYW5ub3Qg aGVscCB5b3UuCgoJU2FtCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 008F1C2BA2B for ; Fri, 10 Apr 2020 12:14:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D33DA2082D for ; Fri, 10 Apr 2020 12:14:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726646AbgDJMOM (ORCPT ); Fri, 10 Apr 2020 08:14:12 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:37402 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726145AbgDJMOM (ORCPT ); Fri, 10 Apr 2020 08:14:12 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 6B5A080530; Fri, 10 Apr 2020 14:14:08 +0200 (CEST) Date: Fri, 10 Apr 2020 14:14:06 +0200 From: Sam Ravnborg To: Markus Elfring Cc: Linus Walleij , dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, LKML , Daniel Vetter , David Airlie , Tang Bin Subject: Re: drm/tve200: Checking for a failed platform_get_irq() call in tve200_probe() Message-ID: <20200410121406.GA31761@ravnborg.org> References: <0263f4fb-c349-7651-b590-8722cdd30c85@web.de> <20200410101831.GA27723@ravnborg.org> <235b500a-0e5e-9ca3-4be5-9026c7d9f87f@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <235b500a-0e5e-9ca3-4be5-9026c7d9f87f@web.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=XpTUx2N9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=JsGlSLdvelpcWIy28Y0A:9 a=QEXdDO2ut3YA:10 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Markus. On Fri, Apr 10, 2020 at 12:56:25PM +0200, Markus Elfring wrote: > > The right way to check for errors is to check if the return value is > > less than 0. > > Thanks for your constructive feedback. > > I was unsure if I noticed another programming mistake. > > > > Could you please audit all uses of platform_get_irq() in drivers/gpu/ > > I found 20 source files from the software “Linux next-20200408” > which seem to contain similar update candidates. > Would you like to clarify any extensions for improved applications > of scripts with the semantic patch language (Coccinelle software) > for corresponding analysis and transformation purposes? Please just send a series of patches, one for each driver. Each changelog needs to explain the rationale behind the change. Look at how this is often done. As for coccinelle - I cannot help you. Sam