From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2scrub: Remove PATH setting from the scripts
Date: Fri, 10 Apr 2020 12:16:35 -0400 [thread overview]
Message-ID: <20200410161635.GP45598@mit.edu> (raw)
In-Reply-To: <20200402134716.3725-1-lczerner@redhat.com>
On Thu, Apr 02, 2020 at 03:47:16PM +0200, Lukas Czerner wrote:
> We don't want to override system setting by changing the PATH. This
> should remain under administrator/user control.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
The reason why the PATH was added is because most users don't have
/sbin or /usr/sbin in their PATH, and if they run "sudo e2scrub",
finding commands like lvcreate, lvremove, et. al., wouldn't be there.
I suppose we could do something like
PATH=$PATH:/sbin:/usr/sbin
instead, but otherwise, users will see some unexpected failures.
- Ted
next prev parent reply other threads:[~2020-04-10 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 13:47 [PATCH] e2scrub: Remove PATH setting from the scripts Lukas Czerner
2020-04-02 15:17 ` Darrick J. Wong
2020-04-10 16:16 ` Theodore Y. Ts'o [this message]
2020-04-16 9:38 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200410161635.GP45598@mit.edu \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.