From: Guru Das Srinagesh <gurus@codeaurora.org>
To: linux-pwm@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Subbaraman Narayanamurthy" <subbaram@codeaurora.org>,
"David Collins" <collinsd@codeaurora.org>,
linux-kernel@vger.kernel.org,
"Maxime Ripard" <mripard@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>
Subject: Re: [PATCH v12 08/11] pwm: sun4i: Use nsecs_to_jiffies to avoid a division
Date: Fri, 10 Apr 2020 12:20:41 -0700 [thread overview]
Message-ID: <20200410192041.GC21571@codeaurora.org> (raw)
In-Reply-To: <436e1a50e603eefb24c8e7b2bd7f7e4838b90e12.1586414867.git.gurus@codeaurora.org>
On Wed, Apr 08, 2020 at 11:52:37PM -0700, Guru Das Srinagesh wrote:
> Since the PWM framework is switching struct pwm_state.period's datatype
> to u64, prepare for this transition by using nsecs_to_jiffies() which
> does away with the need for a division operation.
>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
>
> Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
> ---
> drivers/pwm/pwm-sun4i.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c
> index 5c677c5..1694e69 100644
> --- a/drivers/pwm/pwm-sun4i.c
> +++ b/drivers/pwm/pwm-sun4i.c
> @@ -285,7 +285,7 @@ static int sun4i_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
> val = (duty & PWM_DTY_MASK) | PWM_PRD(period);
> sun4i_pwm_writel(sun4i_pwm, val, PWM_CH_PRD(pwm->hwpwm));
> sun4i_pwm->next_period[pwm->hwpwm] = jiffies +
> - usecs_to_jiffies(cstate.period / 1000 + 1);
> + nsecs_to_jiffies(cstate.period + 1000);
>
> if (state->polarity != PWM_POLARITY_NORMAL)
> ctrl &= ~BIT_CH(PWM_ACT_STATE, pwm->hwpwm);
> --
Hi Chen-Yu,
You had provided your "Acked-by:" [1] for an earlier version of this
patch but now that I've revised the patch based on a review comment I
received [2], could you please review this patch once again?
Thank you.
Guru Das.
[1] https://www.spinics.net/lists/linux-pwm/msg11755.html
[2] https://www.spinics.net/lists/linux-pwm/msg11956.html
next prev parent reply other threads:[~2020-04-10 19:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 6:52 [PATCH v12 00/11] Convert PWM period and duty cycle to u64 Guru Das Srinagesh
2020-04-09 6:52 ` Guru Das Srinagesh
2020-04-09 6:52 ` [PATCH v12 01/11] drm/i915: Use 64-bit division macro Guru Das Srinagesh
2020-04-09 6:52 ` [Intel-gfx] " Guru Das Srinagesh
2020-04-09 6:52 ` Guru Das Srinagesh
2020-04-09 6:52 ` [PATCH v12 02/11] hwmon: pwm-fan: " Guru Das Srinagesh
2020-04-09 6:52 ` [PATCH v12 03/11] ir-rx51: " Guru Das Srinagesh
2020-04-09 6:52 ` [PATCH v12 04/11] pwm: clps711x: Cast period to u32 before use as divisor Guru Das Srinagesh
2020-04-09 6:52 ` [PATCH v12 05/11] pwm: pwm-imx-tpm: Use 64-bit division macro Guru Das Srinagesh
2020-04-09 6:52 ` [PATCH v12 06/11] pwm: imx27: Use 64-bit division macro and function Guru Das Srinagesh
2020-04-10 19:16 ` Guru Das Srinagesh
2020-04-09 6:52 ` [PATCH v12 07/11] pwm: sifive: Use 64-bit division macro Guru Das Srinagesh
2020-04-09 6:52 ` Guru Das Srinagesh
2020-04-09 6:52 ` [PATCH v12 08/11] pwm: sun4i: Use nsecs_to_jiffies to avoid a division Guru Das Srinagesh
2020-04-10 19:20 ` Guru Das Srinagesh [this message]
2020-04-11 5:49 ` Chen-Yu Tsai
2020-04-09 6:52 ` [PATCH v12 09/11] backlight: pwm_bl: Use 64-bit division function Guru Das Srinagesh
2020-04-09 6:52 ` Guru Das Srinagesh
2020-04-09 6:52 ` Guru Das Srinagesh
2020-04-16 9:44 ` Lee Jones
2020-04-16 9:44 ` Lee Jones
2020-04-16 9:44 ` Lee Jones
2020-04-16 17:55 ` Guru Das Srinagesh
2020-04-16 17:55 ` Guru Das Srinagesh
2020-04-16 17:55 ` Guru Das Srinagesh
2020-04-09 6:52 ` [PATCH v12 10/11] clk: pwm: " Guru Das Srinagesh
2020-04-10 19:15 ` Guru Das Srinagesh
2020-04-09 6:52 ` [PATCH v12 11/11] pwm: core: Convert period and duty cycle to u64 Guru Das Srinagesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200410192041.GC21571@codeaurora.org \
--to=gurus@codeaurora.org \
--cc=collinsd@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=subbaram@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.