From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FCBBC2D0EC for ; Fri, 10 Apr 2020 19:45:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5FBE92083E for ; Fri, 10 Apr 2020 19:45:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586547950; bh=c9U8OrXPzk6frqhLN2HldS4XFESUo13MLKIaOOx0aJk=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=bKmJ9b7dItegxCnTD1fItY4Nh4H7sW0i3LN5812uWs89f5Y1VSVRo7cvffgOIBSX2 KW3Tq95Vb7pTbG+0gHSSvVuwBiRtKNK7yR/IXbaX9ZzyHYubW7QypalxNnT6kcBaF6 peJe/2s6cnNDewEei2RlWSdL3DIh1QDPxHdGWnJY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726657AbgDJTpt (ORCPT ); Fri, 10 Apr 2020 15:45:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:54504 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726142AbgDJTpt (ORCPT ); Fri, 10 Apr 2020 15:45:49 -0400 Received: from localhost (mobile-166-170-220-109.mycingular.net [166.170.220.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B18E720801; Fri, 10 Apr 2020 19:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586547949; bh=c9U8OrXPzk6frqhLN2HldS4XFESUo13MLKIaOOx0aJk=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=oKeHSPEtbSVJZMuOzAFicZXHe70ZNxXjWWd+pgHYft6o+6ixfKi7WzlNUJNyq/AZU xl4Qqa98YTjfELxi0UUbol11KixUPBpbmi+Ueg0VviCuESZJ9H+rHaTZFRl9SFwCUm ZhD7/CkXxcQKvF0N1TjYzg5kfQWPTqQSHtdLrJxM= Date: Fri, 10 Apr 2020 14:45:47 -0500 From: Bjorn Helgaas To: Hans de Goede Cc: "Rafael J . Wysocki" , Len Brown , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH] ACPI/PCI: pci_link: use extended_irq union member when setting ext-irq shareable Message-ID: <20200410194547.GA7293@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200410131442.22842-1-hdegoede@redhat.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Apr 10, 2020 at 03:14:42PM +0200, Hans de Goede wrote: > The case ACPI_RESOURCE_TYPE_EXTENDED_IRQ inside acpi_pci_link_set() > is correctly using resource->res.data.extended_irq.foo for most settings, > but for the sharable setting it sofar has accidentally been using > resource->res.data.irq.shareable instead of > resource->res.data.extended_irq.shareable. > > Note that the old code happens to also work because the sharable field > offset is the same for both the acpi_resource_irq and > acpi_resource_extended_irq structs. s/sharable/shareable/ several times above s/sofar/so far/ > Signed-off-by: Hans de Goede Acked-by: Bjorn Helgaas > --- > drivers/acpi/pci_link.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c > index 00a6da2121be..ed3d2182cf2c 100644 > --- a/drivers/acpi/pci_link.c > +++ b/drivers/acpi/pci_link.c > @@ -322,10 +322,10 @@ static int acpi_pci_link_set(struct acpi_pci_link *link, int irq) > resource->res.data.extended_irq.polarity = > link->irq.polarity; > if (link->irq.triggering == ACPI_EDGE_SENSITIVE) > - resource->res.data.irq.shareable = > + resource->res.data.extended_irq.shareable = > ACPI_EXCLUSIVE; > else > - resource->res.data.irq.shareable = ACPI_SHARED; > + resource->res.data.extended_irq.shareable = ACPI_SHARED; Ouch, looks like that copy/paste error has been there since the beginning of git. Nice catch! > resource->res.data.extended_irq.interrupt_count = 1; > resource->res.data.extended_irq.interrupts[0] = irq; > /* ignore resource_source, it's optional */ > -- > 2.26.0 >