All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Iskren Chernev <iskren.chernev@gmail.com>
Cc: linux-arm-msm@vger.kernel.org,
	Daniele Debernardi <drebrez@gmail.com>,
	Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 5/6] ARM: dts: qcom: msm8974-klte: Remove inherited vreg_boost node
Date: Fri, 10 Apr 2020 18:38:33 -0700	[thread overview]
Message-ID: <20200411013833.GI576963@builder.lan> (raw)
In-Reply-To: <20200410023203.192048-6-iskren.chernev@gmail.com>

On Thu 09 Apr 19:32 PDT 2020, Iskren Chernev wrote:

> From: Daniele Debernardi <drebrez@gmail.com>
> 
> The Samsung klte does not have a vreg_boost node. vreg_boost also
> depends on pm8941-gpio which are not present on the klte.
> 

May I ask what PMICs this device actually has, if it doesn't have a
PM8941 GPIO?

Regards,
Bjorn

> Signed-off-by: Daniele Debernardi <drebrez@gmail.com>
> Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
> ---
>  arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts b/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts
> index de0bf6b7e732..ad26c83fee81 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts
> @@ -1,7 +1,5 @@
>  // SPDX-License-Identifier: GPL-2.0
>  #include "qcom-msm8974pro.dtsi"
> -#include "qcom-pm8841.dtsi"
> -#include "qcom-pm8941.dtsi"
>  #include "qcom-pma8084.dtsi"
>  #include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/input/input.h>
> @@ -196,6 +194,8 @@ l27 {
>  			};
>  		};
>  	};
> +
> +	/delete-node/ vreg-boost;
>  };
>  
>  &soc {
> -- 
> 2.26.0
> 

  reply	other threads:[~2020-04-11  1:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-10  2:31 [PATCH 0/6] ARM: dts: qcom: klte: Add support for hw keys, flash and usb Iskren Chernev
2020-04-10  2:31 ` [PATCH 1/6] ARM: dts: qcom: msm8974: Add pma8084 regulator node Iskren Chernev
2020-04-11  1:36   ` Bjorn Andersson
2020-04-10  2:31 ` [PATCH 2/6] ARM: dts: qcom: msm8974-klte: Add regulator nodes Iskren Chernev
2020-04-10  2:32 ` [PATCH 3/6] ARM: dts: qcom: msm8974-klte: Add gpio-keys nodes Iskren Chernev
2020-04-10  2:32 ` [PATCH 4/6] ARM: dts: qcom: msm8974-klte: Add sdhci1 node Iskren Chernev
2020-04-10  2:32 ` [PATCH 5/6] ARM: dts: qcom: msm8974-klte: Remove inherited vreg_boost node Iskren Chernev
2020-04-11  1:38   ` Bjorn Andersson [this message]
2020-04-11 17:21     ` Iskren Chernev
2020-04-10  2:32 ` [PATCH 6/6] ARM: dts: qcom: msm8974-klte: Add USB node Iskren Chernev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200411013833.GI576963@builder.lan \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=drebrez@gmail.com \
    --cc=iskren.chernev@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.