From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH v3 07/23] buildman: Be more selective about which directories to remove
Date: Sat, 11 Apr 2020 11:20:59 -0400 [thread overview]
Message-ID: <20200411152059.GH8031@bill-the-cat> (raw)
In-Reply-To: <20200318154302.16389-5-sjg@chromium.org>
On Wed, Mar 18, 2020 at 09:42:45AM -0600, Simon Glass wrote:
> At present buildman removes any directory it doesn't intend to write
> output into. This is overly expansive since if the output directory
> happens to be somewhere with existing files, they may be removed. Using
> an existing directory for buildman is not a good practice, but since the
> result might be catastrophic, it is best to guard against it.
>
> A previous commit[1] fixed this by refusing to write to a subdirectory
> of the current directory, assumed to have U-Boot source code. But we can
> do better by only removing directories that look like the ones buildman
> creates.
>
> Update the code to do this and add a test.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
>
> [1] 409fc029c40 tools: buildman: Don't use the working dir as build dir
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200411/ffb86b3a/attachment.sig>
next prev parent reply other threads:[~2020-04-11 15:20 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 15:42 [PATCH v3 00/23] gitlab: Simplify the test script Simon Glass
2020-03-18 15:42 ` [PATCH v3 01/23] sandbox: Add documentation about required/useful packages Simon Glass
2020-04-11 15:20 ` Tom Rini
2020-03-18 15:42 ` [PATCH v3 02/23] main: Drop show_boot_progress() prototype Simon Glass
2020-03-23 13:12 ` Tom Rini
2020-04-11 15:20 ` Tom Rini
2020-03-18 15:42 ` [PATCH v3 03/23] buildman: Document the members of BuilderJob Simon Glass
2020-04-11 15:20 ` Tom Rini
2020-03-18 15:42 ` [PATCH v3 04/23] bulidman: Add support for a simple build Simon Glass
2020-04-11 15:20 ` Tom Rini
2020-03-18 15:42 ` [PATCH v3 05/23] buildman: Update help for -d Simon Glass
2020-04-11 15:20 ` Tom Rini
2020-03-18 15:42 ` [PATCH v3 06/23] buildman: Allow ignoring warnings in the return code Simon Glass
2020-03-23 13:12 ` Tom Rini
2020-04-11 15:20 ` Tom Rini
2020-03-18 15:42 ` [PATCH v3 07/23] buildman: Be more selective about which directories to remove Simon Glass
2020-04-11 15:20 ` Tom Rini [this message]
2020-03-18 15:42 ` [PATCH v3 08/23] buildman: Allow building within a subdir of the current dir Simon Glass
2020-04-11 15:21 ` Tom Rini
2020-03-18 15:42 ` [PATCH v3 09/23] buildman: Drop the -a option Simon Glass
2020-03-23 13:13 ` Tom Rini
2020-04-11 15:21 ` Tom Rini
2020-03-18 15:42 ` [PATCH v3 10/23] travis: Don't copy files into .bm-work/ Simon Glass
2020-03-23 13:12 ` Tom Rini
2020-04-11 15:21 ` Tom Rini
2020-03-18 15:42 ` [PATCH v3 11/23] travis: Split the building into two parts Simon Glass
2020-03-23 13:13 ` Tom Rini
2020-04-11 15:21 ` Tom Rini
2020-03-18 15:42 ` [PATCH v3 12/23] gitlab/azure: Use the -w option for sandbox_spl Simon Glass
2020-03-23 13:13 ` Tom Rini
2020-03-23 13:13 ` Tom Rini
2020-04-11 15:21 ` Tom Rini
2020-03-18 15:42 ` [PATCH v3 13/23] travis/gitlab/azure: Use --board buildman flag with test.py Simon Glass
2020-03-23 13:13 ` Tom Rini
2020-04-11 15:21 ` Tom Rini
2020-03-18 15:42 ` [PATCH v3 14/23] travis/gitlab/azure: Drop BUILDMAN variable " Simon Glass
2020-03-23 13:13 ` Tom Rini
2020-04-11 15:21 ` Tom Rini
2020-03-18 15:42 ` [PATCH v3 15/23] travis/gitlab/azure: Drop the buildman -d flag Simon Glass
2020-03-23 13:13 ` Tom Rini
2020-04-11 15:21 ` Tom Rini
2020-03-18 15:42 ` [PATCH v3 16/23] gitlab/azure: Drop unnecessary if..fi when using test.py Simon Glass
2020-03-23 13:13 ` Tom Rini
2020-04-11 15:21 ` Tom Rini
2020-03-18 15:42 ` [PATCH v3 17/23] gitlab/azure: Use -w flag for all test.py builds Simon Glass
2020-03-23 13:13 ` Tom Rini
2020-04-11 15:21 ` Tom Rini
2020-03-18 15:42 ` [PATCH v3 18/23] travis/gitlab/azure: Use bash to avoid a_test_which_does_not_exist Simon Glass
2020-03-23 13:14 ` Tom Rini
2020-04-11 15:22 ` Tom Rini
2020-03-18 15:42 ` [PATCH v3 19/23] travis/gitlab/azure: Use -W to avoid warnings check Simon Glass
2020-03-23 13:14 ` Tom Rini
2020-04-11 15:22 ` Tom Rini
2020-04-15 7:30 ` Michal Simek
2020-04-15 13:57 ` Simon Glass
2020-03-18 15:42 ` [PATCH v3 20/23] travis/gitlab/azure: Enable test_handoff Simon Glass
2020-03-23 13:14 ` Tom Rini
2020-04-11 15:22 ` Tom Rini
2020-03-18 15:42 ` [PATCH v3 21/23] travis/gitlab/azure: Simplify the exit code for test.py Simon Glass
2020-03-23 13:14 ` Tom Rini
2020-04-11 15:22 ` Tom Rini
2020-03-18 15:43 ` [PATCH v3 22/23] travis/gitlab/azure: Drop repeated buildman call with test.py Simon Glass
2020-03-23 13:14 ` Tom Rini
2020-04-11 15:22 ` Tom Rini
2020-03-18 15:43 ` [PATCH v3 23/23] test/py: Allow using buildman to build U-Boot Simon Glass
2020-03-23 13:14 ` Tom Rini
2020-04-11 15:22 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200411152059.GH8031@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.