All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/gdb: Add support for host-gdb with python3
Date: Sat, 11 Apr 2020 15:43:54 +0200	[thread overview]
Message-ID: <20200411154354.367a6113@windsurf.home> (raw)
In-Reply-To: <20200323064621.205273-1-rfried.dev@gmail.com>

On Mon, 23 Mar 2020 08:46:21 +0200
Ramon Fried <rfried.dev@gmail.com> wrote:

> host-gdb was limited to link only with Python 2 although
> it's possible to build Python 3 for host.
> Add the ability to link with Python 3.
> 
> Signed-off-by: Ramon Fried <rfried.dev@gmail.com>
> ---
> v2: Add choice menu for mutaly exclusive selection of Python3/2
>   as suggested by Romain
> 
>  package/gdb/Config.in.host | 16 ++++++++++++++--
>  package/gdb/gdb.mk         |  3 +++
>  2 files changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/package/gdb/Config.in.host b/package/gdb/Config.in.host
> index 5315f10493..e5e8fae5eb 100644
> --- a/package/gdb/Config.in.host
> +++ b/package/gdb/Config.in.host
> @@ -32,10 +32,22 @@ config BR2_PACKAGE_HOST_GDB_TUI
>  	help
>  	  This option enables terminal user interface (TUI) for gdb
>  
> +choice
> +	prompt "Python support"
> +	help
> +	  Select the version of Python you wish to use
> +
>  config BR2_PACKAGE_HOST_GDB_PYTHON
> -	bool "Python support"
> +	bool "Python 2 support"
>  	help
> -	  This option enables the Python support in the cross gdb.
> +	  This option enables the Python 2 support in the cross gdb.
> +
> +config BR2_PACKAGE_HOST_GDB_PYTHON3
> +	bool "Python 3 support"
> +	help
> +	  This option enables the Python 3 support in the cross gdb.
> +

With this choice of two options.. you were forced to have either
Python2 or Python3 support in gdb, it was no longer possible to *not*
have Python support. So I've added a third option,
BR2_PACKAGE_HOST_GDB_NOPYTHON, which allows to not have Python support
in host-gdb.

Applied with this change. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2020-04-11 13:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23  6:46 [Buildroot] [PATCH v2] package/gdb: Add support for host-gdb with python3 Ramon Fried
2020-04-11 13:43 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200411154354.367a6113@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.