From: Josh Triplett <josh@joshtriplett.org>
To: "Jubran, Samih" <sameehj@amazon.com>
Cc: "Machulsky, Zorik" <zorik@amazon.com>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Tzalik, Guy" <gtzalik@amazon.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH] ena: Speed up initialization 90x by reducing poll delays
Date: Sun, 12 Apr 2020 13:27:14 -0700 [thread overview]
Message-ID: <20200412202714.GB3916@localhost> (raw)
In-Reply-To: <1679d519016c4984b67eeb510d50e4b4@EX13D11EUB003.ant.amazon.com>
On Sun, Apr 12, 2020 at 09:37:22AM +0000, Jubran, Samih wrote:
> I wanted to let you know that we are still looking into your patch.
> After some careful considerations we have decided to set the value of
> ENA_POLL_US to 100us. The rationale behind this choice is that the
> device might take up to 1ms to complete the reset operation and we
> don't want to bombard device. We do agree with most of your patch
> and we will be sending one based on it for review.
Thank you, that sounds entirely reasonable.
Please also consider making the probing asynchronous (via linux/async.h)
to allow other initialization to happen in parallel.
prev parent reply other threads:[~2020-04-12 20:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 13:24 Re: [PATCH] ena: Speed up initialization 90x by reducing poll delays Jubran, Samih
2020-03-13 12:28 ` Josh Triplett
2020-04-12 9:37 ` Jubran, Samih
2020-04-12 20:27 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200412202714.GB3916@localhost \
--to=josh@joshtriplett.org \
--cc=akiyano@amazon.com \
--cc=gtzalik@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedb@amazon.com \
--cc=sameehj@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.