From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47995C2BA19 for ; Mon, 13 Apr 2020 05:54:16 +0000 (UTC) Received: from vger.kernel.org (unknown [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 12CC52073E for ; Mon, 13 Apr 2020 05:54:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12CC52073E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-renesas-soc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726292AbgDMFyP (ORCPT ); Mon, 13 Apr 2020 01:54:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.18]:44876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725842AbgDMFyP (ORCPT ); Mon, 13 Apr 2020 01:54:15 -0400 Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C550AC0A3BE0 for ; Sun, 12 Apr 2020 22:54:14 -0700 (PDT) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id A802A8048A; Mon, 13 Apr 2020 07:54:10 +0200 (CEST) Date: Mon, 13 Apr 2020 07:54:09 +0200 From: Sam Ravnborg To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Rob Clark , Jernej Skrabec , Jonas Karlman , Neil Armstrong , linux-renesas-soc@vger.kernel.org, Andrzej Hajda , Sean Paul Subject: Re: [PATCH 1/4] drm: bridge: adv7511: Split EDID read to a separate function Message-ID: <20200413055409.GC6324@ravnborg.org> References: <20200409004610.12346-1-laurent.pinchart+renesas@ideasonboard.com> <20200409004610.12346-2-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200409004610.12346-2-laurent.pinchart+renesas@ideasonboard.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=XpTUx2N9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=P1BnusSwAAAA:8 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=PDnjrxCc1ieJvtjYf9YA:9 a=CjuIK1q_8ugA:10 a=D0XLA9XvdZm18NrgonBM:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Laurent. On Thu, Apr 09, 2020 at 03:46:07AM +0300, Laurent Pinchart wrote: > To prepare for the implementation of the DRM bridge connector > operations, move EDID read out of adv7511_get_modes() to a separate > function. > > Signed-off-by: Laurent Pinchart The code do not check if drm_do_get_edid() return NULL. But all functions called with the edid seems to handle a NULL edid well. So thats OK. Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 23 ++++++++++++++------ > 1 file changed, 16 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > index 87b58c1acff4..58d02e92b6b9 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > @@ -589,11 +589,10 @@ static int adv7511_get_edid_block(void *data, u8 *buf, unsigned int block, > * ADV75xx helpers > */ > > -static int adv7511_get_modes(struct adv7511 *adv7511, > - struct drm_connector *connector) > +static struct edid *adv7511_get_edid(struct adv7511 *adv7511, > + struct drm_connector *connector) > { > struct edid *edid; > - unsigned int count; > > /* Reading the EDID only works if the device is powered */ > if (!adv7511->powered) { > @@ -612,15 +611,25 @@ static int adv7511_get_modes(struct adv7511 *adv7511, > if (!adv7511->powered) > __adv7511_power_off(adv7511); > > - > - drm_connector_update_edid_property(connector, edid); > - count = drm_add_edid_modes(connector, edid); > - > adv7511_set_config_csc(adv7511, connector, adv7511->rgb, > drm_detect_hdmi_monitor(edid)); > > cec_s_phys_addr_from_edid(adv7511->cec_adap, edid); > > + return edid; > +} > + > +static int adv7511_get_modes(struct adv7511 *adv7511, > + struct drm_connector *connector) > +{ > + struct edid *edid; > + unsigned int count; > + > + edid = adv7511_get_edid(adv7511, connector); > + > + drm_connector_update_edid_property(connector, edid); > + count = drm_add_edid_modes(connector, edid); > + > kfree(edid); > > return count; > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A9C3C2BB1D for ; Mon, 13 Apr 2020 05:54:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE45C20737 for ; Mon, 13 Apr 2020 05:54:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE45C20737 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EDFEF6E184; Mon, 13 Apr 2020 05:54:14 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id C017C6E184 for ; Mon, 13 Apr 2020 05:54:13 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id A802A8048A; Mon, 13 Apr 2020 07:54:10 +0200 (CEST) Date: Mon, 13 Apr 2020 07:54:09 +0200 From: Sam Ravnborg To: Laurent Pinchart Subject: Re: [PATCH 1/4] drm: bridge: adv7511: Split EDID read to a separate function Message-ID: <20200413055409.GC6324@ravnborg.org> References: <20200409004610.12346-1-laurent.pinchart+renesas@ideasonboard.com> <20200409004610.12346-2-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200409004610.12346-2-laurent.pinchart+renesas@ideasonboard.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=XpTUx2N9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=P1BnusSwAAAA:8 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=PDnjrxCc1ieJvtjYf9YA:9 a=CjuIK1q_8ugA:10 a=D0XLA9XvdZm18NrgonBM:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Jernej Skrabec , Neil Armstrong , Jonas Karlman , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Andrzej Hajda , Sean Paul Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Laurent. On Thu, Apr 09, 2020 at 03:46:07AM +0300, Laurent Pinchart wrote: > To prepare for the implementation of the DRM bridge connector > operations, move EDID read out of adv7511_get_modes() to a separate > function. > > Signed-off-by: Laurent Pinchart The code do not check if drm_do_get_edid() return NULL. But all functions called with the edid seems to handle a NULL edid well. So thats OK. Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 23 ++++++++++++++------ > 1 file changed, 16 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > index 87b58c1acff4..58d02e92b6b9 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > @@ -589,11 +589,10 @@ static int adv7511_get_edid_block(void *data, u8 *buf, unsigned int block, > * ADV75xx helpers > */ > > -static int adv7511_get_modes(struct adv7511 *adv7511, > - struct drm_connector *connector) > +static struct edid *adv7511_get_edid(struct adv7511 *adv7511, > + struct drm_connector *connector) > { > struct edid *edid; > - unsigned int count; > > /* Reading the EDID only works if the device is powered */ > if (!adv7511->powered) { > @@ -612,15 +611,25 @@ static int adv7511_get_modes(struct adv7511 *adv7511, > if (!adv7511->powered) > __adv7511_power_off(adv7511); > > - > - drm_connector_update_edid_property(connector, edid); > - count = drm_add_edid_modes(connector, edid); > - > adv7511_set_config_csc(adv7511, connector, adv7511->rgb, > drm_detect_hdmi_monitor(edid)); > > cec_s_phys_addr_from_edid(adv7511->cec_adap, edid); > > + return edid; > +} > + > +static int adv7511_get_modes(struct adv7511 *adv7511, > + struct drm_connector *connector) > +{ > + struct edid *edid; > + unsigned int count; > + > + edid = adv7511_get_edid(adv7511, connector); > + > + drm_connector_update_edid_property(connector, edid); > + count = drm_add_edid_modes(connector, edid); > + > kfree(edid); > > return count; > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel