From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6896AC2BBC7 for ; Mon, 13 Apr 2020 10:11:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D66B20732 for ; Mon, 13 Apr 2020 10:11:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586772694; bh=nzrj3q/99RKMEWoPxPrj8vKy1qxl7ogMiqqlHfIgacA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=TQ7/PyXaES7BnS6UIt9yV4tZ/2wxXGpxxoWQ883/H46S+NYsMvdKi3kQZbWYSZSoo YfdxRS/x5JxwJXSJ2JtmgW5oUnc9IAyjaYF9lKxxXfRKKK/3WPa1+YIMxKgUqXPww6 D8CVgvy7AC4yvVBA31CgVA9sXkCIZfhfE+I8aZec= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728143AbgDMKLd (ORCPT ); Mon, 13 Apr 2020 06:11:33 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:36614 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728075AbgDMKLc (ORCPT ); Mon, 13 Apr 2020 06:11:32 -0400 Received: by mail-ed1-f65.google.com with SMTP id i7so11349490edq.3; Mon, 13 Apr 2020 03:11:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IHzUNdwPsTQhqLll3sOK8O3xrvJdBlinyJZ6YxNwq5s=; b=EQY2aTx9QZvn4hJbu8mvjayyvAl2zm1DV5RIyc+0eSB7YtkzKGD+3yq8EBkExqJRfC cNa3Bvq2oP6c1RYsmbxZqno06TGcD876gAyiW3kkTVlI8zTARvb85T23jnI/uoDpb/6J 5LaVUJ6hVAkD3x3yJxyVui/7Cy5Dk06fEZsj4cKEPZ37YkGiqmY8C77mdqt//wiMQn5g FMJpjqyFUr6HBdGFFjtoMD3sOqU1FGdGnjwafaRAmYFGG/OFD+vgAP2TV2nCziB2BApL HCC3/9FpxxemsVpaYlACn+xh8fhbeCZBtUBf9o9mfCn8+Sc9WGmqY1jLwDgQ8idcG5cc 6ggA== X-Gm-Message-State: AGi0PuZlOxa39PVrwLnPR162rsr9V7Zesv/TSyDyJXUFdAxR2BW0wt8q Yi7ttTXpTGbbFRKWxVkj75i2SD4R X-Google-Smtp-Source: APiQypLbUzeNvAIZR67vxpLwZzQRg3r3rXpBNYhH+Po0Qp1noxa7A8r1ABhf2bhfL8AcuoH9Rr3W4g== X-Received: by 2002:a05:6402:1383:: with SMTP id b3mr15439537edv.217.1586772689922; Mon, 13 Apr 2020 03:11:29 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id g2sm1307883edm.77.2020.04.13.03.11.28 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Apr 2020 03:11:29 -0700 (PDT) Date: Mon, 13 Apr 2020 12:11:27 +0200 From: Krzysztof Kozlowski To: Jonathan Bakker Cc: tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, kgene@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: samsung: Correct setting of eint wakeup mask on s5pv210 Message-ID: <20200413101127.GA10535@kozik-lap> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sat, Apr 04, 2020 at 10:08:49AM -0700, Jonathan Bakker wrote: > Commit a8be2af0218c ("pinctrl: samsung: Write external wakeup interrupt > mask") started writing the eint wakeup mask from the pinctrl driver. > Unfortunately, it made the assumption that the private retention data > was always a regmap while in the case of s5pv210 it is a raw pointer > to the clock base (as the eint wakeup mask not in the PMU as with newer > Exynos platforms). > > Fixes: a8be2af0218c ("pinctrl: samsung: Write external wakeup interrupt mask") > Signed-off-by: Jonathan Bakker > --- > drivers/pinctrl/samsung/pinctrl-exynos.c | 73 ++++++++++++++++-------- Thanks, applied (with Cc-stable tag). Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86F0EC2BA19 for ; Mon, 13 Apr 2020 10:11:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DED7206E9 for ; Mon, 13 Apr 2020 10:11:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ArFGkSmA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DED7206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QqUrAMkzNabBIkn7st56ocQzD+aJad2KZCKLj1g6ggY=; b=ArFGkSmANTeIvr 1gsBlw+u25SglEesHOwSRb8HIanIHnQ9+/2+uTXC5JG0kedEiPm2t+3q4aqlND8OoCrgxH3es2B7H KEfChQvnYIgwHsXR+uIvY1kJIA+26PuwdCkny7iLTNqe+wD5RepDonE1lGDPQ5pTKlCB1BuW30cDP o3CIOtiGXc33NhXJDaQOwasx5JMEsuVtEQb/f5ocFLu9lHNlPqBQhfwFoFk4mrpuPbqTviPXVfnpT GVCPgb6glFX5mJWkZZQjKh8JGcACmc/DP4uiv9ejpAmQAPRiscyqLbltxK5EpVcDT1Ze64lbNW+xq SpFGfXvTYyJFfP9OxwoA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jNw3z-0000hk-Dl; Mon, 13 Apr 2020 10:11:35 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jNw3w-0000hJ-F5 for linux-arm-kernel@lists.infradead.org; Mon, 13 Apr 2020 10:11:33 +0000 Received: by mail-ed1-f65.google.com with SMTP id ca21so8995647edb.7 for ; Mon, 13 Apr 2020 03:11:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IHzUNdwPsTQhqLll3sOK8O3xrvJdBlinyJZ6YxNwq5s=; b=nM4M+j/sGoJAgY51ZLKAskL5VoLsRTCs0I3D+UMhBFt7jWG/C4hVjNxsQiqKjQpQss N4efsafH350aj9ArcZGomD9iHl2zuzgimHSKNIQcAoEsOwyeq7zyVftmlfVfzV2jkpzg TIVcKpjAPZ4amK7nA3Z3omGJ9UgHSN05EHoTKmw0GBhZ91yxcGcFRREcOviWZdo8lCXy R+Gq+sSQlGEcqXEGoxvi9LoanobkM7sgIEPRQ9yH4eHJ0V6LyPJBAtKZbuMUlrYyIQRj Y3IaLlqDuJem770oaLXyMll4+vbPo7T81DG6Tyk/E7PYXyRQIiKHXL5DCjb5M5HlsnX5 phqA== X-Gm-Message-State: AGi0Pua+eQQ+Na1Sqxtkr1HKnrx1PKATgV01n5RtqQ0P1zNSvv4MMZqq Mb/LNjwualUBm93J8TxF2w4= X-Google-Smtp-Source: APiQypLbUzeNvAIZR67vxpLwZzQRg3r3rXpBNYhH+Po0Qp1noxa7A8r1ABhf2bhfL8AcuoH9Rr3W4g== X-Received: by 2002:a05:6402:1383:: with SMTP id b3mr15439537edv.217.1586772689922; Mon, 13 Apr 2020 03:11:29 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id g2sm1307883edm.77.2020.04.13.03.11.28 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Apr 2020 03:11:29 -0700 (PDT) Date: Mon, 13 Apr 2020 12:11:27 +0200 From: Krzysztof Kozlowski To: Jonathan Bakker Subject: Re: [PATCH] pinctrl: samsung: Correct setting of eint wakeup mask on s5pv210 Message-ID: <20200413101127.GA10535@kozik-lap> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200413_031132_501971_3BDC81D7 X-CRM114-Status: GOOD ( 10.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linus.walleij@linaro.org, tomasz.figa@gmail.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, kgene@kernel.org, s.nawrocki@samsung.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 04, 2020 at 10:08:49AM -0700, Jonathan Bakker wrote: > Commit a8be2af0218c ("pinctrl: samsung: Write external wakeup interrupt > mask") started writing the eint wakeup mask from the pinctrl driver. > Unfortunately, it made the assumption that the private retention data > was always a regmap while in the case of s5pv210 it is a raw pointer > to the clock base (as the eint wakeup mask not in the PMU as with newer > Exynos platforms). > > Fixes: a8be2af0218c ("pinctrl: samsung: Write external wakeup interrupt mask") > Signed-off-by: Jonathan Bakker > --- > drivers/pinctrl/samsung/pinctrl-exynos.c | 73 ++++++++++++++++-------- Thanks, applied (with Cc-stable tag). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel