From: Leon Romanovsky <leon@kernel.org>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Arjan van de Ven <arjan@linux.intel.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net v1] net/sched: Don't print dump stack in event of transmission timeout
Date: Mon, 13 Apr 2020 14:25:30 +0300 [thread overview]
Message-ID: <20200413112530.GL334007@unreal> (raw)
In-Reply-To: <BN8PR12MB3266B788233057BB024B92B3D3DD0@BN8PR12MB3266.namprd12.prod.outlook.com>
On Mon, Apr 13, 2020 at 11:01:42AM +0000, Jose Abreu wrote:
> From: Leon Romanovsky <leon@kernel.org>
> Date: Apr/13/2020, 11:54:08 (UTC+00:00)
>
> > Sorry, if I misunderstood you, but you are proposing to count traffic, right?
> >
> > If yes, RDMA traffic bypasses the SW stack and not visible to the kernel, hence
> > the BQL will count only ETH portion of that mixed traffic, while RDMA traffic
> > is the one who "blocked" transmission channel (QP in RDMA terminology).
>
> Sorry but you don't mention in your commit message that this is RDMA
> specific so that's why I brought up the topic of BQL. Apologies for the
> misunderstood.
No problem, I'm glad that you asked those questions, hope that my
answers clear the rationale behind change from WARN_ON to be pr_err().
Thanks
>
> ---
> Thanks,
> Jose Miguel Abreu
next prev parent reply other threads:[~2020-04-13 11:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 6:08 [PATCH net v1] net/sched: Don't print dump stack in event of transmission timeout Leon Romanovsky
2020-04-12 18:59 ` Jakub Kicinski
2020-04-12 19:23 ` Leon Romanovsky
2020-04-13 4:19 ` David Miller
2020-04-13 5:03 ` Leon Romanovsky
2020-04-13 9:01 ` Jose Abreu
2020-04-13 10:20 ` Leon Romanovsky
2020-04-13 10:37 ` Jose Abreu
2020-04-13 10:54 ` Leon Romanovsky
2020-04-13 11:01 ` Jose Abreu
2020-04-13 11:25 ` Leon Romanovsky [this message]
2020-04-13 17:22 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413112530.GL334007@unreal \
--to=leon@kernel.org \
--cc=Jose.Abreu@synopsys.com \
--cc=arjan@linux.intel.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.