From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A041C2BA19 for ; Mon, 13 Apr 2020 12:58:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43BA220767 for ; Mon, 13 Apr 2020 12:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586782692; bh=IuesiDdKuTFLdMkQnFkzjJmikYEfulB5uV/jLl08rjc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=YnuJQlTx10O4Q4OYquVeToNQH35J/uH6auwdvAuXWGiyBzLIrbSGYqeyPB7StpXyV LTaz1wA++zKmMneZsDyEUm6DzquFGpKbENDfU6UjdQEIaqvb+ft4bydhFVNwn1GRla LP5DhwRDYC5kIrDPxNLaEXlXox4NChf6bS2sQvOo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729663AbgDMM6L (ORCPT ); Mon, 13 Apr 2020 08:58:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:54266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727853AbgDMM6K (ORCPT ); Mon, 13 Apr 2020 08:58:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B9BBF2073E; Mon, 13 Apr 2020 12:58:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586782690; bh=IuesiDdKuTFLdMkQnFkzjJmikYEfulB5uV/jLl08rjc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xZtaYU17UeaAIkLF9UXgHgSF2mMm8QOYQDtu2x4MeTJew13bk69BH3xeXewew6SM8 fufkJS3Q4Xq7SAH0D3nmNN+aa6hGmKq/72syMNVpUA5MpryegVI4nxe22dB67PZ8Fh ll20MIUHL+YLHf7zMNYgtxyQcyS7aV+IZ/JcMMgM= Date: Mon, 13 Apr 2020 14:58:08 +0200 From: Greg Kroah-Hartman To: Oscar Carter Cc: Forest Bond , devel@driverdev.osuosl.org, Malcolm Priestley , linux-kernel@vger.kernel.org, Colin Ian King Subject: Re: [PATCH] staging: vt6656: Use BIT() macro instead of bit shift operator Message-ID: <20200413125808.GA3140872@kroah.com> References: <20200412093311.5279-1-oscar.carter@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200412093311.5279-1-oscar.carter@gmx.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 12, 2020 at 11:33:11AM +0200, Oscar Carter wrote: > Use the BIT() macro instead of the bit left shift operator. So the code > is more clear. > > It's safe to remove the casting to u16 type because the value obtained > never exceeds 16 bits. So the casting is unnecessary. > > Signed-off-by: Oscar Carter > --- > drivers/staging/vt6656/card.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) This too did not apply :(