From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Or Gerlitz <gerlitz.or@gmail.com>
Cc: Roi Dayan <roid@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Vlad Buslov <vladbu@mellanox.com>, Oz Shlomo <ozsh@mellanox.com>,
Paul Blakey <paulb@mellanox.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Leon Romanovsky <leonro@mellanox.com>
Subject: Re: [PATCH net] net/mlx5e: limit log messages due to (ovs) probing to _once
Date: Mon, 13 Apr 2020 11:29:13 -0300 [thread overview]
Message-ID: <20200413142913.GE137894@localhost.localdomain> (raw)
In-Reply-To: <CAJ3xEMibkDZmLYokvHinjiuv3V_ZA7x3s4SBpXbp2_BDpTUjgA@mail.gmail.com>
On Mon, Apr 13, 2020 at 09:35:54AM +0300, Or Gerlitz wrote:
> On Sun, Apr 12, 2020 at 11:15 AM Roi Dayan <roid@mellanox.com> wrote:
>
> [..]
>
> > in some places we already only use extack without netdev_warn.
> > so currently in favor in removing the other logs if extack error exists to
> > avoid flooding the log
>
> +1 for using the modern messaging way (extack)
> +1 for driver diet by avoiding double messaging systems
Nice, okay. Do you prefer to do it yourselves? Otherwise I'll just
remove the _warn messages I changed in the initial patch.
prev parent reply other threads:[~2020-04-13 14:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 0:11 [PATCH net] net/mlx5e: limit log messages due to (ovs) probing to _once Marcelo Ricardo Leitner
2020-04-03 2:27 ` Saeed Mahameed
2020-04-03 2:48 ` marcelo.leitner
2020-04-08 19:51 ` Saeed Mahameed
2020-04-08 21:54 ` marcelo.leitner
2020-04-08 22:38 ` Saeed Mahameed
2020-04-08 22:42 ` marcelo.leitner
2020-04-12 8:14 ` Roi Dayan
2020-04-13 6:35 ` Or Gerlitz
2020-04-13 14:29 ` Marcelo Ricardo Leitner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413142913.GE137894@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=gerlitz.or@gmail.com \
--cc=leonro@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ozsh@mellanox.com \
--cc=paulb@mellanox.com \
--cc=roid@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=vladbu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.