From: "Denys Dmytriyenko" <denis@denix.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: meta-arm@lists.yoctoproject.org
Subject: Re: [meta-arm][PATCH] optee-os: Mark recipes dormant by default
Date: Mon, 13 Apr 2020 20:48:44 -0400 [thread overview]
Message-ID: <20200414004844.GC11927@denix.org> (raw)
In-Reply-To: <CAMKF1soD3EJLe4tLfH-t8ovh0rMc5T4hAy+862aeGr_cRU1uww@mail.gmail.com>
On Mon, Apr 13, 2020 at 04:55:25PM -0700, Khem Raj wrote:
> On Mon, Apr 13, 2020 at 3:40 PM Denys Dmytriyenko <denis@denix.org> wrote:
> >
> > On Mon, Apr 13, 2020 at 06:06:37PM -0400, Denys Dmytriyenko wrote:
> > > On Mon, Apr 13, 2020 at 06:05:19PM -0400, Jon Mason wrote:
> > > > On Sat, Apr 11, 2020 at 10:45:31PM -0700, Khem Raj wrote:
> > > > > all arm SOCs may not support optee and there are non-arm machines too
> > > > > this makes this recipe fit into mutli-BSP environments, platforms which
> > > > > support optee should be specifically called out via COMPATIBLE_MACHINE,
> > > > > for general case it remains 'null'
> > > >
> > > > Pulled into the master branch.
> > >
> > > I think this was due to the parsing issues, resolved by another patch. What's
> > > the point of masking this recipes now?
> > >
> > >
> > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > > > ---
> > > > >
> > > > > diff --git a/meta-arm/recipes-security/optee/optee.inc b/meta-arm/recipes-security/optee/optee.inc
> > > > > new file mode 100644
> > > > > index 0000000..a12521d
> > > > > --- /dev/null
> > > > > +++ b/meta-arm/recipes-security/optee/optee.inc
> > > > > @@ -0,0 +1,2 @@
> > > > > +COMPATIBLE_MACHINE = "null"
> > > > > +# Please add supported machines below
> >
> > Can we instead of neutering all OPTEE recipes and requiring BSPs to provide
> > bbappends with COMPATIBLE_MACHINE for opt-in, add EXCLUDE_FROM_WORLD = "1"?
>
> its fine to provide it via bbappends, as long as it is per machine,
> which really supports Optee
> it is also educational to understand the recipes thats way, excluding
> from world is then not required.
This is rather backwards. OPTEE is widely used these days.
What's the harm for the recipe to be fully open and compatible, if it's not
being built by default?
Otherwise, we should similarly neuter ATF, U-boot and even kernel - not
all platforms are supported by those and require per-machine support and
configarion added. Why not require those to be opt-in via bbappends?
--
Denys
next prev parent reply other threads:[~2020-04-14 0:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 5:45 [meta-arm][PATCH] optee-os: Mark recipes dormant by default Khem Raj
2020-04-13 22:05 ` Jon Mason
2020-04-13 22:06 ` Denys Dmytriyenko
[not found] ` <16058061C39D13E2.17445@lists.yoctoproject.org>
2020-04-13 22:40 ` Denys Dmytriyenko
2020-04-13 23:55 ` Khem Raj
2020-04-14 0:48 ` Denys Dmytriyenko [this message]
2020-04-20 13:50 ` Diego Sueiro
2020-04-20 17:02 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414004844.GC11927@denix.org \
--to=denis@denix.org \
--cc=meta-arm@lists.yoctoproject.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.