Re: [PATCH 2/2] crypto: Remove unnecessary memzero_explicit()

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2442 bytes --]

Hi Waiman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.7-rc1 next-20200413]
[cannot apply to mmotm/master cryptodev/master crypto/master mac80211-next/master mac80211/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Waiman-Long/mm-treewide-Rename-kzfree-to-kfree_sensitive/20200414-052843
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 8f3d9f354286745c751374f5f1fcafee6b3f3136
config: x86_64-randconfig-s1-20200414 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/crypto/amlogic/amlogic-gxl-cipher.c: In function 'meson_cipher_exit':
>> drivers/crypto/amlogic/amlogic-gxl-cipher.c:345:2: error: expected ';' before 'crypto_free_sync_skcipher'
     crypto_free_sync_skcipher(op->fallback_tfm);
     ^~~~~~~~~~~~~~~~~~~~~~~~~

vim +345 drivers/crypto/amlogic/amlogic-gxl-cipher.c

48fe583fe54177 Corentin Labbe 2019-10-17  339  
48fe583fe54177 Corentin Labbe 2019-10-17  340  void meson_cipher_exit(struct crypto_tfm *tfm)
48fe583fe54177 Corentin Labbe 2019-10-17  341  {
48fe583fe54177 Corentin Labbe 2019-10-17  342  	struct meson_cipher_tfm_ctx *op = crypto_tfm_ctx(tfm);
48fe583fe54177 Corentin Labbe 2019-10-17  343  
7deb7a15114330 Waiman Long    2020-04-13  344  	kfree_sensitive(op->key)
48fe583fe54177 Corentin Labbe 2019-10-17 @345  	crypto_free_sync_skcipher(op->fallback_tfm);
48fe583fe54177 Corentin Labbe 2019-10-17  346  }
48fe583fe54177 Corentin Labbe 2019-10-17  347  

:::::: The code at line 345 was first introduced by commit
:::::: 48fe583fe54177bfb80f348e2a5cc34c3f710095 crypto: amlogic - Add crypto accelerator for amlogic GXL

:::::: TO: Corentin Labbe <clabbe@baylibre.com>
:::::: CC: Herbert Xu <herbert@gondor.apana.org.au>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37290 bytes --]