From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B53FC2BB85 for ; Tue, 14 Apr 2020 09:32:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08674206D5 for ; Tue, 14 Apr 2020 09:32:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="SLPDu0MU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08674206D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7AACC89D86; Tue, 14 Apr 2020 09:32:48 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3BD6989D86 for ; Tue, 14 Apr 2020 09:32:47 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9DD4F521; Tue, 14 Apr 2020 11:32:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1586856764; bh=AmiIyigIad3hEHv25MmhHHleJ8azfFTTznoUmVHbEyc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SLPDu0MUpbb2Ecb0cY5z6OUYo9xc4Pbo9DkMEyr6U/nMiKeNuJbXUiTrlw6TMfjb3 3Fnx9UpgXzNHsB27T8yLbhcbKdfkbW1l42+FdqdTpReKfoWUHVC0+Gov/Ywk2TkiWW mGWvciaFQRPxQvYtvA00dxpTYzjpfGHxwjvnvb8k= Date: Tue, 14 Apr 2020 12:32:33 +0300 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH v1 1/4] drm/panel: add connector type to boe, hv070wsa-100 panel Message-ID: <20200414093233.GA19819@pendragon.ideasonboard.com> References: <20200414084727.8326-1-sam@ravnborg.org> <20200414084727.8326-2-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200414084727.8326-2-sam@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Neil Armstrong , Jonas Karlman , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sam, Thank you for the patch. On Tue, Apr 14, 2020 at 10:47:24AM +0200, Sam Ravnborg wrote: > The boe,hv070wsa-100 panel is a LVDS panel. > Fix connector type to reflect this. > > With this change users of this panel do not have to specify the > connector type. > > Signed-off-by: Sam Ravnborg > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > drivers/gpu/drm/panel/panel-simple.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 44a1f5dfb571..749115c98ee2 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1059,6 +1059,7 @@ static const struct panel_desc boe_hv070wsa = { > .width = 154, > .height = 90, > }, > + .connector_type = DRM_MODE_CONNECTOR_LVDS, While at it, could you set .bus_format too ? It's particularly important for LVDS panels. > }; > > static const struct drm_display_mode boe_nv101wxmn51_modes[] = { -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel