From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3913C2BA19 for ; Tue, 14 Apr 2020 12:55:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 888942076D for ; Tue, 14 Apr 2020 12:55:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="OQKalRLb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502393AbgDNMzn (ORCPT ); Tue, 14 Apr 2020 08:55:43 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:36278 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2502380AbgDNMzl (ORCPT ); Tue, 14 Apr 2020 08:55:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lPJUTtOIuy5BU8KE3cbCX1+ZdoLjw8YCm2osvNCEtqA=; b=OQKalRLbHaPc/mThQHVJCQCVts EfVmzRhb1CJnXwB/0mYpg64P5UqAlFbld5Z2fKyY4rqortNFWWbMw19bLFFY2+yNz8dPh7oLttV2v 2gePZkHhgS/eDO5UQBruCQ4OCwgYZhl+XrvO7MpXbQ0lSUCjlQGDWBi9qclBpT2UiQfs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jOL6D-002eMr-IC; Tue, 14 Apr 2020 14:55:33 +0200 Date: Tue, 14 Apr 2020 14:55:33 +0200 From: Andrew Lunn To: Andy Duan Cc: David Miller , netdev , Chris Healy , Chris Heally Subject: Re: [EXT] [PATCH] net: ethernet: fec: Replace interrupt driven MDIO with polled IO Message-ID: <20200414125533.GD611399@lunn.ch> References: <20200414004551.607503-1-andrew@lunn.ch> <20200414034920.GA611399@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > If we switch to polling mode, it is better to add usleep or cpu relax between IO > Polling. Hi Andy Yes. I can do that. I've been wanting to try iopoll.h. I will see what the performance impacts are. > > I also have follow up patches which allows the bus to be run at higher speeds. > > The Ethernet switch i have on the bus is happy to run a 5MHz rather than the > > default 2.5MHz. > > Please compatible with 2.5Hz for your following patches. Yes. I'm adding device tree properties. If the property is not present, it will default to 2.5MHz. Same for preamble suppression, if the boolean DT property is not present, it will not suppress it, so keeping backwards compatibility. Andrew