From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Tue, 14 Apr 2020 15:05:24 +0000 Subject: Re: [PATCH] brcm80211: remove redundant pointer 'address' Message-Id: <20200414150525.01C0AC44792@smtp.codeaurora.org> List-Id: References: <20200405133906.381358-1-colin.king@canonical.com> In-Reply-To: <20200405133906.381358-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , "David S . Miller" , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Colin King wrote: > From: Colin Ian King > > Pointer 'address' is being assigned and updated in a few places > by it is never read. Hence the assignments are redundant and can > be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 09667ea7ce6d brcm80211: remove redundant pointer 'address' -- https://patchwork.kernel.org/patch/11474705/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9F3DC2BA19 for ; Tue, 14 Apr 2020 15:06:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A69892076D for ; Tue, 14 Apr 2020 15:06:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="EOp9gF3K" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407262AbgDNPGA (ORCPT ); Tue, 14 Apr 2020 11:06:00 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:58409 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407238AbgDNPFx (ORCPT ); Tue, 14 Apr 2020 11:05:53 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586876753; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=4IdPWOKkKu70gb9XZsmEuJuo7DR0jOPptRPhAGVcGa8=; b=EOp9gF3KcUHGDZUCtq+HScYM/5Q1DCMGMVxuTU6OSQ+vaoZBNRDgZRmjtw9bIac0KQscrBWE Az3gdkIA7SCf46TahiXvrGfCRFzd/a3gSSc4mkwJH+dMk7H7KkOaopf9AIS7xbDB2S0usfy/ GMbnbFNRXoKRs4pkKfAY0LurZmQ= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e95d135.7f2672b35998-smtp-out-n05; Tue, 14 Apr 2020 15:05:25 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 01C0AC44792; Tue, 14 Apr 2020 15:05:24 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id A555DC433CB; Tue, 14 Apr 2020 15:05:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A555DC433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] brcm80211: remove redundant pointer 'address' From: Kalle Valo In-Reply-To: <20200405133906.381358-1-colin.king@canonical.com> References: <20200405133906.381358-1-colin.king@canonical.com> To: Colin King Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , "David S . Miller" , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20200414150525.01C0AC44792@smtp.codeaurora.org> Date: Tue, 14 Apr 2020 15:05:24 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Colin King wrote: > From: Colin Ian King > > Pointer 'address' is being assigned and updated in a few places > by it is never read. Hence the assignments are redundant and can > be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 09667ea7ce6d brcm80211: remove redundant pointer 'address' -- https://patchwork.kernel.org/patch/11474705/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches