All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Stable <stable@vger.kernel.org>
Subject: Re: [PATCH] b43legacy: Fix case where channel status is corrupted
Date: Tue, 14 Apr 2020 15:08:29 +0000 (UTC)	[thread overview]
Message-ID: <20200414150829.586F4C433CB@smtp.codeaurora.org> (raw)
In-Reply-To: <20200407190043.1686-1-Larry.Finger@lwfinger.net>

Larry Finger <Larry.Finger@lwfinger.net> wrote:

> This patch fixes commit 75388acd0cd8 ("add mac80211-based driver for
> legacy BCM43xx devices")
> 
> In https://bugzilla.kernel.org/show_bug.cgi?id=207093, a defect in
> b43legacy is reported. Upon testing, thus problem exists on PPC and
> X86 platforms, is present in the oldest kernel tested (3.2), and
> has been present in the driver since it was first added to the kernel.
> 
> The problem is a corrupted channel status received from the device.
> Both the internal card in a PowerBook G4 and the PCMCIA version
> (Broadcom BCM4306 with PCI ID 14e4:4320) have the problem. Only Rev, 2
> (revision 4 of the 802.11 core) of the chip has been tested. No other
> devices using b43legacy are available for testing.
> 
> Various sources of the problem were considered. Buffer overrun and
> other sources of corruption within the driver were rejected because
> the faulty channel status is always the same, not a random value.
> It was concluded that the faulty data is coming from the device, probably
> due to a firmware bug. As that source is not available, the driver
> must take appropriate action to recover.
> 
> At present, the driver reports the error, and them continues to process
> the bad packet. This is believed that to be a mistake, and the correct
> action is to drop the correpted packet.
> 
> Fixes: 75388acd0cd8 ("add mac80211-based driver for legacy BCM43xx devices")
> Cc: Stable <stable@vger.kernel.org>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Reported-and-tested by: F. Erhard <erhard_f@mailbox.org>

Patch applied to wireless-drivers-next.git, thanks.

ec4d3e3a0545 b43legacy: Fix case where channel status is corrupted

-- 
https://patchwork.kernel.org/patch/11478883/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

      reply	other threads:[~2020-04-14 15:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07 19:00 [PATCH] b43legacy: Fix case where channel status is corrupted Larry Finger
2020-04-14 15:08 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200414150829.586F4C433CB@smtp.codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.