From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dejin Zheng <zhengdejin5@gmail.com>
Cc: linus.walleij@linaro.org, patrice.chotard@st.com, info@metux.net,
allison@lohutok.net, nehal-bakulchandra.shah@amd.com,
tglx@linutronix.de, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] i2c: img-scb: remove duplicate dev_err()
Date: Tue, 14 Apr 2020 19:20:02 +0300 [thread overview]
Message-ID: <20200414162002.GX34613@smile.fi.intel.com> (raw)
In-Reply-To: <20200414155047.GA10848@nuc8i5>
On Tue, Apr 14, 2020 at 11:50:47PM +0800, Dejin Zheng wrote:
> On Tue, Apr 14, 2020 at 05:38:37PM +0300, Andy Shevchenko wrote:
> > On Tue, Apr 14, 2020 at 10:26:50PM +0800, Dejin Zheng wrote:
> > > it will print an error message by itself when platform_get_irq()
> > > goes wrong. so don't need dev_err() in here again.
> >
> > In the future, please use something like this
> > scripts/get_maintainer.pl --git --git-min-percent=67
> > when retrieve Cc list for the mail.
> >
> Andy, Thank you for reminding me again, if I used it, There are only two
> email addresses.
>
> scripts/get_maintainer.pl --git --git-min-percent=67 v1-0001-i2c-img-scb-remove-duplicate-dev_err.patch
> linux-i2c@vger.kernel.org (open list:I2C SUBSYSTEM HOST DRIVERS)
> linux-kernel@vger.kernel.org (open list)
Nice, you found a bug in MAINTAINERS database.
> > FWIW,
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> Thanks very much for your review.
I recommend to resend a new version with those mailings lists followed by
Wolfram included in the Cc list. Don't forget to add my tag in the commit
message and bump the version.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-04-14 16:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 14:26 [PATCH v1] i2c: img-scb: remove duplicate dev_err() Dejin Zheng
2020-04-14 14:38 ` Andy Shevchenko
2020-04-14 15:50 ` Dejin Zheng
2020-04-14 16:20 ` Andy Shevchenko [this message]
2020-04-14 16:42 ` Wolfram Sang
2020-04-14 16:46 ` Andy Shevchenko
2020-04-14 16:56 ` Wolfram Sang
-- strict thread matches above, loose matches on Subject: below --
2020-04-14 15:48 Markus Elfring
2020-04-15 2:54 ` Dejin Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414162002.GX34613@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=allison@lohutok.net \
--cc=info@metux.net \
--cc=linus.walleij@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nehal-bakulchandra.shah@amd.com \
--cc=patrice.chotard@st.com \
--cc=tglx@linutronix.de \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.