From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-mips@vger.kernel.org, dietmar.eggemann@arm.com,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Huacai Chen" <chenhc@lemote.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Robert Richter" <rric@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Jason Cooper" <jason@lakedaemon.net>,
"Marc Zyngier" <maz@kernel.org>,
"Paul Burton" <paulburton@kernel.org>,
"Allison Randal" <allison@lohutok.net>,
"Enrico Weigelt" <info@metux.net>,
"Kate Stewart" <kstewart@linuxfoundation.org>,
"Vladimir Kondratiev" <vladimir.kondratiev@intel.com>,
"Alexios Zavras" <alexios.zavras@intel.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"Zhou Yanjie" <zhouyanjie@zoho.com>,
=?GB18030?B?1tzn/L3c?= (Zhou Yanjie) <zhouyanjie@wanyeetech.com>,
"YunQiang Su" <syq@debian.org>, "Arnd Bergmann" <arnd@arndb.de>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Matt Redfearn" <matt.redfearn@mips.com>,
"Richard Fontana" <rfontana@redhat.com>,
"Steve Winslow" <swinslow@gmail.com>,
"afzal mohammed" <afzal.mohd.ma@gmail.com>,
"Peter Xu" <peterx@redhat.com>,
"Mike Rapoport" <rppt@linux.ibm.com>,
"Kamal Dasu" <kdasu.kdev@gmail.com>,
"Oleksij Rempel" <linux@rempel-privat.de>,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
oprofile-list@lists.sf.net, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 01/11] MIPS: setup: Drop prefill_possible_map
Date: Tue, 14 Apr 2020 16:39:57 +0800 [thread overview]
Message-ID: <20200414163957.00006d65@flygoat.com> (raw)
In-Reply-To: <20200414082123.GA6459@bogus>
On Tue, 14 Apr 2020 09:21:36 +0100
Sudeep Holla <sudeep.holla@arm.com> wrote:
> On Sun, Apr 12, 2020 at 11:20:31AM +0800, Jiaxun Yang wrote:
> > All the plat_smp_setup are setting up possible cpus in their
> > platform code. So prefill_possible_map is actually overwriting
> > platform's setup, which seems unreasonable.
> >
>
> Why don't you rearrange the code so that this still remains as is and
> the platforms can override if they need. If you do so, you don't need
> the change in 04/11 as I suggested previously.
Actually this code break a case that cpumask is not continuous.
It do happen on some MIPS platforms.
Yes. rearrange this is a option but I think it is making the logic
unnecessarily complex.
If you think that's better I'll do so.
Thanks.
>
--
Jiaxun Yang
next prev parent reply other threads:[~2020-04-14 8:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 3:20 [PATCH v2 00/11] MIPS: Topology & DeviceTree CPU rework v2 Jiaxun Yang
2020-04-12 3:20 ` [PATCH v2 01/11] MIPS: setup: Drop prefill_possible_map Jiaxun Yang
2020-04-14 8:21 ` Sudeep Holla
2020-04-14 8:39 ` Jiaxun Yang [this message]
2020-04-12 3:20 ` [PATCH v2 02/11] MIPS: prom: Add helper to parse CPU node in dt Jiaxun Yang
2020-04-12 3:20 ` [PATCH v2 03/11] arch_topology: Make it avilable for MIPS Jiaxun Yang
2020-04-14 8:25 ` Sudeep Holla
2020-04-12 3:20 ` [PATCH v2 04/11] arch_topology: Reset all cpus in reset_cpu_topology Jiaxun Yang
2020-04-14 8:27 ` Sudeep Holla
2020-04-14 8:35 ` Jiaxun Yang
2020-04-14 10:03 ` Sudeep Holla
2020-04-12 3:20 ` [PATCH v2 05/11] MIPS: Switch to arch_topology Jiaxun Yang
2020-04-12 5:24 ` kbuild test robot
2020-04-12 5:24 ` kbuild test robot
2020-04-12 5:24 ` kbuild test robot
2020-04-12 5:24 ` kbuild test robot
2020-04-12 7:49 ` Jiaxun Yang
2020-04-12 9:39 ` Marc Zyngier
2020-04-12 9:39 ` Marc Zyngier
2020-04-12 11:32 ` Jiaxun Yang
2020-04-12 3:20 ` [PATCH v2 06/11] MIPS: Kernel: Switch to new topology interface Jiaxun Yang
2020-04-12 3:20 ` [PATCH v2 07/11] MIPS: CPS & MT: " Jiaxun Yang
2020-04-12 3:20 ` [PATCH v2 08/11] irqchip: mips-cpu: " Jiaxun Yang
2020-04-12 3:20 ` [PATCH v2 09/11] MIPS: bmips: " Jiaxun Yang
2020-04-12 3:20 ` [PATCH v2 10/11] MIPS: nlm: " Jiaxun Yang
2020-04-12 3:20 ` [PATCH v2 11/11] MIPS: Loongson64: " Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414163957.00006d65@flygoat.com \
--to=jiaxun.yang@flygoat.com \
--cc=acme@kernel.org \
--cc=afzal.mohd.ma@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=chenhc@lemote.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=f.fainelli@gmail.com \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=jason@lakedaemon.net \
--cc=jolsa@redhat.com \
--cc=kdasu.kdev@gmail.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=mark.rutland@arm.com \
--cc=matt.redfearn@mips.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=oprofile-list@lists.sf.net \
--cc=paul@crapouillou.net \
--cc=paulburton@kernel.org \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rfontana@redhat.com \
--cc=rppt@linux.ibm.com \
--cc=rric@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=swinslow@gmail.com \
--cc=syq@debian.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=vladimir.kondratiev@intel.com \
--cc=zhouyanjie@wanyeetech.com \
--cc=zhouyanjie@zoho.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.