From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 14 Apr 2020 18:49:25 +0000 Subject: Re: [PATCH] pwm: Add missing '\n' in log messages Message-Id: <20200414184925.GA12862@kadam> List-Id: References: <20200411153528.30130-1-christophe.jaillet@wanadoo.fr> <20200414135827.GB3593749@ulmo> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET Cc: Thierry Reding , paul@crapouillou.net, Joe Perches , u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Huh... If you look at dev_vprintk_emit(). It looks like if create_syslog_header() returns a string then vprintk_store() will add a newline. I guess that means that dev_printk() can't be used to pr_cont(). And probably that's deliberate because using pr_cont() after boot is racy anyway. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH] pwm: Add missing '\n' in log messages Date: Tue, 14 Apr 2020 21:49:25 +0300 Message-ID: <20200414184925.GA12862@kadam> References: <20200411153528.30130-1-christophe.jaillet@wanadoo.fr> <20200414135827.GB3593749@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: kernel-janitors-owner@vger.kernel.org To: Christophe JAILLET Cc: Thierry Reding , paul@crapouillou.net, Joe Perches , u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-pwm@vger.kernel.org Huh... If you look at dev_vprintk_emit(). It looks like if create_syslog_header() returns a string then vprintk_store() will add a newline. I guess that means that dev_printk() can't be used to pr_cont(). And probably that's deliberate because using pr_cont() after boot is racy anyway. regards, dan carpenter