From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Date: Tue, 14 Apr 2020 19:02:11 +0000 Subject: Re: [PATCH v2] RDMA/cm: Fix an error check in cm_alloc_id_priv() Message-Id: <20200414190211.GA12156@ziepe.ca> List-Id: References: <20200406145109.GQ20941@ziepe.ca> <20200407093714.GA80285@mwanda> In-Reply-To: <20200407093714.GA80285@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Doug Ledford , Matthew Wilcox , Leon Romanovsky , Danit Goldberg , Parav Pandit , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org On Tue, Apr 07, 2020 at 12:37:14PM +0300, Dan Carpenter wrote: > The xa_alloc_cyclic_irq() function returns either 0 or 1 on success and > negatives on error. This code treats 1 as an error and returns > ERR_PTR(1) which will cause an Oops in the caller. > > Fixes: ae78ff3a0f0c ("RDMA/cm: Convert local_id_table to XArray") > Signed-off-by: Dan Carpenter > Reviewed-by: Matthew Wilcox (Oracle) > --- > v2: Use the correct Fixes tag and add Matthew to the CC list. > > drivers/infiniband/core/cm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-next, thanks Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 436ECC2BA19 for ; Tue, 14 Apr 2020 19:02:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1CE9A206A2 for ; Tue, 14 Apr 2020 19:02:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="kq8L7OtZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504602AbgDNTCP (ORCPT ); Tue, 14 Apr 2020 15:02:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2504599AbgDNTCN (ORCPT ); Tue, 14 Apr 2020 15:02:13 -0400 Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81192C061A0E for ; Tue, 14 Apr 2020 12:02:13 -0700 (PDT) Received: by mail-qt1-x843.google.com with SMTP id w29so10765248qtv.3 for ; Tue, 14 Apr 2020 12:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YzNurIVAkA4jvr9JwIfo85IEn9Zw+h56w3Sd2PzkLjs=; b=kq8L7OtZXEWYxYz6h6w0mi8JQeSIMbo6QIlTDZ9JAHqkfX8Jty7Cn32BRwp1ePR0fB 2foBW+NRr7W/TzadyKNOOEHortpa1y8CZ7xtgKWuDjR3n3lhVUsM/4XXq2SJyg0FsLou 2ySz+HwaJ8tEfn8TTFiMU9i6LfD0u/u+ZcMA+xxmZZln0H3ZkgRUcllktsL528ZzXIqk wGZl6RGjE+lq7jWGgfsdN2krB3Lnj0OXTropOnQyjWKEbDbPWkc6o7wuJTaWAV++ToGn kJ1mHuqu7brf6zm8oHJcDtOprMUFecAvDo/zU67C/rUZN9W3a2EFUSmw1U7Om4VMbQUI 2Yog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YzNurIVAkA4jvr9JwIfo85IEn9Zw+h56w3Sd2PzkLjs=; b=D0exxmu32x6zzcdKwP12uBcq3BQHrFa8sMkRSvfRlLTDfUd8k9ITgKSR2sx6kHiK91 5fouF5T0x5ZWRv10hBgiSImuA7qLI57J3bFXUA+j847/2Xpk1Ml2UHLvIWO787379Yio oohayzlAT5X3cXq4j4sPbHmp3cl8ir412/m9JJCDe5ho4SPO8EofmLyJozswB2EJmclo NAQNobSgHmzdz2WGyi002DXhI1kARlLPo7iH7zpf8roG/g+AR59Go7zwU7QoTaw2Rzxi RoZwukyPTyy4udIPZHs1CzntnipyeqrMVPE7ggwr2zMqq2xuwSzbmSWQ+bYSEXPZ0dQX DBdQ== X-Gm-Message-State: AGi0PuZn7Pz65cpnzZqHEu6MHtWMrrz2EWFrB6f+OUHOAqOCJVwwtLv8 /9OY9uX33UuIcKMsz4eoJBx8Zw== X-Google-Smtp-Source: APiQypLU4njxISewbeTdGwEAqrIizC/SwzWOGIcnAkggwhqcfrcb3NI5iAhyrMMYVqLYy9DENvOK6w== X-Received: by 2002:aed:2442:: with SMTP id s2mr17254378qtc.153.1586890932619; Tue, 14 Apr 2020 12:02:12 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id n67sm10957048qke.88.2020.04.14.12.02.12 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Apr 2020 12:02:12 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jOQp1-0003Ad-Jy; Tue, 14 Apr 2020 16:02:11 -0300 Date: Tue, 14 Apr 2020 16:02:11 -0300 From: Jason Gunthorpe To: Dan Carpenter Cc: Doug Ledford , Matthew Wilcox , Leon Romanovsky , Danit Goldberg , Parav Pandit , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2] RDMA/cm: Fix an error check in cm_alloc_id_priv() Message-ID: <20200414190211.GA12156@ziepe.ca> References: <20200406145109.GQ20941@ziepe.ca> <20200407093714.GA80285@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200407093714.GA80285@mwanda> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Apr 07, 2020 at 12:37:14PM +0300, Dan Carpenter wrote: > The xa_alloc_cyclic_irq() function returns either 0 or 1 on success and > negatives on error. This code treats 1 as an error and returns > ERR_PTR(1) which will cause an Oops in the caller. > > Fixes: ae78ff3a0f0c ("RDMA/cm: Convert local_id_table to XArray") > Signed-off-by: Dan Carpenter > Reviewed-by: Matthew Wilcox (Oracle) > --- > v2: Use the correct Fixes tag and add Matthew to the CC list. > > drivers/infiniband/core/cm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-next, thanks Jason