All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jason Yan <yanaijie@huawei.com>
Cc: lorenzo.pieralisi@arm.com, amurray@thegoodpenguin.co.uk,
	bhelgaas@google.com, p.zabel@pengutronix.de,
	gustavo.pimentel@synopsys.com, eswara.kota@linux.intel.com,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] PCI: dwc: intel: make intel_pcie_cpu_addr() static
Date: Wed, 15 Apr 2020 13:07:42 +0300	[thread overview]
Message-ID: <20200415100742.GR34613@smile.fi.intel.com> (raw)
In-Reply-To: <20200415084953.6533-1-yanaijie@huawei.com>

On Wed, Apr 15, 2020 at 04:49:53PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
> 
> drivers/pci/controller/dwc/pcie-intel-gw.c:456:5: warning: symbol
> 'intel_pcie_cpu_addr' was not declared. Should it be static?

Please, learn how to use get_maintainers.pl to avoid spamming people.
Hint:
	scripts/get_maintainer.pl --git --git-min-percent=67
would give advantage, though it still requires a common sense to be applied.

> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>  drivers/pci/controller/dwc/pcie-intel-gw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/controller/dwc/pcie-intel-gw.c
> index fc2a12212dec..2d8dbb318087 100644
> --- a/drivers/pci/controller/dwc/pcie-intel-gw.c
> +++ b/drivers/pci/controller/dwc/pcie-intel-gw.c
> @@ -453,7 +453,7 @@ static int intel_pcie_msi_init(struct pcie_port *pp)
>  	return 0;
>  }
>  
> -u64 intel_pcie_cpu_addr(struct dw_pcie *pcie, u64 cpu_addr)
> +static u64 intel_pcie_cpu_addr(struct dw_pcie *pcie, u64 cpu_addr)
>  {
>  	return cpu_addr + BUS_IATU_OFFSET;
>  }
> -- 
> 2.21.1
> 

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2020-04-15 10:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15  8:49 [PATCH] PCI: dwc: intel: make intel_pcie_cpu_addr() static Jason Yan
2020-04-15 10:07 ` Andy Shevchenko [this message]
2020-04-15 13:09   ` Jason Yan
2020-05-05 10:47 ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200415100742.GR34613@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=amurray@thegoodpenguin.co.uk \
    --cc=bhelgaas@google.com \
    --cc=eswara.kota@linux.intel.com \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=hulkci@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=p.zabel@pengutronix.de \
    --cc=yanaijie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.