From: Peter Zijlstra <peterz@infradead.org>
To: Will Deacon <will@kernel.org>
Cc: Muchun Song <songmuchun@bytedance.com>,
mingo@redhat.com, mingo@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] seqlock: Use while instead of if+goto in __read_seqcount_begin
Date: Wed, 15 Apr 2020 13:44:41 +0200 [thread overview]
Message-ID: <20200415114441.GG20730@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200414134830.GB28750@willie-the-truck>
On Tue, Apr 14, 2020 at 02:48:31PM +0100, Will Deacon wrote:
> Oh yeah, good thinking. Didn't spot that one, but it should work well as
> long as smp_cond_load_relaxed() always implies a control dependency (surely
> it has to?)
Well, yeah, but then you know as well as I do that compilers are dodgy
pieces of crap which are out to get you. Still, I too can't see how it
could mess this up.
next prev parent reply other threads:[~2020-04-15 12:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 13:45 [PATCH] seqlock: Use while instead of if+goto in __read_seqcount_begin Muchun Song
2020-04-10 11:56 ` Will Deacon
2020-04-14 8:58 ` [External] " Muchun Song
2020-04-14 11:05 ` Peter Zijlstra
2020-04-14 12:01 ` [External] " Muchun Song
2020-04-15 11:41 ` Peter Zijlstra
2020-04-14 13:48 ` Will Deacon
2020-04-15 11:44 ` Peter Zijlstra [this message]
2020-04-15 9:37 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415114441.GG20730@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=songmuchun@bytedance.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.