From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Michal Kubecek <mkubecek@suse.cz>,
David Jander <david@protonic.nl>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
mkl@pengutronix.de
Subject: Re: [PATCH v1] ethtool: provide UAPI for PHY master/slave configuration.
Date: Wed, 15 Apr 2020 15:11:04 +0200 [thread overview]
Message-ID: <20200415131104.GA657811@lunn.ch> (raw)
In-Reply-To: <20200415121209.12197-1-o.rempel@pengutronix.de>
On Wed, Apr 15, 2020 at 02:12:09PM +0200, Oleksij Rempel wrote:
> This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of
> auto-negotiation support, we needed to be able to configure the
> MASTER-SLAVE role of the port manually or from an application in user
> space.
Hi Oleksij
This is a nice way to do this.
> +/* Port mode */
> +#define PORT_MODE_MASTER 0x00
> +#define PORT_MODE_SLAVE 0x01
> +#define PORT_MODE_MASTER_FORCE 0x02
> +#define PORT_MODE_SLAVE_FORCE 0x03
> +#define PORT_MODE_UNKNOWN 0xff
It is not clear to me what PORT_MODE_MASTER and PORT_MODE_SLAVE. Do
these mean to negotiate master/slave? Maybe some comments, or clearer
names?
Andrew
next prev parent reply other threads:[~2020-04-15 13:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 12:12 [PATCH v1] ethtool: provide UAPI for PHY master/slave configuration Oleksij Rempel
2020-04-15 12:19 ` Oleksij Rempel
2020-04-15 12:43 ` Michal Kubecek
2020-04-15 13:00 ` Oleksij Rempel
2020-04-15 14:14 ` Russell King - ARM Linux admin
2020-04-15 13:08 ` Oleksij Rempel
2020-04-15 13:11 ` Andrew Lunn [this message]
2020-04-15 13:37 ` Oleksij Rempel
2020-04-15 13:45 ` Andrew Lunn
2020-04-17 6:48 ` [EXT] " Christian Herber
2020-04-15 21:57 ` Andrew Lunn
2020-04-17 10:11 ` Russell King - ARM Linux admin
2020-04-17 11:28 ` Oleksij Rempel
2020-04-17 11:51 ` Russell King - ARM Linux admin
2020-04-17 14:32 ` Andrew Lunn
2020-04-17 14:35 ` Russell King - ARM Linux admin
-- strict thread matches above, loose matches on Subject: below --
2020-04-15 21:59 kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415131104.GA657811@lunn.ch \
--to=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mkl@pengutronix.de \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.