From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83755C38A29 for ; Wed, 15 Apr 2020 13:44:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E1B320857 for ; Wed, 15 Apr 2020 13:44:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586958272; bh=LBaT8ZJQGI5DoX0BaOKcay3nNpJ8jL6vioLVwcpw1hM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=dc54hSTl0lsJdMHwkhaapuNkp+5zy1uRnYfpIl9T/Vn6YA7ji7ZUQJ1ru4PZg63ON Y1ivvulOq9uSAzdr2aBgnWtgsufs4KFOoF7DjsuMoCxTjZ2lj1uHwQVQs8OZ1CNpWv dE/Y3RZgMk7FflARYTlX/uOURlXxUPciUaaf2+9g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2633451AbgDONo0 (ORCPT ); Wed, 15 Apr 2020 09:44:26 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:38760 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730647AbgDONoW (ORCPT ); Wed, 15 Apr 2020 09:44:22 -0400 Received: by mail-ed1-f66.google.com with SMTP id e5so4874383edq.5; Wed, 15 Apr 2020 06:44:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ue1uYbSCM3f3qpA8DP0y7k1ImrV8BLgfQdpHr8wCsNY=; b=rpO9MnuZ7LUd/ZIOmj2qbKe0/TaEjah/TLCxkZpXoXGjK/A3yPVenorS7cbNxROyh7 WfrRYLna0DDCJX9HtDBU9Tbt0TcWRQ7g8YIGVUmRNB1eT2VySRHIAPGFUzs0PR4ZDAM3 gLwZzmwMxxNsOBlwzCj/81AChokwFjuV2BEmeZMVa5ONQ6B0lvkEe6dx11hrNXlKjPGB PVPGEVLBOgme4fJu727b3Zn4fVRmtzfApq6jFdwMacNwRK8TJ+XvKDO/eYML/ZW7EFD6 bLqAhgpREjkbK5m8Mizjp0mlUttn56QaIDDyAcysI7ZO7EdXf/E8dQHxSEXAqJqhMagR Ahnw== X-Gm-Message-State: AGi0Pua+I8RsrF+K0p94JD3SRwtP2Pa6sEZ4fTZ32X0fVJWvvwSE81v2 6ujeTK0oP6HHd4LFsORbvwjpodqc X-Google-Smtp-Source: APiQypKNYzTDTcjJXJkyJ1tW3CmeNRTTMuezBm45FxKlxDAUOBaCIldgd2OqLmdaCh5e2z6JTgFDtA== X-Received: by 2002:a17:907:118b:: with SMTP id uz11mr4894575ejb.89.1586958259236; Wed, 15 Apr 2020 06:44:19 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id bs8sm2626297ejb.92.2020.04.15.06.44.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Apr 2020 06:44:18 -0700 (PDT) Date: Wed, 15 Apr 2020 15:44:15 +0200 From: Krzysztof Kozlowski To: "H. Nikolaus Schaller" Cc: Jonathan Bakker , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , =?utf-8?Q?Beno=C3=AEt?= Cousson , Tony Lindgren , Paul Cercueil , Ralf Baechle , Paul Burton , James Hogan , Kukjin Kim , Maxime Ripard , Chen-Yu Tsai , Thomas Bogendoerfer , Philipp Rossak , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-omap@vger.kernel.org, openpvrsgx-devgroup@letux.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" Subject: Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node Message-ID: <20200415134415.GA21120@kozik-lap> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, Apr 15, 2020 at 02:50:31PM +0200, H. Nikolaus Schaller wrote: > > > Am 15.04.2020 um 13:49 schrieb Krzysztof Kozlowski : > > > > On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller wrote: > >> > >> From: Jonathan Bakker > >> > >> to add support for SGX540 GPU. > > > > Do not continue the subject in commit msg like it is one sentence. > > These are two separate sentences, so commit msg starts with capital > > letter and it is sentence by itself. > > > >> Signed-off-by: Jonathan Bakker > >> Signed-off-by: H. Nikolaus Schaller > >> --- > >> arch/arm/boot/dts/s5pv210.dtsi | 15 +++++++++++++++ > >> 1 file changed, 15 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi > >> index 2ad642f51fd9..e7fc709c0cca 100644 > >> --- a/arch/arm/boot/dts/s5pv210.dtsi > >> +++ b/arch/arm/boot/dts/s5pv210.dtsi > >> @@ -512,6 +512,21 @@ vic3: interrupt-controller@f2300000 { > >> #interrupt-cells = <1>; > >> }; > >> > >> + g3d: g3d@f3000000 { > >> + compatible = "samsung,s5pv210-sgx540-120"; > >> + reg = <0xf3000000 0x10000>; > >> + interrupt-parent = <&vic2>; > >> + interrupts = <10>; > >> + clock-names = "sclk"; > >> + clocks = <&clocks CLK_G3D>; > > > > Not part of bindings, please remove or add to the bindings. > > Well, the bindings should describe what is common for all SoC > and they are quite different in what they need in addition. > > Thererfore we have no "additionalProperties: false" in the > bindings [PATCH v6 01/12]. If these properties are needed for Exynos-specific implementation, they should be in the bindings. If they are not needed, they should not be here. Take a look at midgard bindings for example. This is a nice starting point for these here. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB392C2BB55 for ; Wed, 15 Apr 2020 13:44:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8151E208FE for ; Wed, 15 Apr 2020 13:44:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YBEFYIn+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8151E208FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GuvKj5eEr8/gkqfnh811vvasNlXifsEy0NzcOVONYe8=; b=YBEFYIn+I+WUTJ tYutxFuO2Ptcs8cLHB8EYa8CPnhjcJkrE+RMAB8H5M4jQW9AvUuLB2iHP59Yp5NKPAEYaO/hfsNNp Ifx0rGB6MO8sS1KLxASZdgtgXq6rxXlS6SWgUtLX+vux1lcFe/SL4JmsGx3OHAZ+6mO9x2hXWxk6T a3v4VSwqzqfh4HzyT0N2oSEz/anibgCldcck9wB8PRscqOKVB3s8AK8QGcJ2gJOUGONBQ3GQZJc5G zhmlzQtsdkjui8h+QoUWGB0B5OMkrPvfjNPDkA0OE5p7QvpPF84KhIWYDUokmPCrzz4FECl2dW77Q TP/ms4ccefdMgHCYW8nA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOiL5-0008MQ-DQ; Wed, 15 Apr 2020 13:44:27 +0000 Received: from mail-ed1-f66.google.com ([209.85.208.66]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOiL1-0008LU-Jf for linux-arm-kernel@lists.infradead.org; Wed, 15 Apr 2020 13:44:24 +0000 Received: by mail-ed1-f66.google.com with SMTP id c7so4898885edl.2 for ; Wed, 15 Apr 2020 06:44:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ue1uYbSCM3f3qpA8DP0y7k1ImrV8BLgfQdpHr8wCsNY=; b=YPnGjBwhJQsN7l6/9Zru4midwcv4zmPJbFJ0Ay4qZbaXxSl9+eRsC1m1JVsWMN5ArJ 3objc1CbdmkLjpCcxyMs6KqZfFp80lSOW7EScplIXPdy+cIZfTaqYYMSWHcFi5xZ5lSu IHCppyORiKAGY2kegZ1EI7Ifrx65HYcuOftRD+aiVvAnsD/jJIYvCxD2GEQJY2Q9dPfr rik1/qeHMthYME3xbVUi+4iv6YybmAW39WwFtvqqdcrbwvEfOc+yhjbi3SfhoIwjLYwl HK8LZMyOMmc3E94lHF0Vsxt+r4/UmgcQm+xScd8W5MlHNV6FhapND7NNAPUdqbw1u2FY L2cQ== X-Gm-Message-State: AGi0PubA5wgZgsDD04xFGFRceWgjCmBb3fNgwhOEY82hi2zRx1gn7kDE b6G8GHZvLm1AD1H0FwJvHzM= X-Google-Smtp-Source: APiQypKNYzTDTcjJXJkyJ1tW3CmeNRTTMuezBm45FxKlxDAUOBaCIldgd2OqLmdaCh5e2z6JTgFDtA== X-Received: by 2002:a17:907:118b:: with SMTP id uz11mr4894575ejb.89.1586958259236; Wed, 15 Apr 2020 06:44:19 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id bs8sm2626297ejb.92.2020.04.15.06.44.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Apr 2020 06:44:18 -0700 (PDT) Date: Wed, 15 Apr 2020 15:44:15 +0200 From: Krzysztof Kozlowski To: "H. Nikolaus Schaller" Subject: Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node Message-ID: <20200415134415.GA21120@kozik-lap> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200415_064423_644638_C63B4E40 X-CRM114-Status: GOOD ( 22.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Airlie , James Hogan , Jonathan Bakker , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Paul Cercueil , "linux-samsung-soc@vger.kernel.org" , linux-omap@vger.kernel.org, Paul Burton , Tony Lindgren , Chen-Yu Tsai , Kukjin Kim , devicetree@vger.kernel.org, =?utf-8?Q?Beno=C3=AEt?= Cousson , Maxime Ripard , Rob Herring , letux-kernel@openphoenux.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Philipp Rossak , openpvrsgx-devgroup@letux.org, "linux-kernel@vger.kernel.org" , Ralf Baechle , Daniel Vetter , kernel@pyra-handheld.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 15, 2020 at 02:50:31PM +0200, H. Nikolaus Schaller wrote: > > > Am 15.04.2020 um 13:49 schrieb Krzysztof Kozlowski : > > > > On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller wrote: > >> > >> From: Jonathan Bakker > >> > >> to add support for SGX540 GPU. > > > > Do not continue the subject in commit msg like it is one sentence. > > These are two separate sentences, so commit msg starts with capital > > letter and it is sentence by itself. > > > >> Signed-off-by: Jonathan Bakker > >> Signed-off-by: H. Nikolaus Schaller > >> --- > >> arch/arm/boot/dts/s5pv210.dtsi | 15 +++++++++++++++ > >> 1 file changed, 15 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi > >> index 2ad642f51fd9..e7fc709c0cca 100644 > >> --- a/arch/arm/boot/dts/s5pv210.dtsi > >> +++ b/arch/arm/boot/dts/s5pv210.dtsi > >> @@ -512,6 +512,21 @@ vic3: interrupt-controller@f2300000 { > >> #interrupt-cells = <1>; > >> }; > >> > >> + g3d: g3d@f3000000 { > >> + compatible = "samsung,s5pv210-sgx540-120"; > >> + reg = <0xf3000000 0x10000>; > >> + interrupt-parent = <&vic2>; > >> + interrupts = <10>; > >> + clock-names = "sclk"; > >> + clocks = <&clocks CLK_G3D>; > > > > Not part of bindings, please remove or add to the bindings. > > Well, the bindings should describe what is common for all SoC > and they are quite different in what they need in addition. > > Thererfore we have no "additionalProperties: false" in the > bindings [PATCH v6 01/12]. If these properties are needed for Exynos-specific implementation, they should be in the bindings. If they are not needed, they should not be here. Take a look at midgard bindings for example. This is a nice starting point for these here. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33E57C2BA19 for ; Wed, 15 Apr 2020 13:44:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10E022074F for ; Wed, 15 Apr 2020 13:44:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10E022074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 93D3E6E936; Wed, 15 Apr 2020 13:44:21 +0000 (UTC) Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id B24936E936 for ; Wed, 15 Apr 2020 13:44:20 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id f12so1118304edn.12 for ; Wed, 15 Apr 2020 06:44:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ue1uYbSCM3f3qpA8DP0y7k1ImrV8BLgfQdpHr8wCsNY=; b=t1tHUxzTiQgXENqpRPkhu4r7D53edZ0m+YyDfE4zZm77mBrAeD+AJk/qDcvaXqE7sj nAyIMVaWsW9+exn0uRkwmZYyYY2s/1D032EXWTzANychHZBBwmhrSGPXpqM77rUzDgDy EFUsCBcmM1V77AuJCMlTC6eu1s2KbqZ1OmdXh/9MmaHYF2/vvqCkqQvnwkzKyhQAh5K/ TngNW9975u9CEFjfFLzT2UaRr+IFp4oEB9q2S5jy2djzxqtXYd9LpsmfG0Du+ArwxHAG XS0tJUsmXrraheqIzm1CGO0dFMuGuXgBtJPARHpM2ymp/nBgfUTsXMn0MZ3srnJ6iVLO 2I5w== X-Gm-Message-State: AGi0PuaOMTkDVzn6sI6awQfAIyyt+wvdaIJqb51QGHlousk9odKMORau NkFP57IG4NZe5ygN7L+XksM= X-Google-Smtp-Source: APiQypKNYzTDTcjJXJkyJ1tW3CmeNRTTMuezBm45FxKlxDAUOBaCIldgd2OqLmdaCh5e2z6JTgFDtA== X-Received: by 2002:a17:907:118b:: with SMTP id uz11mr4894575ejb.89.1586958259236; Wed, 15 Apr 2020 06:44:19 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id bs8sm2626297ejb.92.2020.04.15.06.44.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Apr 2020 06:44:18 -0700 (PDT) Date: Wed, 15 Apr 2020 15:44:15 +0200 From: Krzysztof Kozlowski To: "H. Nikolaus Schaller" Subject: Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node Message-ID: <20200415134415.GA21120@kozik-lap> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Airlie , James Hogan , Jonathan Bakker , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Paul Cercueil , "linux-samsung-soc@vger.kernel.org" , linux-omap@vger.kernel.org, Paul Burton , Tony Lindgren , Chen-Yu Tsai , Kukjin Kim , devicetree@vger.kernel.org, =?utf-8?Q?Beno=C3=AEt?= Cousson , Rob Herring , letux-kernel@openphoenux.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Philipp Rossak , openpvrsgx-devgroup@letux.org, "linux-kernel@vger.kernel.org" , Ralf Baechle , kernel@pyra-handheld.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Apr 15, 2020 at 02:50:31PM +0200, H. Nikolaus Schaller wrote: > > > Am 15.04.2020 um 13:49 schrieb Krzysztof Kozlowski : > > > > On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller wrote: > >> > >> From: Jonathan Bakker > >> > >> to add support for SGX540 GPU. > > > > Do not continue the subject in commit msg like it is one sentence. > > These are two separate sentences, so commit msg starts with capital > > letter and it is sentence by itself. > > > >> Signed-off-by: Jonathan Bakker > >> Signed-off-by: H. Nikolaus Schaller > >> --- > >> arch/arm/boot/dts/s5pv210.dtsi | 15 +++++++++++++++ > >> 1 file changed, 15 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi > >> index 2ad642f51fd9..e7fc709c0cca 100644 > >> --- a/arch/arm/boot/dts/s5pv210.dtsi > >> +++ b/arch/arm/boot/dts/s5pv210.dtsi > >> @@ -512,6 +512,21 @@ vic3: interrupt-controller@f2300000 { > >> #interrupt-cells = <1>; > >> }; > >> > >> + g3d: g3d@f3000000 { > >> + compatible = "samsung,s5pv210-sgx540-120"; > >> + reg = <0xf3000000 0x10000>; > >> + interrupt-parent = <&vic2>; > >> + interrupts = <10>; > >> + clock-names = "sclk"; > >> + clocks = <&clocks CLK_G3D>; > > > > Not part of bindings, please remove or add to the bindings. > > Well, the bindings should describe what is common for all SoC > and they are quite different in what they need in addition. > > Thererfore we have no "additionalProperties: false" in the > bindings [PATCH v6 01/12]. If these properties are needed for Exynos-specific implementation, they should be in the bindings. If they are not needed, they should not be here. Take a look at midgard bindings for example. This is a nice starting point for these here. Best regards, Krzysztof _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel