From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 921A7C38A29 for ; Wed, 15 Apr 2020 13:48:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71ABE2076D for ; Wed, 15 Apr 2020 13:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586958491; bh=oLKtnM9QAPjMl4JNf72BCQ9JFS6WqeJtCw7dnd9y5h0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=nVy0Tzap0bLn4VG7atilQ5ycYB+UKDAPwyMXTw6KcmdCkR58zdDVk/M8+Ud6NHP5a 1wYcwvz/McI3AUcQoQoz0Cd1kJ8JgtfcTNEOngaV8gLAVd/VaXFIwVyKUId7sMwmVN q9INeFqTIKlB1/aSkdIjFPvCKBpfUNYkXXGfRvnk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2636252AbgDONsE (ORCPT ); Wed, 15 Apr 2020 09:48:04 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:36671 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2633569AbgDONsA (ORCPT ); Wed, 15 Apr 2020 09:48:00 -0400 Received: by mail-ed1-f67.google.com with SMTP id i7so4907187edq.3; Wed, 15 Apr 2020 06:47:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mIOZ/sd96Rx46ThWOAXmWIaAK4iqfwYtds7TxEtsnA0=; b=b65oEdfKBbQENn+m6r1YGJMnQQK5bSe4g1HPaD3KzwgECpObb3/ACMCvwfhpuEcPQj KF89eStc3t0zv4U+T9zsDUbnT2GnrJOmEHGN8wyEf8wX+p/H+Jn6yQiQLAaQmmW4TVAV 4bHmw205FEzwXRexi12XK4wWpeYDtL3ZA8KuggwqI/XvALFXT+9PehUCAr2e+kaAE5FV Tc3LllCimCp+J0jG3XVup0qKyH3A/jZpwrhYDM+PyQmxOLGoBmmTVu5xIYqRFC/wgwrY 708HaR3jBZD9POXaX4cpG18kxrzisNG0G4+BNvvsiIxzhmIugnwLU29fBH8idXJH1hco C+ng== X-Gm-Message-State: AGi0PuZdk/gYNsO0DBCI0AgfaOWgGe1zQJXZWlq/N8GDNvq2ZHlS7ZyR 1BgDX/jcGj1pfYxjK3gTSjU= X-Google-Smtp-Source: APiQypL993rtIwMeMfH5wHZyMs+H8Y65XYCjw99y7Fo0rlwZe8pf8YowOuo4m22Vp9YytQslngDtFA== X-Received: by 2002:aa7:c2c3:: with SMTP id m3mr18170324edp.10.1586958478322; Wed, 15 Apr 2020 06:47:58 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id gf12sm2524950ejb.62.2020.04.15.06.47.56 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Apr 2020 06:47:57 -0700 (PDT) Date: Wed, 15 Apr 2020 15:47:54 +0200 From: Krzysztof Kozlowski To: "H. Nikolaus Schaller" Cc: David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , =?utf-8?Q?Beno=C3=AEt?= Cousson , Tony Lindgren , Paul Cercueil , Ralf Baechle , Paul Burton , James Hogan , Kukjin Kim , Maxime Ripard , Chen-Yu Tsai , Thomas Bogendoerfer , Philipp Rossak , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-omap@vger.kernel.org, openpvrsgx-devgroup@letux.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" Subject: Re: [PATCH v6 07/12] ARM: DTS: omap5: add sgx gpu child node Message-ID: <20200415134754.GB21120@kozik-lap> References: <004611c9660943759b635a87484932869927cf74.1586939718.git.hns@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, Apr 15, 2020 at 01:46:06PM +0200, H. Nikolaus Schaller wrote: > Hi Krzysztof, > > > Am 15.04.2020 um 13:38 schrieb Krzysztof Kozlowski : > > > > On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller wrote: > >> > >> and add interrupt. > >> > >> Tested-by: H. Nikolaus Schaller # Pyra-Handheld. > > > > Don't add your own Tested-by tags. These are implied by authorship, > > otherwise all patches people make should have such tag. > > Ok I see. AFAIR it originates in several phases of editing to report on which device it was tested. > > Is there a canonical way of writing "tested-on: ${HARDWARE}"? > > E.g. would this be ok? > > Signed-off: H. Nikolaus Schaller # tested on Pyra-Handheld If you think tested platform is worth mentioning in the commit msg (it will stay there forever, ever, ever) then just add a line like: "Add SGX GPU node. Tested on Pyra-Handheld." >From time to time we add such information to note that only one platform was actually tested. I am not sure what benefit it brings to most cases... but your commit msg is so short that adding one more sentence seems reasonable. :) Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA301C2BB55 for ; Wed, 15 Apr 2020 13:48:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8C0A2074F for ; Wed, 15 Apr 2020 13:48:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="U8+2SUNm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8C0A2074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zTpuBavC31LzjXOr6Wt5mtFH3DwAd+Oq02xgbL2V8J8=; b=U8+2SUNmw5ewsC r93xHIaMRQVpj5axRYrGtXWHJwPX+D7msypWjEbO5rvGxFfxZYX6s9+8ALARoHBBobZVYh/myWP5/ wYaIMt/VvgHJK2rJ7EpD00mCg9Wi6x7sh9tdToQx4zWErxu1FBYU+ryC1P6zB1C+n2lMccs2bV5Wi rjlsA1pqHoe52d6UuZSYrmql5uhRCpjDtfim6tZS3SQAUdw5rdevkoQM1Eodw9ZCknmqvg2gk51bJ B9YYRxLLSYRUGzutOHQ0DHCGD/9ZX0Iq2jQXStFMIJ+zNyTltzljTxhc1cC2Ut5EabB5wLEGmtbUa xNhTUNNrphFBevJBD5Hg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOiOX-0003lF-Uu; Wed, 15 Apr 2020 13:48:01 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOiOV-0003ke-QX for linux-arm-kernel@lists.infradead.org; Wed, 15 Apr 2020 13:48:01 +0000 Received: by mail-ed1-f65.google.com with SMTP id f12so1135253edn.12 for ; Wed, 15 Apr 2020 06:47:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mIOZ/sd96Rx46ThWOAXmWIaAK4iqfwYtds7TxEtsnA0=; b=nbzXFtru2KnO3zoqWa1k0MXZuIfOkWy89ur2i4+waDYoMP4llK9mnjjO/fDiN6PMFo 1Rn2omaopnzlE4AUQaLYUERggBA21YhKUsdfhnzUnAaRhsHvWprlmtN3kuf/J/cwwwAp v5LPhtbX64wOc5aTJcjHGAfipfMZIbiIUwSytZRlsvW/ea9ZVUnmfHM0twy1f0PF8LmV FOEOLvp2s4TOX1m938VDeDnuAVPwsWHrd0RCqFfLh976Xsl2op/6hct3rmcLpU2fHaA9 TZc1er8D+dEmLiEMPlH1n5tnGzR4nKJqosp8tQqz2kBSkp2qn3cJfcf+wN/SuIyz6hSL YbgA== X-Gm-Message-State: AGi0PubQophQ7tPXNlwgb27AAKRvjs4HTJZCdEMOA0sRF7MTdLsgp7er ykIuVu/n/g0qv/Sdo3jAkDo= X-Google-Smtp-Source: APiQypL993rtIwMeMfH5wHZyMs+H8Y65XYCjw99y7Fo0rlwZe8pf8YowOuo4m22Vp9YytQslngDtFA== X-Received: by 2002:aa7:c2c3:: with SMTP id m3mr18170324edp.10.1586958478322; Wed, 15 Apr 2020 06:47:58 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id gf12sm2524950ejb.62.2020.04.15.06.47.56 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Apr 2020 06:47:57 -0700 (PDT) Date: Wed, 15 Apr 2020 15:47:54 +0200 From: Krzysztof Kozlowski To: "H. Nikolaus Schaller" Subject: Re: [PATCH v6 07/12] ARM: DTS: omap5: add sgx gpu child node Message-ID: <20200415134754.GB21120@kozik-lap> References: <004611c9660943759b635a87484932869927cf74.1586939718.git.hns@goldelico.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200415_064759_859384_669392EC X-CRM114-Status: GOOD ( 16.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Airlie , James Hogan , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Paul Cercueil , "linux-samsung-soc@vger.kernel.org" , linux-omap@vger.kernel.org, Paul Burton , Tony Lindgren , Chen-Yu Tsai , Kukjin Kim , devicetree@vger.kernel.org, =?utf-8?Q?Beno=C3=AEt?= Cousson , Maxime Ripard , Rob Herring , letux-kernel@openphoenux.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Philipp Rossak , openpvrsgx-devgroup@letux.org, "linux-kernel@vger.kernel.org" , Ralf Baechle , Daniel Vetter , kernel@pyra-handheld.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 15, 2020 at 01:46:06PM +0200, H. Nikolaus Schaller wrote: > Hi Krzysztof, > > > Am 15.04.2020 um 13:38 schrieb Krzysztof Kozlowski : > > > > On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller wrote: > >> > >> and add interrupt. > >> > >> Tested-by: H. Nikolaus Schaller # Pyra-Handheld. > > > > Don't add your own Tested-by tags. These are implied by authorship, > > otherwise all patches people make should have such tag. > > Ok I see. AFAIR it originates in several phases of editing to report on which device it was tested. > > Is there a canonical way of writing "tested-on: ${HARDWARE}"? > > E.g. would this be ok? > > Signed-off: H. Nikolaus Schaller # tested on Pyra-Handheld If you think tested platform is worth mentioning in the commit msg (it will stay there forever, ever, ever) then just add a line like: "Add SGX GPU node. Tested on Pyra-Handheld." >From time to time we add such information to note that only one platform was actually tested. I am not sure what benefit it brings to most cases... but your commit msg is so short that adding one more sentence seems reasonable. :) Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DD04C2BA19 for ; Wed, 15 Apr 2020 13:48:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B33D2076D for ; Wed, 15 Apr 2020 13:48:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B33D2076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F7AB6E591; Wed, 15 Apr 2020 13:48:00 +0000 (UTC) Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id A07A36E591 for ; Wed, 15 Apr 2020 13:47:59 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id e5so4891600edq.5 for ; Wed, 15 Apr 2020 06:47:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mIOZ/sd96Rx46ThWOAXmWIaAK4iqfwYtds7TxEtsnA0=; b=GICxzsJunNjHqcI/36BYIBi1/ccEJhg1uNBamWHYeNaVUPtYinI7HrBKF0sCwrkz8H /fTM/5r/D4QCEe4FbMkS6cmykxoWkg1rh/w8ECktcu/e2Xq61NbY8sEhV+v91fhiISU+ 3MJgcf2p86FBFPO8pYKMaQeY6BdslLS1IzWuwkqP3Sj/0kCVa9bunJdVd5hH3+gSUQFl E26+Jwjskm613NJuZJDkEa3IHz7ZPxSxBu7fjU4XQ6NsLiGBOzkyzAKDpnmdrVUEVy3f xDmGptmRQhy2s0z9Un8+Su2mXPmaKyxw39rZt0yE7ZJ2WzRv6aBZTK846LkmIwJTH13z Q8uw== X-Gm-Message-State: AGi0PuaIaTnIbzvvR0ZskylRagKQz5nLARBZbyZcQk69TpntYsHlkWtt 0tTA5K9QI5pBH4IcZSrpfD8= X-Google-Smtp-Source: APiQypL993rtIwMeMfH5wHZyMs+H8Y65XYCjw99y7Fo0rlwZe8pf8YowOuo4m22Vp9YytQslngDtFA== X-Received: by 2002:aa7:c2c3:: with SMTP id m3mr18170324edp.10.1586958478322; Wed, 15 Apr 2020 06:47:58 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id gf12sm2524950ejb.62.2020.04.15.06.47.56 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Apr 2020 06:47:57 -0700 (PDT) Date: Wed, 15 Apr 2020 15:47:54 +0200 From: Krzysztof Kozlowski To: "H. Nikolaus Schaller" Subject: Re: [PATCH v6 07/12] ARM: DTS: omap5: add sgx gpu child node Message-ID: <20200415134754.GB21120@kozik-lap> References: <004611c9660943759b635a87484932869927cf74.1586939718.git.hns@goldelico.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Airlie , James Hogan , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Paul Cercueil , "linux-samsung-soc@vger.kernel.org" , linux-omap@vger.kernel.org, Paul Burton , Tony Lindgren , Chen-Yu Tsai , Kukjin Kim , devicetree@vger.kernel.org, =?utf-8?Q?Beno=C3=AEt?= Cousson , Rob Herring , letux-kernel@openphoenux.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Philipp Rossak , openpvrsgx-devgroup@letux.org, "linux-kernel@vger.kernel.org" , Ralf Baechle , kernel@pyra-handheld.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Apr 15, 2020 at 01:46:06PM +0200, H. Nikolaus Schaller wrote: > Hi Krzysztof, > > > Am 15.04.2020 um 13:38 schrieb Krzysztof Kozlowski : > > > > On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller wrote: > >> > >> and add interrupt. > >> > >> Tested-by: H. Nikolaus Schaller # Pyra-Handheld. > > > > Don't add your own Tested-by tags. These are implied by authorship, > > otherwise all patches people make should have such tag. > > Ok I see. AFAIR it originates in several phases of editing to report on which device it was tested. > > Is there a canonical way of writing "tested-on: ${HARDWARE}"? > > E.g. would this be ok? > > Signed-off: H. Nikolaus Schaller # tested on Pyra-Handheld If you think tested platform is worth mentioning in the commit msg (it will stay there forever, ever, ever) then just add a line like: "Add SGX GPU node. Tested on Pyra-Handheld." >From time to time we add such information to note that only one platform was actually tested. I am not sure what benefit it brings to most cases... but your commit msg is so short that adding one more sentence seems reasonable. :) Best regards, Krzysztof _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel