From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AA8EC2BA2B for ; Wed, 15 Apr 2020 20:33:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1755320857 for ; Wed, 15 Apr 2020 20:33:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="GQiAUrd7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S371269AbgDOUdN (ORCPT ); Wed, 15 Apr 2020 16:33:13 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:38086 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S371264AbgDOUdM (ORCPT ); Wed, 15 Apr 2020 16:33:12 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4BCC8DD3; Wed, 15 Apr 2020 22:33:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1586982789; bh=ZWrQLQiITcnJHS7w+LOALjXfWMs5iz+rT8aFRxucxtw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GQiAUrd7WJjvq8jNIeeljZaHhBNFa/QhJS4yGJW5WND2eu3EUuqC3ud3FcqdxopQf XSO0UCi7+yJP0gda51b3GJ5gC4HhTREnnvjaC0aBVqfHLALAzWwxAUjKVIJuL19Bua VngkH6/jze8rIhCrN/ha0VSue9EADOCMji40G+to= Date: Wed, 15 Apr 2020 23:32:56 +0300 From: Laurent Pinchart To: Stephen Boyd Cc: Douglas Anderson , a.hajda@samsung.com, airlied@linux.ie, daniel@ffwll.ch, narmstrong@baylibre.com, robh+dt@kernel.org, spanda@codeaurora.org, jonas@kwiboo.se, bjorn.andersson@linaro.org, devicetree@vger.kernel.org, jeffrey.l.hugo@gmail.com, jernej.skrabec@siol.net, linux-arm-msm@vger.kernel.org, robdclark@chromium.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: drm/bridge: ti-sn65dsi86: Add hpd-gpios to the bindings Message-ID: <20200415203256.GP4758@pendragon.ideasonboard.com> References: <20200415084758.1.Ifcdc4ecb12742a27862744ee1e8753cb95a38a7f@changeid> <20200415084758.2.Ic98f6622c60a1aa547ed85781f2c3b9d3e56b734@changeid> <158698038289.105027.2860892334897893887@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <158698038289.105027.2860892334897893887@swboyd.mtv.corp.google.com> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Apr 15, 2020 at 12:53:02PM -0700, Stephen Boyd wrote: > Quoting Douglas Anderson (2020-04-15 08:48:40) > > Allow people to specify to use a GPIO for hot-plug-detect. Add an > > example. > > > > NOTE: The current patch adding support for hpd-gpios to the Linux > > driver for hpd-gpios only adds enough support to the driver so that > > the bridge can use one of its own GPIOs. The bindings, however, are > > written generically. > > > > Signed-off-by: Douglas Anderson > > --- > > > > .../bindings/display/bridge/ti,sn65dsi86.yaml | 10 +++++++++- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml > > index 8cacc6db33a9..554bfd003000 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml > > @@ -60,6 +60,10 @@ properties: > > const: 1 > > description: See ../../pwm/pwm.yaml for description of the cell formats. > > > > + hpd-gpios: > > + maxItems: 1 > > + description: If present use the given GPIO for hot-plug-detect. > > Shouldn't this go in the panel node? And the panel driver should get the > gpio and poll it after powering up the panel? Presumably that's why we > have the no-hpd property in the simple panel binding vs. putting it here > in the bridge. Same question really, I think this belongs to the panel (or connector) node indeed. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23C95C2BA2B for ; Wed, 15 Apr 2020 20:33:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECC0120774 for ; Wed, 15 Apr 2020 20:33:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="GQiAUrd7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECC0120774 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 68F7D6EA65; Wed, 15 Apr 2020 20:33:12 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id AAA746EA65 for ; Wed, 15 Apr 2020 20:33:11 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4BCC8DD3; Wed, 15 Apr 2020 22:33:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1586982789; bh=ZWrQLQiITcnJHS7w+LOALjXfWMs5iz+rT8aFRxucxtw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GQiAUrd7WJjvq8jNIeeljZaHhBNFa/QhJS4yGJW5WND2eu3EUuqC3ud3FcqdxopQf XSO0UCi7+yJP0gda51b3GJ5gC4HhTREnnvjaC0aBVqfHLALAzWwxAUjKVIJuL19Bua VngkH6/jze8rIhCrN/ha0VSue9EADOCMji40G+to= Date: Wed, 15 Apr 2020 23:32:56 +0300 From: Laurent Pinchart To: Stephen Boyd Subject: Re: [PATCH 2/3] dt-bindings: drm/bridge: ti-sn65dsi86: Add hpd-gpios to the bindings Message-ID: <20200415203256.GP4758@pendragon.ideasonboard.com> References: <20200415084758.1.Ifcdc4ecb12742a27862744ee1e8753cb95a38a7f@changeid> <20200415084758.2.Ic98f6622c60a1aa547ed85781f2c3b9d3e56b734@changeid> <158698038289.105027.2860892334897893887@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <158698038289.105027.2860892334897893887@swboyd.mtv.corp.google.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, devicetree@vger.kernel.org, jernej.skrabec@siol.net, narmstrong@baylibre.com, airlied@linux.ie, linux-arm-msm@vger.kernel.org, jonas@kwiboo.se, jeffrey.l.hugo@gmail.com, Douglas Anderson , dri-devel@lists.freedesktop.org, spanda@codeaurora.org, a.hajda@samsung.com, robh+dt@kernel.org, bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Apr 15, 2020 at 12:53:02PM -0700, Stephen Boyd wrote: > Quoting Douglas Anderson (2020-04-15 08:48:40) > > Allow people to specify to use a GPIO for hot-plug-detect. Add an > > example. > > > > NOTE: The current patch adding support for hpd-gpios to the Linux > > driver for hpd-gpios only adds enough support to the driver so that > > the bridge can use one of its own GPIOs. The bindings, however, are > > written generically. > > > > Signed-off-by: Douglas Anderson > > --- > > > > .../bindings/display/bridge/ti,sn65dsi86.yaml | 10 +++++++++- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml > > index 8cacc6db33a9..554bfd003000 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml > > @@ -60,6 +60,10 @@ properties: > > const: 1 > > description: See ../../pwm/pwm.yaml for description of the cell formats. > > > > + hpd-gpios: > > + maxItems: 1 > > + description: If present use the given GPIO for hot-plug-detect. > > Shouldn't this go in the panel node? And the panel driver should get the > gpio and poll it after powering up the panel? Presumably that's why we > have the no-hpd property in the simple panel binding vs. putting it here > in the bridge. Same question really, I think this belongs to the panel (or connector) node indeed. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel