From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH mptcp 4/7] mptcp: avoid callback invocation when mptcp parent socket doesn't exist
Date: Wed, 15 Apr 2020 22:49:51 +0200 [thread overview]
Message-ID: <20200415204951.GA32392@breakpoint.cc> (raw)
In-Reply-To: 4a58f8fa3a140be8b09bf6ee0605a5dcc4492858.camel@redhat.com
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
Paolo Abeni <pabeni(a)redhat.com> wrote:
> On Wed, 2020-04-15 at 19:19 +0200, Florian Westphal wrote:
> > We can crash with a NULL dereference in case a packet arrives on the new
> > socket before ctx->conn has been initialized.
>
> I don't understand this race. I thought tcp_v4_syn_recv_sock() creates
> the new socket and acquires the socket lock atomically, and ctx->conn =
> new_msk happens in the same critical section ?!?
>
> So no packets should reach the newly created socket while conn is NULL
> !?!
Might be related to the last patch, i.e. this patch is bogus because the
NULL was because of lack of is_mptcp = 0 assignment?
I will test again with this patch removed from the series.
sorry.
next reply other threads:[~2020-04-15 20:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 20:49 Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-16 9:57 [MPTCP] Re: [PATCH mptcp 4/7] mptcp: avoid callback invocation when mptcp parent socket doesn't exist Florian Westphal
2020-04-15 17:41 Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415204951.GA32392@breakpoint.cc \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.