All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: bob.liu@oracle.com, damien.lemoal@wdc.com, snitzer@redhat.com,
	stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] dm zoned: remove duplicate nr_rnd_zones increase in" failed to apply to 5.4-stable tree
Date: Wed, 15 Apr 2020 20:51:48 -0400	[thread overview]
Message-ID: <20200416005148.GO1068@sasha-vm> (raw)
In-Reply-To: <15869485594525@kroah.com>

On Wed, Apr 15, 2020 at 01:02:39PM +0200, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.4-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From b8fdd090376a7a46d17db316638fe54b965c2fb0 Mon Sep 17 00:00:00 2001
>From: Bob Liu <bob.liu@oracle.com>
>Date: Tue, 24 Mar 2020 21:22:45 +0800
>Subject: [PATCH] dm zoned: remove duplicate nr_rnd_zones increase in
> dmz_init_zone()
>
>zmd->nr_rnd_zones was increased twice by mistake. The other place it
>is increased in dmz_init_zone() is the only one needed:
>
>1131                 zmd->nr_useable_zones++;
>1132                 if (dmz_is_rnd(zone)) {
>1133                         zmd->nr_rnd_zones++;
>					^^^
>Fixes: 3b1a94c88b79 ("dm zoned: drive-managed zoned block device target")
>Cc: stable@vger.kernel.org
>Signed-off-by: Bob Liu <bob.liu@oracle.com>
>Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
>Signed-off-by: Mike Snitzer <snitzer@redhat.com>
>
>diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
>index 516c7b671d25..369de15c4e80 100644
>--- a/drivers/md/dm-zoned-metadata.c
>+++ b/drivers/md/dm-zoned-metadata.c
>@@ -1109,7 +1109,6 @@ static int dmz_init_zone(struct blk_zone *blkz, unsigned int idx, void *data)
> 	switch (blkz->type) {
> 	case BLK_ZONE_TYPE_CONVENTIONAL:
> 		set_bit(DMZ_RND, &zone->flags);
>-		zmd->nr_rnd_zones++;
> 		break;
> 	case BLK_ZONE_TYPE_SEQWRITE_REQ:
> 	case BLK_ZONE_TYPE_SEQWRITE_PREF:

The code on older kernels was using is/else construct instead of a
switch. I've adjusted the patch and queued it up.

-- 
Thanks,
Sasha

  reply	other threads:[~2020-04-16  0:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15 11:02 FAILED: patch "[PATCH] dm zoned: remove duplicate nr_rnd_zones increase in" failed to apply to 5.4-stable tree gregkh
2020-04-16  0:51 ` Sasha Levin [this message]
2020-04-16  1:18   ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200416005148.GO1068@sasha-vm \
    --to=sashal@kernel.org \
    --cc=bob.liu@oracle.com \
    --cc=damien.lemoal@wdc.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=snitzer@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.