All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Vasil Dimov via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Vasil Dimov <vd@freebsd.org>
Subject: Re: [PATCH v2 0/2] range-diff: fix a crash in parsing git-log output
Date: Wed, 15 Apr 2020 19:07:34 -0600	[thread overview]
Message-ID: <20200416010734.GE36156@syl.local> (raw)
In-Reply-To: <pull.760.v2.git.git.1586982745.gitgitgadget@gmail.com>

Hi Vasil,

Thanks for sending a v2. This all looks good to me.

On Wed, Apr 15, 2020 at 08:32:23PM +0000, Vasil Dimov via GitGitGadget wrote:
>  * override a possibly user-customized format.pretty that would render git
>    log output unparsable by git range-diff
>
>
>  * don't use negative string precision, e.g. "%.*s", -5, "foo"
>
>
>
> Changes since v1:
>
>  * Fixed a typo in the commit message (found by Taylor Blau)
>
> Vasil Dimov (2):
>   range-diff: fix a crash in parsing git-log output
>   range-diff: avoid negative string precision
>
>  range-diff.c          | 18 +++++++++++++++++-
>  t/t3206-range-diff.sh | 10 ++++++++++
>  2 files changed, 27 insertions(+), 1 deletion(-)
>
> [snip]
> --
> gitgitgadget

  Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks,
Taylor

      parent reply	other threads:[~2020-04-16  1:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15 14:28 [PATCH 0/2] range-diff: fix a crash in parsing git-log output Vasil Dimov via GitGitGadget
2020-04-15 14:28 ` [PATCH 1/2] " Vasil Dimov via GitGitGadget
2020-04-15 15:31   ` Junio C Hamano
2020-04-15 16:16     ` Vasil Dimov
2020-04-15 16:23     ` Jeff King
2020-04-15 22:02       ` Taylor Blau
2020-04-15 22:29         ` Jeff King
2020-04-15 16:13   ` Taylor Blau
2020-04-15 14:28 ` [PATCH 2/2] range-diff: avoid negative string precision Vasil Dimov via GitGitGadget
2020-04-15 16:20   ` Taylor Blau
2020-04-15 20:19     ` Vasil Dimov
2020-04-15 20:32 ` [PATCH v2 0/2] range-diff: fix a crash in parsing git-log output Vasil Dimov via GitGitGadget
2020-04-15 20:32   ` [PATCH v2 1/2] " Vasil Dimov via GitGitGadget
2020-04-15 20:32   ` [PATCH v2 2/2] range-diff: avoid negative string precision Vasil Dimov via GitGitGadget
2020-04-16  1:07   ` Taylor Blau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200416010734.GE36156@syl.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=vd@freebsd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.