From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: wenyang@linux.alibaba.com, arnd@arndb.de, cminyard@mvista.com,
minyard@acm.org, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] ipmi: fix hung processes in __get_guid()" failed to apply to 4.14-stable tree
Date: Wed, 15 Apr 2020 23:14:53 -0400 [thread overview]
Message-ID: <20200416031453.GE1068@sasha-vm> (raw)
In-Reply-To: <15869513487994@kroah.com>
On Wed, Apr 15, 2020 at 01:49:08PM +0200, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.14-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From 32830a0534700f86366f371b150b17f0f0d140d7 Mon Sep 17 00:00:00 2001
>From: Wen Yang <wenyang@linux.alibaba.com>
>Date: Fri, 3 Apr 2020 17:04:08 +0800
>Subject: [PATCH] ipmi: fix hung processes in __get_guid()
>
>The wait_event() function is used to detect command completion.
>When send_guid_cmd() returns an error, smi_send() has not been
>called to send data. Therefore, wait_event() should not be used
>on the error path, otherwise it will cause the following warning:
>
>[ 1361.588808] systemd-udevd D 0 1501 1436 0x00000004
>[ 1361.588813] ffff883f4b1298c0 0000000000000000 ffff883f4b188000 ffff887f7e3d9f40
>[ 1361.677952] ffff887f64bd4280 ffffc90037297a68 ffffffff8173ca3b ffffc90000000010
>[ 1361.767077] 00ffc90037297ad0 ffff887f7e3d9f40 0000000000000286 ffff883f4b188000
>[ 1361.856199] Call Trace:
>[ 1361.885578] [<ffffffff8173ca3b>] ? __schedule+0x23b/0x780
>[ 1361.951406] [<ffffffff8173cfb6>] schedule+0x36/0x80
>[ 1362.010979] [<ffffffffa071f178>] get_guid+0x118/0x150 [ipmi_msghandler]
>[ 1362.091281] [<ffffffff810d5350>] ? prepare_to_wait_event+0x100/0x100
>[ 1362.168533] [<ffffffffa071f755>] ipmi_register_smi+0x405/0x940 [ipmi_msghandler]
>[ 1362.258337] [<ffffffffa0230ae9>] try_smi_init+0x529/0x950 [ipmi_si]
>[ 1362.334521] [<ffffffffa022f350>] ? std_irq_setup+0xd0/0xd0 [ipmi_si]
>[ 1362.411701] [<ffffffffa0232bd2>] init_ipmi_si+0x492/0x9e0 [ipmi_si]
>[ 1362.487917] [<ffffffffa0232740>] ? ipmi_pci_probe+0x280/0x280 [ipmi_si]
>[ 1362.568219] [<ffffffff810021a0>] do_one_initcall+0x50/0x180
>[ 1362.636109] [<ffffffff812231b2>] ? kmem_cache_alloc_trace+0x142/0x190
>[ 1362.714330] [<ffffffff811b2ae1>] do_init_module+0x5f/0x200
>[ 1362.781208] [<ffffffff81123ca8>] load_module+0x1898/0x1de0
>[ 1362.848069] [<ffffffff811202e0>] ? __symbol_put+0x60/0x60
>[ 1362.913886] [<ffffffff8130696b>] ? security_kernel_post_read_file+0x6b/0x80
>[ 1362.998514] [<ffffffff81124465>] SYSC_finit_module+0xe5/0x120
>[ 1363.068463] [<ffffffff81124465>] ? SYSC_finit_module+0xe5/0x120
>[ 1363.140513] [<ffffffff811244be>] SyS_finit_module+0xe/0x10
>[ 1363.207364] [<ffffffff81003c04>] do_syscall_64+0x74/0x180
>
>Fixes: 50c812b2b951 ("[PATCH] ipmi: add full sysfs support")
>Signed-off-by: Wen Yang <wenyang@linux.alibaba.com>
>Cc: Corey Minyard <minyard@acm.org>
>Cc: Arnd Bergmann <arnd@arndb.de>
>Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>Cc: openipmi-developer@lists.sourceforge.net
>Cc: linux-kernel@vger.kernel.org
>Cc: stable@vger.kernel.org # 2.6.17-
>Message-Id: <20200403090408.58745-1-wenyang@linux.alibaba.com>
>Signed-off-by: Corey Minyard <cminyard@mvista.com>
Conflict because we're missing:
28f26ac7a963 ("ipmi: Dynamically fetch GUID periodically")
aa9c9ab2443e ("ipmi: allow dynamic BMC version information")
Fixed and queued up.
--
Thanks,
Sasha
prev parent reply other threads:[~2020-04-16 3:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 11:49 FAILED: patch "[PATCH] ipmi: fix hung processes in __get_guid()" failed to apply to 4.14-stable tree gregkh
2020-04-16 3:14 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416031453.GE1068@sasha-vm \
--to=sashal@kernel.org \
--cc=arnd@arndb.de \
--cc=cminyard@mvista.com \
--cc=gregkh@linuxfoundation.org \
--cc=minyard@acm.org \
--cc=stable@vger.kernel.org \
--cc=wenyang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.