All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sasha Levin <sashal@kernel.org>
Cc: josef@toxicpanda.com, dsterba@suse.com,
	johannes.thumshirn@wdc.com, nborisov@suse.com, wqu@suse.com,
	stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] btrfs: handle logged extent failure properly" failed to apply to 5.6-stable tree
Date: Thu, 16 Apr 2020 09:07:20 +0200	[thread overview]
Message-ID: <20200416070720.GC372946@kroah.com> (raw)
In-Reply-To: <20200416004154.GN1068@sasha-vm>

On Wed, Apr 15, 2020 at 08:41:54PM -0400, Sasha Levin wrote:
> On Tue, Apr 14, 2020 at 04:21:45PM +0200, gregkh@linuxfoundation.org wrote:
> > 
> > The patch below does not apply to the 5.6-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@vger.kernel.org>.
> > 
> > thanks,
> > 
> > greg k-h
> > 
> > ------------------ original commit in Linus's tree ------------------
> > 
> > > From ab9b2c7b32e6be53cac2e23f5b2db66815a7d972 Mon Sep 17 00:00:00 2001
> > From: Josef Bacik <josef@toxicpanda.com>
> > Date: Thu, 13 Feb 2020 10:47:30 -0500
> > Subject: [PATCH] btrfs: handle logged extent failure properly
> > 
> > If we're allocating a logged extent we attempt to insert an extent
> > record for the file extent directly.  We increase
> > space_info->bytes_reserved, because the extent entry addition will call
> > btrfs_update_block_group(), which will convert the ->bytes_reserved to
> > ->bytes_used.  However if we fail at any point while inserting the
> > extent entry we will bail and leave space on ->bytes_reserved, which
> > will trigger a WARN_ON() on umount.  Fix this by pinning the space if we
> > fail to insert, which is what happens in every other failure case that
> > involves adding the extent entry.
> > 
> > CC: stable@vger.kernel.org # 5.4+
> > Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> > Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> > Reviewed-by: Qu Wenruo <wqu@suse.com>
> > Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> > Reviewed-by: David Sterba <dsterba@suse.com>
> > Signed-off-by: David Sterba <dsterba@suse.com>
> 
> Greg, I've noticed that you've fixed it up for 5.5 and 5.4 but no for
> 5.6? I've queued it up for 5.6 as well.

I didn't include this in 5.5 or 5.4, so please queue it up in those two
trees as well.

thanks,

greg k-h

  reply	other threads:[~2020-04-16  7:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14 14:21 FAILED: patch "[PATCH] btrfs: handle logged extent failure properly" failed to apply to 5.6-stable tree gregkh
2020-04-16  0:41 ` Sasha Levin
2020-04-16  7:07   ` Greg KH [this message]
2020-04-16 13:05     ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200416070720.GC372946@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dsterba@suse.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=josef@toxicpanda.com \
    --cc=nborisov@suse.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.