From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7FCDC2BB85 for ; Thu, 16 Apr 2020 08:48:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A521020784 for ; Thu, 16 Apr 2020 08:48:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Rd8PNO7a"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qMyY08os" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A521020784 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KkscsrcXkURYcFhx7ENHAhwrnJVdUNPz/EVqX3yAy+U=; b=Rd8PNO7a2A0WTu GtQgAeJsc81ZzssEZFcV4/xjWHe6JrfpO1xvZoP+UIh+7IQWc19tYvsvRG2+zTu69mgxNFt2TSnMm oSfUNtCOPjk4QKMz5FnfoofZ023r1usG2++ehrGhGeG8H0qxxumiFjR7HdvtOiJS4L2r92ohD35Gf oJ4tBo5WQoV5Hrv/vXwuFGNEReE7CfpAGs2T/9SuaLWUfbTnsRChnYqX/lihMU6iPf4/enonBDwF8 JiuFjK/G1tj9Zu75K50qNJM1PItuFTbRpKugktsT3/g7beSUhfhwG8kFa2ar88O6fQokyi3LAVOz6 YbeX10tAVUdF4m0NLtYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP0C8-0007uf-NH; Thu, 16 Apr 2020 08:48:24 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP0Bw-0007jB-Qr for linux-mediatek@lists.infradead.org; Thu, 16 Apr 2020 08:48:14 +0000 Received: by mail-wr1-x443.google.com with SMTP id f13so3780056wrm.13 for ; Thu, 16 Apr 2020 01:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=gCC6rxpfNBHEEJoswTl2+v3GlY13e+wv1Apu4C5uUJ0=; b=qMyY08os0xXarDJEQ8j9nJU1G/4i1ajvSN1547JGWNAU4kptYy+l0ETyItzmwelvLC nCDep5Cl1t95mbiIhlCDcowJNJGFakofRU/UeiPQv049DorrDQDyvOhQ0iXlohLp8hin 3bAdw+39EFnaQiFiejH+534QfsSXNhMyYx4ZtJs1O8APzJpuT9KiZORIU2xx8m9me3GJ nRCzeSz6fhZnRuGUV65gJOj0k8DMrASVs1ffDMfO5wQ+4MKhMzyo1Hf7xWdNJii/ENzy uOrTcZOmWLeo1D6phvtKajqfSbjF0JkyzG19tN5chV4GtOZYui9witk4RNmc7L0KIuBW GEOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=gCC6rxpfNBHEEJoswTl2+v3GlY13e+wv1Apu4C5uUJ0=; b=gTGDABdK6NxFJ9/IWMzWZtwkaP7sTD14yf5/HMQLJ5ZM7j+9yxdPf4bdpKe5YB6h4M qY5leGWNdQDQKIgBtCjklXnOsFdyVvPS39DKI/ssd458hKTD8Sq2MWBbg1fGYQMkQ/9H Fav+yAASo/oAoOIt9Fu6/tC3CKvYmds+4YgE5eV0VhM6iUEDQYJRP7T3nosnP4JkMl9h lk60FcGXJtfiZltoGs9/s2bVMVXKtH/IRH0WeUcxpYjxB8tPPMNyfgRJdfpqXGE2fi3+ Jbb6JBtuLxcw18MOFyWt4mNf0MRM6F8X0GhH8OPcOxgcs57phTVDmf5qHZ3bEx8Pq2Y+ 8Vkg== X-Gm-Message-State: AGi0PuYOgLVuWp9Bwtq4IpY8JG+hJ50hYNTWaiM6n0u/wp/eGNZ4/ixS ZY3tVSRVCDUfEshrSJ7JPLvbmw== X-Google-Smtp-Source: APiQypLyhDVW4E+VOlBHWErivAdlGrtxixDqwonOAkbRNQamJnKVsV0vJKLtvSLryabLtX0HhH0tLg== X-Received: by 2002:a5d:4286:: with SMTP id k6mr21252278wrq.222.1587026890846; Thu, 16 Apr 2020 01:48:10 -0700 (PDT) Received: from dell ([95.149.164.124]) by smtp.gmail.com with ESMTPSA id z15sm14429845wrs.47.2020.04.16.01.48.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2020 01:48:10 -0700 (PDT) Date: Thu, 16 Apr 2020 09:49:10 +0100 From: Lee Jones To: Hsin-Hsiung Wang Subject: Re: [PATCH v12 1/6] mfd: mt6397: Modify suspend/resume behavior Message-ID: <20200416084910.GX2167633@dell> References: <1586333531-21641-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1586333531-21641-2-git-send-email-hsin-hsiung.wang@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1586333531-21641-2-git-send-email-hsin-hsiung.wang@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200416_014812_864612_B0E4F049 X-CRM114-Status: GOOD ( 15.22 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kate Stewart , Alexandre Belloni , linux-kernel@vger.kernel.org, Richard Fontana , linux-rtc@vger.kernel.org, Nicolas Boichat , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, Frank Wunderlich , Ran Bi , Sean Wang , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Thomas Gleixner , Eddie Huang , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , Josef Friedl , srv_heupstream@mediatek.com, Sebastian Reichel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gV2VkLCAwOCBBcHIgMjAyMCwgSHNpbi1Ic2l1bmcgV2FuZyB3cm90ZToKCj4gU29tZSBwbWlj cyBkb24ndCBuZWVkIGJhY2t1cCBpbnRlcnJ1cHQgc2V0dGluZ3MsIHNvIHdlIGNoYW5nZSB0byB1 c2UKPiBwbSBub3RpZmllciBmb3IgdGhlIHBtaWNzIHdoaWNoIGFyZSBuZWNlc3NhcnkgdG8gc3Rv cmUgc2V0dGluZ3MuCj4gCj4gU2lnbmVkLW9mZi1ieTogSHNpbi1Ic2l1bmcgV2FuZyA8aHNpbi1o c2l1bmcud2FuZ0BtZWRpYXRlay5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvbWZkL210NjM5Ny1jb3Jl LmMgICAgICAgfCAzMCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9t ZmQvbXQ2Mzk3LWlycS5jICAgICAgICB8IDM1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKystCj4gIGluY2x1ZGUvbGludXgvbWZkL210NjM5Ny9jb3JlLmggfCAgMiArKwo+ICAzIGZp bGVzIGNoYW5nZWQsIDM2IGluc2VydGlvbnMoKyksIDMxIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL21mZC9tdDYzOTctY29yZS5jIGIvZHJpdmVycy9tZmQvbXQ2Mzk3LWNv cmUuYwo+IGluZGV4IDA0MzdjODUuLmQyZTcwZDggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9tZmQv bXQ2Mzk3LWNvcmUuYwo+ICsrKyBiL2RyaXZlcnMvbWZkL210NjM5Ny1jb3JlLmMKPiBAQCAtMTAw LDM1ICsxMDAsNiBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IG1mZF9jZWxsIG10NjM5N19kZXZzW10g PSB7Cj4gIAl9Cj4gIH07Cj4gIAo+IC0jaWZkZWYgQ09ORklHX1BNX1NMRUVQCj4gLXN0YXRpYyBp bnQgbXQ2Mzk3X2lycV9zdXNwZW5kKHN0cnVjdCBkZXZpY2UgKmRldikKPiAtewo+IC0Jc3RydWN0 IG10NjM5N19jaGlwICpjaGlwID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gLQo+IC0JcmVnbWFw X3dyaXRlKGNoaXAtPnJlZ21hcCwgY2hpcC0+aW50X2NvblswXSwgY2hpcC0+d2FrZV9tYXNrWzBd KTsKPiAtCXJlZ21hcF93cml0ZShjaGlwLT5yZWdtYXAsIGNoaXAtPmludF9jb25bMV0sIGNoaXAt Pndha2VfbWFza1sxXSk7Cj4gLQo+IC0JZW5hYmxlX2lycV93YWtlKGNoaXAtPmlycSk7Cj4gLQo+ IC0JcmV0dXJuIDA7Cj4gLX0KPiAtCj4gLXN0YXRpYyBpbnQgbXQ2Mzk3X2lycV9yZXN1bWUoc3Ry dWN0IGRldmljZSAqZGV2KQo+IC17Cj4gLQlzdHJ1Y3QgbXQ2Mzk3X2NoaXAgKmNoaXAgPSBkZXZf Z2V0X2RydmRhdGEoZGV2KTsKPiAtCj4gLQlyZWdtYXBfd3JpdGUoY2hpcC0+cmVnbWFwLCBjaGlw LT5pbnRfY29uWzBdLCBjaGlwLT5pcnFfbWFza3NfY3VyWzBdKTsKPiAtCXJlZ21hcF93cml0ZShj aGlwLT5yZWdtYXAsIGNoaXAtPmludF9jb25bMV0sIGNoaXAtPmlycV9tYXNrc19jdXJbMV0pOwo+ IC0KPiAtCWRpc2FibGVfaXJxX3dha2UoY2hpcC0+aXJxKTsKPiAtCj4gLQlyZXR1cm4gMDsKPiAt fQo+IC0jZW5kaWYKPiAtCj4gLXN0YXRpYyBTSU1QTEVfREVWX1BNX09QUyhtdDYzOTdfcG1fb3Bz LCBtdDYzOTdfaXJxX3N1c3BlbmQsCj4gLQkJCW10NjM5N19pcnFfcmVzdW1lKTsKPiAtCj4gIHN0 cnVjdCBjaGlwX2RhdGEgewo+ICAJdTMyIGNpZF9hZGRyOwo+ICAJdTMyIGNpZF9zaGlmdDsKPiBA QCAtMjM4LDcgKzIwOSw2IEBAIHN0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIG10NjM5N19k cml2ZXIgPSB7Cj4gIAkuZHJpdmVyID0gewo+ICAJCS5uYW1lID0gIm10NjM5NyIsCj4gIAkJLm9m X21hdGNoX3RhYmxlID0gb2ZfbWF0Y2hfcHRyKG10NjM5N19vZl9tYXRjaCksCj4gLQkJLnBtID0g Jm10NjM5N19wbV9vcHMsCj4gIAl9LAo+ICAJLmlkX3RhYmxlID0gbXQ2Mzk3X2lkLAo+ICB9Owo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC9tdDYzOTctaXJxLmMgYi9kcml2ZXJzL21mZC9tdDYz OTctaXJxLmMKPiBpbmRleCBiMmQzY2UxLi4yOTI0OTE5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv bWZkL210NjM5Ny1pcnEuYwo+ICsrKyBiL2RyaXZlcnMvbWZkL210NjM5Ny1pcnEuYwo+IEBAIC05 LDYgKzksNyBAQAo+ICAjaW5jbHVkZSA8bGludXgvb2ZfaXJxLmg+Cj4gICNpbmNsdWRlIDxsaW51 eC9wbGF0Zm9ybV9kZXZpY2UuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3JlZ21hcC5oPgo+ICsjaW5j bHVkZSA8bGludXgvc3VzcGVuZC5oPgo+ICAjaW5jbHVkZSA8bGludXgvbWZkL210NjMyMy9jb3Jl Lmg+Cj4gICNpbmNsdWRlIDxsaW51eC9tZmQvbXQ2MzIzL3JlZ2lzdGVycy5oPgo+ICAjaW5jbHVk ZSA8bGludXgvbWZkL210NjM5Ny9jb3JlLmg+Cj4gQEAgLTgxLDcgKzgyLDcgQEAgc3RhdGljIHN0 cnVjdCBpcnFfY2hpcCBtdDYzOTdfaXJxX2NoaXAgPSB7Cj4gIHN0YXRpYyB2b2lkIG10NjM5N19p cnFfaGFuZGxlX3JlZyhzdHJ1Y3QgbXQ2Mzk3X2NoaXAgKm10NjM5NywgaW50IHJlZywKPiAgCQkJ CSAgaW50IGlycWJhc2UpCj4gIHsKPiAtCXVuc2lnbmVkIGludCBzdGF0dXM7Cj4gKwl1bnNpZ25l ZCBpbnQgc3RhdHVzID0gMDsKClRoaXMgbG9va3MgbGlrZSBhbiB1bnJlbGF0ZWQgY2hhbmdlLCBu bz8KCj4gIAlpbnQgaSwgaXJxLCByZXQ7Cj4gIAo+ICAJcmV0ID0gcmVnbWFwX3JlYWQobXQ2Mzk3 LT5yZWdtYXAsIHJlZywgJnN0YXR1cyk7Cj4gQEAgLTEyOCw2ICsxMjksMzYgQEAgc3RhdGljIGNv bnN0IHN0cnVjdCBpcnFfZG9tYWluX29wcyBtdDYzOTdfaXJxX2RvbWFpbl9vcHMgPSB7Cj4gIAku bWFwID0gbXQ2Mzk3X2lycV9kb21haW5fbWFwLAo+ICB9OwoKT3RoZXIgdGhhbiB0aGF0LgoKRm9y IG15IG93biByZWZlcmVuY2U6CiAgQWNrZWQtZm9yLU1GRC1ieTogTGVlIEpvbmVzIDxsZWUuam9u ZXNAbGluYXJvLm9yZz4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KTGluYXJvIFNlcnZpY2Vz IFRlY2huaWNhbCBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBB Uk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1tZWRpYXRlayBt YWlsaW5nIGxpc3QKTGludXgtbWVkaWF0ZWtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW1lZGlhdGVrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE983C352BE for ; Thu, 16 Apr 2020 09:02:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90BEA206B9 for ; Thu, 16 Apr 2020 09:02:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qMyY08os" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2503124AbgDPJCj (ORCPT ); Thu, 16 Apr 2020 05:02:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2502927AbgDPIsR (ORCPT ); Thu, 16 Apr 2020 04:48:17 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3255EC061A41 for ; Thu, 16 Apr 2020 01:48:12 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id u13so3862804wrp.3 for ; Thu, 16 Apr 2020 01:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=gCC6rxpfNBHEEJoswTl2+v3GlY13e+wv1Apu4C5uUJ0=; b=qMyY08os0xXarDJEQ8j9nJU1G/4i1ajvSN1547JGWNAU4kptYy+l0ETyItzmwelvLC nCDep5Cl1t95mbiIhlCDcowJNJGFakofRU/UeiPQv049DorrDQDyvOhQ0iXlohLp8hin 3bAdw+39EFnaQiFiejH+534QfsSXNhMyYx4ZtJs1O8APzJpuT9KiZORIU2xx8m9me3GJ nRCzeSz6fhZnRuGUV65gJOj0k8DMrASVs1ffDMfO5wQ+4MKhMzyo1Hf7xWdNJii/ENzy uOrTcZOmWLeo1D6phvtKajqfSbjF0JkyzG19tN5chV4GtOZYui9witk4RNmc7L0KIuBW GEOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=gCC6rxpfNBHEEJoswTl2+v3GlY13e+wv1Apu4C5uUJ0=; b=aUY1C1LMKgSB3HrjWLziiVSg7ltmRM4nsvEsTM0vbnffdeBEBi/eS14DYGz3XbVEJy sfWc/vm+d+F7exGYG04KtB1TAvUhXaK/Xz91l+lLoriJJrMldKcp0rFWW7d0i3sZpcFd VME6u6hfQUjMO4JBEtAKdh0FStPWkwaAA3Ux9/frEyhdpMRoeEhohEViTx4ys1jgqrD+ Xmba63h23ciwTbF6X8BDMhKCK3DXFK7bTCbR9NVy16Yf4+aDtMeH65HikkRIvrLpu+TB vU1iusaK/426+0acXxP0EYxZhEHdJlPjFa2lj8X3/nj4DJ2YOJRd0hLWR2vfxnKFVSTH qWeg== X-Gm-Message-State: AGi0PuYIs166MqObkGANwbWwprD57z+5sRQiJ9Xf2jCXvEV36eILlnYb 6UWgHJ4Uci5Y7phrla/3PfTv8Q== X-Google-Smtp-Source: APiQypLyhDVW4E+VOlBHWErivAdlGrtxixDqwonOAkbRNQamJnKVsV0vJKLtvSLryabLtX0HhH0tLg== X-Received: by 2002:a5d:4286:: with SMTP id k6mr21252278wrq.222.1587026890846; Thu, 16 Apr 2020 01:48:10 -0700 (PDT) Received: from dell ([95.149.164.124]) by smtp.gmail.com with ESMTPSA id z15sm14429845wrs.47.2020.04.16.01.48.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2020 01:48:10 -0700 (PDT) Date: Thu, 16 Apr 2020 09:49:10 +0100 From: Lee Jones To: Hsin-Hsiung Wang Cc: Rob Herring , Matthias Brugger , Alexandre Belloni , Nicolas Boichat , Mark Rutland , Sean Wang , Sebastian Reichel , Eddie Huang , Alessandro Zummo , Kate Stewart , Richard Fontana , Frank Wunderlich , Josef Friedl , Thomas Gleixner , Ran Bi , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, srv_heupstream@mediatek.com Subject: Re: [PATCH v12 1/6] mfd: mt6397: Modify suspend/resume behavior Message-ID: <20200416084910.GX2167633@dell> References: <1586333531-21641-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1586333531-21641-2-git-send-email-hsin-hsiung.wang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1586333531-21641-2-git-send-email-hsin-hsiung.wang@mediatek.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, 08 Apr 2020, Hsin-Hsiung Wang wrote: > Some pmics don't need backup interrupt settings, so we change to use > pm notifier for the pmics which are necessary to store settings. > > Signed-off-by: Hsin-Hsiung Wang > --- > drivers/mfd/mt6397-core.c | 30 ------------------------------ > drivers/mfd/mt6397-irq.c | 35 ++++++++++++++++++++++++++++++++++- > include/linux/mfd/mt6397/core.h | 2 ++ > 3 files changed, 36 insertions(+), 31 deletions(-) > > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c > index 0437c85..d2e70d8 100644 > --- a/drivers/mfd/mt6397-core.c > +++ b/drivers/mfd/mt6397-core.c > @@ -100,35 +100,6 @@ static const struct mfd_cell mt6397_devs[] = { > } > }; > > -#ifdef CONFIG_PM_SLEEP > -static int mt6397_irq_suspend(struct device *dev) > -{ > - struct mt6397_chip *chip = dev_get_drvdata(dev); > - > - regmap_write(chip->regmap, chip->int_con[0], chip->wake_mask[0]); > - regmap_write(chip->regmap, chip->int_con[1], chip->wake_mask[1]); > - > - enable_irq_wake(chip->irq); > - > - return 0; > -} > - > -static int mt6397_irq_resume(struct device *dev) > -{ > - struct mt6397_chip *chip = dev_get_drvdata(dev); > - > - regmap_write(chip->regmap, chip->int_con[0], chip->irq_masks_cur[0]); > - regmap_write(chip->regmap, chip->int_con[1], chip->irq_masks_cur[1]); > - > - disable_irq_wake(chip->irq); > - > - return 0; > -} > -#endif > - > -static SIMPLE_DEV_PM_OPS(mt6397_pm_ops, mt6397_irq_suspend, > - mt6397_irq_resume); > - > struct chip_data { > u32 cid_addr; > u32 cid_shift; > @@ -238,7 +209,6 @@ static struct platform_driver mt6397_driver = { > .driver = { > .name = "mt6397", > .of_match_table = of_match_ptr(mt6397_of_match), > - .pm = &mt6397_pm_ops, > }, > .id_table = mt6397_id, > }; > diff --git a/drivers/mfd/mt6397-irq.c b/drivers/mfd/mt6397-irq.c > index b2d3ce1..2924919 100644 > --- a/drivers/mfd/mt6397-irq.c > +++ b/drivers/mfd/mt6397-irq.c > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -81,7 +82,7 @@ static struct irq_chip mt6397_irq_chip = { > static void mt6397_irq_handle_reg(struct mt6397_chip *mt6397, int reg, > int irqbase) > { > - unsigned int status; > + unsigned int status = 0; This looks like an unrelated change, no? > int i, irq, ret; > > ret = regmap_read(mt6397->regmap, reg, &status); > @@ -128,6 +129,36 @@ static const struct irq_domain_ops mt6397_irq_domain_ops = { > .map = mt6397_irq_domain_map, > }; Other than that. For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBAD5C2BB85 for ; Thu, 16 Apr 2020 08:48:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9542B2076A for ; Thu, 16 Apr 2020 08:48:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k0FO5tke"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qMyY08os" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9542B2076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ptaSAQoy8kRseOseohBRkPfH8oEi26Q+bMynEn/O7KQ=; b=k0FO5tkeQs6zBk d5CNhvUHyHWg+/Y7aB8zK4iu5jAgSYz5IHtRKvMep+h2l4bgBb+FxOAmTMgHn2kS92mDZmm6EZT2W v5gswjT56qwG+z+GzxkEm7ZRDaWaSkSbLyBW2BVJeHnwf8DTLXCeOMZ446k7Lmf69/4oL6yJIx3G1 XZoJYEZbxTYZ4eDhTS5ZIJ98psik3XhoUbQh3/B+DNlDNt5ZctHWpxBaf+JCAIw7KAmb3CMQSQfkj oHfs5pOxqtvyQG+97Xvg69LLM4UYuYbw2WuY/sK4a7D/4FwXEsapAyvtGFPmAer9GlduVQla0/5+r lTPGEfVjfa7Wp8ltDC8g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP0Bz-0007jx-4F; Thu, 16 Apr 2020 08:48:15 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP0Bw-0007jA-3Y for linux-arm-kernel@lists.infradead.org; Thu, 16 Apr 2020 08:48:13 +0000 Received: by mail-wr1-x442.google.com with SMTP id i10so3804358wrv.10 for ; Thu, 16 Apr 2020 01:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=gCC6rxpfNBHEEJoswTl2+v3GlY13e+wv1Apu4C5uUJ0=; b=qMyY08os0xXarDJEQ8j9nJU1G/4i1ajvSN1547JGWNAU4kptYy+l0ETyItzmwelvLC nCDep5Cl1t95mbiIhlCDcowJNJGFakofRU/UeiPQv049DorrDQDyvOhQ0iXlohLp8hin 3bAdw+39EFnaQiFiejH+534QfsSXNhMyYx4ZtJs1O8APzJpuT9KiZORIU2xx8m9me3GJ nRCzeSz6fhZnRuGUV65gJOj0k8DMrASVs1ffDMfO5wQ+4MKhMzyo1Hf7xWdNJii/ENzy uOrTcZOmWLeo1D6phvtKajqfSbjF0JkyzG19tN5chV4GtOZYui9witk4RNmc7L0KIuBW GEOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=gCC6rxpfNBHEEJoswTl2+v3GlY13e+wv1Apu4C5uUJ0=; b=Eg2vYQ6rtpALhB2VcXJ9kg8LNm+YkDYsPwHUHV7qIO/dksIpjcXEMBmr5BtjlM/VKP OmwL6MOb3u+eGU+en9CG4ESyHsmW3xfdWT2p9S3hgYwrgSlhtSQ+y4W/j8ik2uyYn8zV ZHJvcqZjwbCnbciDMCNmFZqzPutEVnskzkwVtkT+E/eeLsl3kPZd4HSVdEPWHIMRtPMt lpLwEAal4CmlrhhPzid3V584Y/QkaoTH7KS3bIiRMJAj5atARhYqFQI2pNioyU5e87TI yoQ7RvF9p2CMYxl30gg1KjtL23b+bKdvG5piqVYEfDRSQqdBR5XZwYSfafmSMjxffJBp l18Q== X-Gm-Message-State: AGi0PuYOzcOMfg04sALZNAipRa4DK3D3J2VUssq05mrMIbmlz5bdTfPN AtAc66BtCTPAAfmJsLOqnzwqfQ== X-Google-Smtp-Source: APiQypLyhDVW4E+VOlBHWErivAdlGrtxixDqwonOAkbRNQamJnKVsV0vJKLtvSLryabLtX0HhH0tLg== X-Received: by 2002:a5d:4286:: with SMTP id k6mr21252278wrq.222.1587026890846; Thu, 16 Apr 2020 01:48:10 -0700 (PDT) Received: from dell ([95.149.164.124]) by smtp.gmail.com with ESMTPSA id z15sm14429845wrs.47.2020.04.16.01.48.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2020 01:48:10 -0700 (PDT) Date: Thu, 16 Apr 2020 09:49:10 +0100 From: Lee Jones To: Hsin-Hsiung Wang Subject: Re: [PATCH v12 1/6] mfd: mt6397: Modify suspend/resume behavior Message-ID: <20200416084910.GX2167633@dell> References: <1586333531-21641-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1586333531-21641-2-git-send-email-hsin-hsiung.wang@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1586333531-21641-2-git-send-email-hsin-hsiung.wang@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200416_014812_159567_5CB87BC0 X-CRM114-Status: GOOD ( 16.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kate Stewart , Alexandre Belloni , linux-kernel@vger.kernel.org, Richard Fontana , linux-rtc@vger.kernel.org, Nicolas Boichat , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, Frank Wunderlich , Ran Bi , Sean Wang , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Thomas Gleixner , Eddie Huang , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , Josef Friedl , srv_heupstream@mediatek.com, Sebastian Reichel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAwOCBBcHIgMjAyMCwgSHNpbi1Ic2l1bmcgV2FuZyB3cm90ZToKCj4gU29tZSBwbWlj cyBkb24ndCBuZWVkIGJhY2t1cCBpbnRlcnJ1cHQgc2V0dGluZ3MsIHNvIHdlIGNoYW5nZSB0byB1 c2UKPiBwbSBub3RpZmllciBmb3IgdGhlIHBtaWNzIHdoaWNoIGFyZSBuZWNlc3NhcnkgdG8gc3Rv cmUgc2V0dGluZ3MuCj4gCj4gU2lnbmVkLW9mZi1ieTogSHNpbi1Ic2l1bmcgV2FuZyA8aHNpbi1o c2l1bmcud2FuZ0BtZWRpYXRlay5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvbWZkL210NjM5Ny1jb3Jl LmMgICAgICAgfCAzMCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9t ZmQvbXQ2Mzk3LWlycS5jICAgICAgICB8IDM1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKystCj4gIGluY2x1ZGUvbGludXgvbWZkL210NjM5Ny9jb3JlLmggfCAgMiArKwo+ICAzIGZp bGVzIGNoYW5nZWQsIDM2IGluc2VydGlvbnMoKyksIDMxIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL21mZC9tdDYzOTctY29yZS5jIGIvZHJpdmVycy9tZmQvbXQ2Mzk3LWNv cmUuYwo+IGluZGV4IDA0MzdjODUuLmQyZTcwZDggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9tZmQv bXQ2Mzk3LWNvcmUuYwo+ICsrKyBiL2RyaXZlcnMvbWZkL210NjM5Ny1jb3JlLmMKPiBAQCAtMTAw LDM1ICsxMDAsNiBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IG1mZF9jZWxsIG10NjM5N19kZXZzW10g PSB7Cj4gIAl9Cj4gIH07Cj4gIAo+IC0jaWZkZWYgQ09ORklHX1BNX1NMRUVQCj4gLXN0YXRpYyBp bnQgbXQ2Mzk3X2lycV9zdXNwZW5kKHN0cnVjdCBkZXZpY2UgKmRldikKPiAtewo+IC0Jc3RydWN0 IG10NjM5N19jaGlwICpjaGlwID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gLQo+IC0JcmVnbWFw X3dyaXRlKGNoaXAtPnJlZ21hcCwgY2hpcC0+aW50X2NvblswXSwgY2hpcC0+d2FrZV9tYXNrWzBd KTsKPiAtCXJlZ21hcF93cml0ZShjaGlwLT5yZWdtYXAsIGNoaXAtPmludF9jb25bMV0sIGNoaXAt Pndha2VfbWFza1sxXSk7Cj4gLQo+IC0JZW5hYmxlX2lycV93YWtlKGNoaXAtPmlycSk7Cj4gLQo+ IC0JcmV0dXJuIDA7Cj4gLX0KPiAtCj4gLXN0YXRpYyBpbnQgbXQ2Mzk3X2lycV9yZXN1bWUoc3Ry dWN0IGRldmljZSAqZGV2KQo+IC17Cj4gLQlzdHJ1Y3QgbXQ2Mzk3X2NoaXAgKmNoaXAgPSBkZXZf Z2V0X2RydmRhdGEoZGV2KTsKPiAtCj4gLQlyZWdtYXBfd3JpdGUoY2hpcC0+cmVnbWFwLCBjaGlw LT5pbnRfY29uWzBdLCBjaGlwLT5pcnFfbWFza3NfY3VyWzBdKTsKPiAtCXJlZ21hcF93cml0ZShj aGlwLT5yZWdtYXAsIGNoaXAtPmludF9jb25bMV0sIGNoaXAtPmlycV9tYXNrc19jdXJbMV0pOwo+ IC0KPiAtCWRpc2FibGVfaXJxX3dha2UoY2hpcC0+aXJxKTsKPiAtCj4gLQlyZXR1cm4gMDsKPiAt fQo+IC0jZW5kaWYKPiAtCj4gLXN0YXRpYyBTSU1QTEVfREVWX1BNX09QUyhtdDYzOTdfcG1fb3Bz LCBtdDYzOTdfaXJxX3N1c3BlbmQsCj4gLQkJCW10NjM5N19pcnFfcmVzdW1lKTsKPiAtCj4gIHN0 cnVjdCBjaGlwX2RhdGEgewo+ICAJdTMyIGNpZF9hZGRyOwo+ICAJdTMyIGNpZF9zaGlmdDsKPiBA QCAtMjM4LDcgKzIwOSw2IEBAIHN0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIG10NjM5N19k cml2ZXIgPSB7Cj4gIAkuZHJpdmVyID0gewo+ICAJCS5uYW1lID0gIm10NjM5NyIsCj4gIAkJLm9m X21hdGNoX3RhYmxlID0gb2ZfbWF0Y2hfcHRyKG10NjM5N19vZl9tYXRjaCksCj4gLQkJLnBtID0g Jm10NjM5N19wbV9vcHMsCj4gIAl9LAo+ICAJLmlkX3RhYmxlID0gbXQ2Mzk3X2lkLAo+ICB9Owo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC9tdDYzOTctaXJxLmMgYi9kcml2ZXJzL21mZC9tdDYz OTctaXJxLmMKPiBpbmRleCBiMmQzY2UxLi4yOTI0OTE5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv bWZkL210NjM5Ny1pcnEuYwo+ICsrKyBiL2RyaXZlcnMvbWZkL210NjM5Ny1pcnEuYwo+IEBAIC05 LDYgKzksNyBAQAo+ICAjaW5jbHVkZSA8bGludXgvb2ZfaXJxLmg+Cj4gICNpbmNsdWRlIDxsaW51 eC9wbGF0Zm9ybV9kZXZpY2UuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3JlZ21hcC5oPgo+ICsjaW5j bHVkZSA8bGludXgvc3VzcGVuZC5oPgo+ICAjaW5jbHVkZSA8bGludXgvbWZkL210NjMyMy9jb3Jl Lmg+Cj4gICNpbmNsdWRlIDxsaW51eC9tZmQvbXQ2MzIzL3JlZ2lzdGVycy5oPgo+ICAjaW5jbHVk ZSA8bGludXgvbWZkL210NjM5Ny9jb3JlLmg+Cj4gQEAgLTgxLDcgKzgyLDcgQEAgc3RhdGljIHN0 cnVjdCBpcnFfY2hpcCBtdDYzOTdfaXJxX2NoaXAgPSB7Cj4gIHN0YXRpYyB2b2lkIG10NjM5N19p cnFfaGFuZGxlX3JlZyhzdHJ1Y3QgbXQ2Mzk3X2NoaXAgKm10NjM5NywgaW50IHJlZywKPiAgCQkJ CSAgaW50IGlycWJhc2UpCj4gIHsKPiAtCXVuc2lnbmVkIGludCBzdGF0dXM7Cj4gKwl1bnNpZ25l ZCBpbnQgc3RhdHVzID0gMDsKClRoaXMgbG9va3MgbGlrZSBhbiB1bnJlbGF0ZWQgY2hhbmdlLCBu bz8KCj4gIAlpbnQgaSwgaXJxLCByZXQ7Cj4gIAo+ICAJcmV0ID0gcmVnbWFwX3JlYWQobXQ2Mzk3 LT5yZWdtYXAsIHJlZywgJnN0YXR1cyk7Cj4gQEAgLTEyOCw2ICsxMjksMzYgQEAgc3RhdGljIGNv bnN0IHN0cnVjdCBpcnFfZG9tYWluX29wcyBtdDYzOTdfaXJxX2RvbWFpbl9vcHMgPSB7Cj4gIAku bWFwID0gbXQ2Mzk3X2lycV9kb21haW5fbWFwLAo+ICB9OwoKT3RoZXIgdGhhbiB0aGF0LgoKRm9y IG15IG93biByZWZlcmVuY2U6CiAgQWNrZWQtZm9yLU1GRC1ieTogTGVlIEpvbmVzIDxsZWUuam9u ZXNAbGluYXJvLm9yZz4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KTGluYXJvIFNlcnZpY2Vz IFRlY2huaWNhbCBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBB Uk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==