From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Date: Thu, 16 Apr 2020 08:50:19 +0000 Subject: Re: [PATCH v2] KVM: Optimize kvm_arch_vcpu_ioctl_run function Message-Id: <20200416105019.51191d79.cohuck@redhat.com> List-Id: References: <20200416051057.26526-1-tianjia.zhang@linux.alibaba.com> <878sivx67g.fsf@vitty.brq.redhat.com> <1000159f971a6fa3b5bd9e5871ce4d82@kernel.org> <8b92fb5b-5138-0695-fb90-6c36b8dfad00@linux.alibaba.com> In-Reply-To: <8b92fb5b-5138-0695-fb90-6c36b8dfad00@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Tianjia Zhang Cc: Marc Zyngier , Vitaly Kuznetsov , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com, tsbogend@alpha.franken.de, paulus@ozlabs.org, mpe@ellerman.id.au, benh@kernel.crashing.org, borntraeger@de.ibm.com, frankja@linux.ibm.com, david@redhat.com, heiko.carstens@de.ibm.com, gor@linux.ibm.com, sean.j.christopherson@intel.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, christoffer.dall@arm.com, peterx@redhat.com, thuth@redhat.com On Thu, 16 Apr 2020 16:45:33 +0800 Tianjia Zhang wrote: > On 2020/4/16 16:28, Marc Zyngier wrote: > > On 2020-04-16 08:03, Vitaly Kuznetsov wrote: > >> Tianjia Zhang writes: > >> > >>> In earlier versions of kvm, 'kvm_run' is an independent structure > >>> and is not included in the vcpu structure. At present, 'kvm_run' > >>> is already included in the vcpu structure, so the parameter > >>> 'kvm_run' is redundant. > >>> > >>> This patch simplify the function definition, removes the extra > >>> 'kvm_run' parameter, and extract it from the 'kvm_vcpu' structure > >>> if necessary. > >>> > >>> Signed-off-by: Tianjia Zhang > >>> --- > >>> > >>> v2 change: > >>>   remove 'kvm_run' parameter and extract it from 'kvm_vcpu' > >>> > >>>  arch/mips/kvm/mips.c       |  3 ++- > >>>  arch/powerpc/kvm/powerpc.c |  3 ++- > >>>  arch/s390/kvm/kvm-s390.c   |  3 ++- > >>>  arch/x86/kvm/x86.c         | 11 ++++++----- > >>>  include/linux/kvm_host.h   |  2 +- > >>>  virt/kvm/arm/arm.c         |  6 +++--- > >>>  virt/kvm/kvm_main.c        |  2 +- > >>>  7 files changed, 17 insertions(+), 13 deletions(-) > > Overall, there is a large set of cleanups to be done when both the vcpu > > and the run > > structures are passed as parameters at the same time. Just grepping the > > tree for > > kvm_run is pretty instructive. > > > >         M. > > Sorry, it's my mistake, I only compiled the x86 platform, I will submit > patch again. I think it's completely fine (and even preferable) to do cleanups like that on top. [FWIW, I compiled s390 here.] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BCEBC2BB85 for ; Thu, 16 Apr 2020 08:50:54 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 996FB20784 for ; Thu, 16 Apr 2020 08:50:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SAZOXk8e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 996FB20784 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1387A4B14D; Thu, 16 Apr 2020 04:50:53 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FF5MlgxiYYRN; Thu, 16 Apr 2020 04:50:52 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 198304B1D1; Thu, 16 Apr 2020 04:50:52 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DFDFF4B142 for ; Thu, 16 Apr 2020 04:50:50 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yP34+T9OUCX1 for ; Thu, 16 Apr 2020 04:50:48 -0400 (EDT) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DADD14B120 for ; Thu, 16 Apr 2020 04:50:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587027048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HBOSp8KoaqgQUXlL6khiQxh82SbQfD3UXPaPxlc3NpI=; b=SAZOXk8e3bOfIiblT3KEanC34Cr2ERHz2OAj1z5udHAIYoMzy7FEBAiLU3tOkG3vjFBXLU RJ1+UhYcNWRmanl/jDRIR+NLsaMtjBZk/1GV7FNoFaE1tJlNcojdz6CEPLZ0gyeSPCoaxI vu2BVvUEOncDoo6OHYGGljUZxbKLZSQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-270-MuypNbuHM0uD0I3hVYYtuw-1; Thu, 16 Apr 2020 04:50:46 -0400 X-MC-Unique: MuypNbuHM0uD0I3hVYYtuw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 994A818C35A6; Thu, 16 Apr 2020 08:50:42 +0000 (UTC) Received: from gondolin (ovpn-112-234.ams2.redhat.com [10.36.112.234]) by smtp.corp.redhat.com (Postfix) with ESMTP id 330E27E7C4; Thu, 16 Apr 2020 08:50:22 +0000 (UTC) Date: Thu, 16 Apr 2020 10:50:19 +0200 From: Cornelia Huck To: Tianjia Zhang Subject: Re: [PATCH v2] KVM: Optimize kvm_arch_vcpu_ioctl_run function Message-ID: <20200416105019.51191d79.cohuck@redhat.com> In-Reply-To: <8b92fb5b-5138-0695-fb90-6c36b8dfad00@linux.alibaba.com> References: <20200416051057.26526-1-tianjia.zhang@linux.alibaba.com> <878sivx67g.fsf@vitty.brq.redhat.com> <1000159f971a6fa3b5bd9e5871ce4d82@kernel.org> <8b92fb5b-5138-0695-fb90-6c36b8dfad00@linux.alibaba.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Cc: wanpengli@tencent.com, kvm@vger.kernel.org, david@redhat.com, benh@kernel.crashing.org, heiko.carstens@de.ibm.com, linux-kernel@vger.kernel.org, paulus@ozlabs.org, hpa@zytor.com, kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org, frankja@linux.ibm.com, Marc Zyngier , joro@8bytes.org, x86@kernel.org, borntraeger@de.ibm.com, mingo@redhat.com, thuth@redhat.com, gor@linux.ibm.com, kvm-ppc@vger.kernel.org, bp@alien8.de, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, jmattson@google.com, tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, sean.j.christopherson@intel.com, mpe@ellerman.id.au, pbonzini@redhat.com, Vitaly Kuznetsov , linuxppc-dev@lists.ozlabs.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gVGh1LCAxNiBBcHIgMjAyMCAxNjo0NTozMyArMDgwMApUaWFuamlhIFpoYW5nIDx0aWFuamlh LnpoYW5nQGxpbnV4LmFsaWJhYmEuY29tPiB3cm90ZToKCj4gT24gMjAyMC80LzE2IDE2OjI4LCBN YXJjIFp5bmdpZXIgd3JvdGU6Cj4gPiBPbiAyMDIwLTA0LTE2IDA4OjAzLCBWaXRhbHkgS3V6bmV0 c292IHdyb3RlOiAgCj4gPj4gVGlhbmppYSBaaGFuZyA8dGlhbmppYS56aGFuZ0BsaW51eC5hbGli YWJhLmNvbT4gd3JpdGVzOgo+ID4+ICAKPiA+Pj4gSW4gZWFybGllciB2ZXJzaW9ucyBvZiBrdm0s ICdrdm1fcnVuJyBpcyBhbiBpbmRlcGVuZGVudCBzdHJ1Y3R1cmUKPiA+Pj4gYW5kIGlzIG5vdCBp bmNsdWRlZCBpbiB0aGUgdmNwdSBzdHJ1Y3R1cmUuIEF0IHByZXNlbnQsICdrdm1fcnVuJwo+ID4+ PiBpcyBhbHJlYWR5IGluY2x1ZGVkIGluIHRoZSB2Y3B1IHN0cnVjdHVyZSwgc28gdGhlIHBhcmFt ZXRlcgo+ID4+PiAna3ZtX3J1bicgaXMgcmVkdW5kYW50Lgo+ID4+Pgo+ID4+PiBUaGlzIHBhdGNo IHNpbXBsaWZ5IHRoZSBmdW5jdGlvbiBkZWZpbml0aW9uLCByZW1vdmVzIHRoZSBleHRyYQo+ID4+ PiAna3ZtX3J1bicgcGFyYW1ldGVyLCBhbmQgZXh0cmFjdCBpdCBmcm9tIHRoZSAna3ZtX3ZjcHUn IHN0cnVjdHVyZQo+ID4+PiBpZiBuZWNlc3NhcnkuCj4gPj4+Cj4gPj4+IFNpZ25lZC1vZmYtYnk6 IFRpYW5qaWEgWmhhbmcgPHRpYW5qaWEuemhhbmdAbGludXguYWxpYmFiYS5jb20+Cj4gPj4+IC0t LQo+ID4+Pgo+ID4+PiB2MiBjaGFuZ2U6Cj4gPj4+IMKgIHJlbW92ZSAna3ZtX3J1bicgcGFyYW1l dGVyIGFuZCBleHRyYWN0IGl0IGZyb20gJ2t2bV92Y3B1Jwo+ID4+Pgo+ID4+PiDCoGFyY2gvbWlw cy9rdm0vbWlwcy5jwqDCoMKgwqDCoMKgIHzCoCAzICsrLQo+ID4+PiDCoGFyY2gvcG93ZXJwYy9r dm0vcG93ZXJwYy5jIHzCoCAzICsrLQo+ID4+PiDCoGFyY2gvczM5MC9rdm0va3ZtLXMzOTAuY8Kg wqAgfMKgIDMgKystCj4gPj4+IMKgYXJjaC94ODYva3ZtL3g4Ni5jwqDCoMKgwqDCoMKgwqDCoCB8 IDExICsrKysrKy0tLS0tCj4gPj4+IMKgaW5jbHVkZS9saW51eC9rdm1faG9zdC5owqDCoCB8wqAg MiArLQo+ID4+PiDCoHZpcnQva3ZtL2FybS9hcm0uY8KgwqDCoMKgwqDCoMKgwqAgfMKgIDYgKysr LS0tCj4gPj4+IMKgdmlydC9rdm0va3ZtX21haW4uY8KgwqDCoMKgwqDCoMKgIHzCoCAyICstCj4g Pj4+IMKgNyBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkK Cj4gPiBPdmVyYWxsLCB0aGVyZSBpcyBhIGxhcmdlIHNldCBvZiBjbGVhbnVwcyB0byBiZSBkb25l IHdoZW4gYm90aCB0aGUgdmNwdSAKPiA+IGFuZCB0aGUgcnVuCj4gPiBzdHJ1Y3R1cmVzIGFyZSBw YXNzZWQgYXMgcGFyYW1ldGVycyBhdCB0aGUgc2FtZSB0aW1lLiBKdXN0IGdyZXBwaW5nIHRoZSAK PiA+IHRyZWUgZm9yCj4gPiBrdm1fcnVuIGlzIHByZXR0eSBpbnN0cnVjdGl2ZS4KPiA+IAo+ID4g IMKgwqDCoMKgwqDCoMKgIE0uICAKPiAKPiBTb3JyeSwgaXQncyBteSBtaXN0YWtlLCBJIG9ubHkg Y29tcGlsZWQgdGhlIHg4NiBwbGF0Zm9ybSwgSSB3aWxsIHN1Ym1pdCAKPiBwYXRjaCBhZ2Fpbi4K CkkgdGhpbmsgaXQncyBjb21wbGV0ZWx5IGZpbmUgKGFuZCBldmVuIHByZWZlcmFibGUpIHRvIGRv IGNsZWFudXBzIGxpa2UKdGhhdCBvbiB0b3AuCgpbRldJVywgSSBjb21waWxlZCBzMzkwIGhlcmUu XQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka3ZtYXJt IG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMuY3MuY29sdW1iaWEuZWR1Cmh0dHBzOi8vbGlzdHMu Y3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlzdGluZm8va3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5219EC2BB85 for ; Thu, 16 Apr 2020 08:59:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 301842054F for ; Thu, 16 Apr 2020 08:59:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SAZOXk8e" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502835AbgDPI6v (ORCPT ); Thu, 16 Apr 2020 04:58:51 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:40651 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2502830AbgDPIux (ORCPT ); Thu, 16 Apr 2020 04:50:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587027048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HBOSp8KoaqgQUXlL6khiQxh82SbQfD3UXPaPxlc3NpI=; b=SAZOXk8e3bOfIiblT3KEanC34Cr2ERHz2OAj1z5udHAIYoMzy7FEBAiLU3tOkG3vjFBXLU RJ1+UhYcNWRmanl/jDRIR+NLsaMtjBZk/1GV7FNoFaE1tJlNcojdz6CEPLZ0gyeSPCoaxI vu2BVvUEOncDoo6OHYGGljUZxbKLZSQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-270-MuypNbuHM0uD0I3hVYYtuw-1; Thu, 16 Apr 2020 04:50:46 -0400 X-MC-Unique: MuypNbuHM0uD0I3hVYYtuw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 994A818C35A6; Thu, 16 Apr 2020 08:50:42 +0000 (UTC) Received: from gondolin (ovpn-112-234.ams2.redhat.com [10.36.112.234]) by smtp.corp.redhat.com (Postfix) with ESMTP id 330E27E7C4; Thu, 16 Apr 2020 08:50:22 +0000 (UTC) Date: Thu, 16 Apr 2020 10:50:19 +0200 From: Cornelia Huck To: Tianjia Zhang Cc: Marc Zyngier , Vitaly Kuznetsov , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com, tsbogend@alpha.franken.de, paulus@ozlabs.org, mpe@ellerman.id.au, benh@kernel.crashing.org, borntraeger@de.ibm.com, frankja@linux.ibm.com, david@redhat.com, heiko.carstens@de.ibm.com, gor@linux.ibm.com, sean.j.christopherson@intel.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, christoffer.dall@arm.com, peterx@redhat.com, thuth@redhat.com Subject: Re: [PATCH v2] KVM: Optimize kvm_arch_vcpu_ioctl_run function Message-ID: <20200416105019.51191d79.cohuck@redhat.com> In-Reply-To: <8b92fb5b-5138-0695-fb90-6c36b8dfad00@linux.alibaba.com> References: <20200416051057.26526-1-tianjia.zhang@linux.alibaba.com> <878sivx67g.fsf@vitty.brq.redhat.com> <1000159f971a6fa3b5bd9e5871ce4d82@kernel.org> <8b92fb5b-5138-0695-fb90-6c36b8dfad00@linux.alibaba.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Thu, 16 Apr 2020 16:45:33 +0800 Tianjia Zhang wrote: > On 2020/4/16 16:28, Marc Zyngier wrote: > > On 2020-04-16 08:03, Vitaly Kuznetsov wrote: =20 > >> Tianjia Zhang writes: > >> =20 > >>> In earlier versions of kvm, 'kvm_run' is an independent structure > >>> and is not included in the vcpu structure. At present, 'kvm_run' > >>> is already included in the vcpu structure, so the parameter > >>> 'kvm_run' is redundant. > >>> > >>> This patch simplify the function definition, removes the extra > >>> 'kvm_run' parameter, and extract it from the 'kvm_vcpu' structure > >>> if necessary. > >>> > >>> Signed-off-by: Tianjia Zhang > >>> --- > >>> > >>> v2 change: > >>> =C2=A0 remove 'kvm_run' parameter and extract it from 'kvm_vcpu' > >>> > >>> =C2=A0arch/mips/kvm/mips.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2= =A0 3 ++- > >>> =C2=A0arch/powerpc/kvm/powerpc.c |=C2=A0 3 ++- > >>> =C2=A0arch/s390/kvm/kvm-s390.c=C2=A0=C2=A0 |=C2=A0 3 ++- > >>> =C2=A0arch/x86/kvm/x86.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 | 11 ++++++----- > >>> =C2=A0include/linux/kvm_host.h=C2=A0=C2=A0 |=C2=A0 2 +- > >>> =C2=A0virt/kvm/arm/arm.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 |=C2=A0 6 +++--- > >>> =C2=A0virt/kvm/kvm_main.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |= =C2=A0 2 +- > >>> =C2=A07 files changed, 17 insertions(+), 13 deletions(-) > > Overall, there is a large set of cleanups to be done when both the vcpu= =20 > > and the run > > structures are passed as parameters at the same time. Just grepping the= =20 > > tree for > > kvm_run is pretty instructive. > >=20 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 M. =20 >=20 > Sorry, it's my mistake, I only compiled the x86 platform, I will submit=20 > patch again. I think it's completely fine (and even preferable) to do cleanups like that on top. [FWIW, I compiled s390 here.] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63446C2BB85 for ; Thu, 16 Apr 2020 09:22:09 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5F34206D6 for ; Thu, 16 Apr 2020 09:22:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zgz/eeB9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gC6PUpVg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5F34206D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 492tz26b2SzDrVM for ; Thu, 16 Apr 2020 19:22:06 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=207.211.31.120; helo=us-smtp-1.mimecast.com; envelope-from=cohuck@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Zgz/eeB9; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gC6PUpVg; dkim-atps=neutral Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 492tLk35CmzDrNR for ; Thu, 16 Apr 2020 18:54:06 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587027242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HBOSp8KoaqgQUXlL6khiQxh82SbQfD3UXPaPxlc3NpI=; b=Zgz/eeB9LNPsw+fRyve48eAo2hSl40TxZq64+zG7TY4Yk5GzCSMvkkcBe41GyHVR2o7ywk /C47T5N81IhUOGsPSCUYZ/WHvsucskYR9u2+JHXgKTZ3vAa4HFpyqkLGYbqh/sJ+nPpcOG qYOLABRQBYR+LVLED7K8O+M5LZK8rH0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587027243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HBOSp8KoaqgQUXlL6khiQxh82SbQfD3UXPaPxlc3NpI=; b=gC6PUpVg1VUXH99HAvRfv32y+vQGI1Ld3pvVEYUseLs69LlT80/857edi4CHbMsOHqFbhK Gu0S8U0P1YwO5z8h1DItTxg+AiJxtf0PJxJx7JlI67BoyPUdFm8OwsvDaCHE2sROMhYvmI Klo5EKrfRHOwW3EZYzO4lkUmjHnlWP8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-270-MuypNbuHM0uD0I3hVYYtuw-1; Thu, 16 Apr 2020 04:50:46 -0400 X-MC-Unique: MuypNbuHM0uD0I3hVYYtuw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 994A818C35A6; Thu, 16 Apr 2020 08:50:42 +0000 (UTC) Received: from gondolin (ovpn-112-234.ams2.redhat.com [10.36.112.234]) by smtp.corp.redhat.com (Postfix) with ESMTP id 330E27E7C4; Thu, 16 Apr 2020 08:50:22 +0000 (UTC) Date: Thu, 16 Apr 2020 10:50:19 +0200 From: Cornelia Huck To: Tianjia Zhang Subject: Re: [PATCH v2] KVM: Optimize kvm_arch_vcpu_ioctl_run function Message-ID: <20200416105019.51191d79.cohuck@redhat.com> In-Reply-To: <8b92fb5b-5138-0695-fb90-6c36b8dfad00@linux.alibaba.com> References: <20200416051057.26526-1-tianjia.zhang@linux.alibaba.com> <878sivx67g.fsf@vitty.brq.redhat.com> <1000159f971a6fa3b5bd9e5871ce4d82@kernel.org> <8b92fb5b-5138-0695-fb90-6c36b8dfad00@linux.alibaba.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mailman-Approved-At: Thu, 16 Apr 2020 19:18:11 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: christoffer.dall@arm.com, wanpengli@tencent.com, kvm@vger.kernel.org, david@redhat.com, heiko.carstens@de.ibm.com, peterx@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com, kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org, frankja@linux.ibm.com, Marc Zyngier , joro@8bytes.org, x86@kernel.org, borntraeger@de.ibm.com, mingo@redhat.com, julien.thierry.kdev@gmail.com, thuth@redhat.com, gor@linux.ibm.com, suzuki.poulose@arm.com, kvm-ppc@vger.kernel.org, bp@alien8.de, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, jmattson@google.com, tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, sean.j.christopherson@intel.com, james.morse@arm.com, pbonzini@redhat.com, Vitaly Kuznetsov , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, 16 Apr 2020 16:45:33 +0800 Tianjia Zhang wrote: > On 2020/4/16 16:28, Marc Zyngier wrote: > > On 2020-04-16 08:03, Vitaly Kuznetsov wrote: =20 > >> Tianjia Zhang writes: > >> =20 > >>> In earlier versions of kvm, 'kvm_run' is an independent structure > >>> and is not included in the vcpu structure. At present, 'kvm_run' > >>> is already included in the vcpu structure, so the parameter > >>> 'kvm_run' is redundant. > >>> > >>> This patch simplify the function definition, removes the extra > >>> 'kvm_run' parameter, and extract it from the 'kvm_vcpu' structure > >>> if necessary. > >>> > >>> Signed-off-by: Tianjia Zhang > >>> --- > >>> > >>> v2 change: > >>> =C2=A0 remove 'kvm_run' parameter and extract it from 'kvm_vcpu' > >>> > >>> =C2=A0arch/mips/kvm/mips.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2= =A0 3 ++- > >>> =C2=A0arch/powerpc/kvm/powerpc.c |=C2=A0 3 ++- > >>> =C2=A0arch/s390/kvm/kvm-s390.c=C2=A0=C2=A0 |=C2=A0 3 ++- > >>> =C2=A0arch/x86/kvm/x86.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 | 11 ++++++----- > >>> =C2=A0include/linux/kvm_host.h=C2=A0=C2=A0 |=C2=A0 2 +- > >>> =C2=A0virt/kvm/arm/arm.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 |=C2=A0 6 +++--- > >>> =C2=A0virt/kvm/kvm_main.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |= =C2=A0 2 +- > >>> =C2=A07 files changed, 17 insertions(+), 13 deletions(-) > > Overall, there is a large set of cleanups to be done when both the vcpu= =20 > > and the run > > structures are passed as parameters at the same time. Just grepping the= =20 > > tree for > > kvm_run is pretty instructive. > >=20 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 M. =20 >=20 > Sorry, it's my mistake, I only compiled the x86 platform, I will submit=20 > patch again. I think it's completely fine (and even preferable) to do cleanups like that on top. [FWIW, I compiled s390 here.] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16803C2BB85 for ; Thu, 16 Apr 2020 08:50:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2F9920784 for ; Thu, 16 Apr 2020 08:50:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YwTTn8ku"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SAZOXk8e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2F9920784 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ahEeSxV1luFGjDlgTMDtG+CfD7qGO68T/NkXj6C163I=; b=YwTTn8kuJpq8XY tVdBIx3MMA8U+oy7ACupaUn64D4yzMU9iWCJF31Vs3PFGHmvvRttHDhfTYq3EBF1dk9O+P7DFePt4 gz1wfSy2ndIy+gfoQ9EMtW2rHi1tziExTnaw9yBWQGJtj772KIjcefY6UaH1oQQhchnW/BMC9vJC3 HJ1Gp93Mf5vAYSQTtNrnqlI+v8oGTUkoOCeFSAtMGTd50JFu17wiEfHsnhR/Z/lC3k9Oo/8GCz9Qs LRlai2YLuN3NDjPR9zxDhj1xnldjxj2mClyWwftESAXUi9Ugtq6ANH53Opw6hQe+/tRg/rpRFYd9c VWYOno8wYW8E6LXycMLg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP0EX-0002hV-0c; Thu, 16 Apr 2020 08:50:53 +0000 Received: from us-smtp-2.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP0EU-0002Zu-9H for linux-arm-kernel@lists.infradead.org; Thu, 16 Apr 2020 08:50:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587027048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HBOSp8KoaqgQUXlL6khiQxh82SbQfD3UXPaPxlc3NpI=; b=SAZOXk8e3bOfIiblT3KEanC34Cr2ERHz2OAj1z5udHAIYoMzy7FEBAiLU3tOkG3vjFBXLU RJ1+UhYcNWRmanl/jDRIR+NLsaMtjBZk/1GV7FNoFaE1tJlNcojdz6CEPLZ0gyeSPCoaxI vu2BVvUEOncDoo6OHYGGljUZxbKLZSQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-270-MuypNbuHM0uD0I3hVYYtuw-1; Thu, 16 Apr 2020 04:50:46 -0400 X-MC-Unique: MuypNbuHM0uD0I3hVYYtuw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 994A818C35A6; Thu, 16 Apr 2020 08:50:42 +0000 (UTC) Received: from gondolin (ovpn-112-234.ams2.redhat.com [10.36.112.234]) by smtp.corp.redhat.com (Postfix) with ESMTP id 330E27E7C4; Thu, 16 Apr 2020 08:50:22 +0000 (UTC) Date: Thu, 16 Apr 2020 10:50:19 +0200 From: Cornelia Huck To: Tianjia Zhang Subject: Re: [PATCH v2] KVM: Optimize kvm_arch_vcpu_ioctl_run function Message-ID: <20200416105019.51191d79.cohuck@redhat.com> In-Reply-To: <8b92fb5b-5138-0695-fb90-6c36b8dfad00@linux.alibaba.com> References: <20200416051057.26526-1-tianjia.zhang@linux.alibaba.com> <878sivx67g.fsf@vitty.brq.redhat.com> <1000159f971a6fa3b5bd9e5871ce4d82@kernel.org> <8b92fb5b-5138-0695-fb90-6c36b8dfad00@linux.alibaba.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200416_015050_404596_2F1D30C4 X-CRM114-Status: GOOD ( 14.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: christoffer.dall@arm.com, wanpengli@tencent.com, kvm@vger.kernel.org, david@redhat.com, benh@kernel.crashing.org, heiko.carstens@de.ibm.com, peterx@redhat.com, linux-kernel@vger.kernel.org, paulus@ozlabs.org, hpa@zytor.com, kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org, frankja@linux.ibm.com, Marc Zyngier , joro@8bytes.org, x86@kernel.org, borntraeger@de.ibm.com, mingo@redhat.com, julien.thierry.kdev@gmail.com, thuth@redhat.com, gor@linux.ibm.com, suzuki.poulose@arm.com, kvm-ppc@vger.kernel.org, bp@alien8.de, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, jmattson@google.com, tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, sean.j.christopherson@intel.com, james.morse@arm.com, mpe@ellerman.id.au, pbonzini@redhat.com, Vitaly Kuznetsov , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAxNiBBcHIgMjAyMCAxNjo0NTozMyArMDgwMApUaWFuamlhIFpoYW5nIDx0aWFuamlh LnpoYW5nQGxpbnV4LmFsaWJhYmEuY29tPiB3cm90ZToKCj4gT24gMjAyMC80LzE2IDE2OjI4LCBN YXJjIFp5bmdpZXIgd3JvdGU6Cj4gPiBPbiAyMDIwLTA0LTE2IDA4OjAzLCBWaXRhbHkgS3V6bmV0 c292IHdyb3RlOiAgCj4gPj4gVGlhbmppYSBaaGFuZyA8dGlhbmppYS56aGFuZ0BsaW51eC5hbGli YWJhLmNvbT4gd3JpdGVzOgo+ID4+ICAKPiA+Pj4gSW4gZWFybGllciB2ZXJzaW9ucyBvZiBrdm0s ICdrdm1fcnVuJyBpcyBhbiBpbmRlcGVuZGVudCBzdHJ1Y3R1cmUKPiA+Pj4gYW5kIGlzIG5vdCBp bmNsdWRlZCBpbiB0aGUgdmNwdSBzdHJ1Y3R1cmUuIEF0IHByZXNlbnQsICdrdm1fcnVuJwo+ID4+ PiBpcyBhbHJlYWR5IGluY2x1ZGVkIGluIHRoZSB2Y3B1IHN0cnVjdHVyZSwgc28gdGhlIHBhcmFt ZXRlcgo+ID4+PiAna3ZtX3J1bicgaXMgcmVkdW5kYW50Lgo+ID4+Pgo+ID4+PiBUaGlzIHBhdGNo IHNpbXBsaWZ5IHRoZSBmdW5jdGlvbiBkZWZpbml0aW9uLCByZW1vdmVzIHRoZSBleHRyYQo+ID4+ PiAna3ZtX3J1bicgcGFyYW1ldGVyLCBhbmQgZXh0cmFjdCBpdCBmcm9tIHRoZSAna3ZtX3ZjcHUn IHN0cnVjdHVyZQo+ID4+PiBpZiBuZWNlc3NhcnkuCj4gPj4+Cj4gPj4+IFNpZ25lZC1vZmYtYnk6 IFRpYW5qaWEgWmhhbmcgPHRpYW5qaWEuemhhbmdAbGludXguYWxpYmFiYS5jb20+Cj4gPj4+IC0t LQo+ID4+Pgo+ID4+PiB2MiBjaGFuZ2U6Cj4gPj4+IMKgIHJlbW92ZSAna3ZtX3J1bicgcGFyYW1l dGVyIGFuZCBleHRyYWN0IGl0IGZyb20gJ2t2bV92Y3B1Jwo+ID4+Pgo+ID4+PiDCoGFyY2gvbWlw cy9rdm0vbWlwcy5jwqDCoMKgwqDCoMKgIHzCoCAzICsrLQo+ID4+PiDCoGFyY2gvcG93ZXJwYy9r dm0vcG93ZXJwYy5jIHzCoCAzICsrLQo+ID4+PiDCoGFyY2gvczM5MC9rdm0va3ZtLXMzOTAuY8Kg wqAgfMKgIDMgKystCj4gPj4+IMKgYXJjaC94ODYva3ZtL3g4Ni5jwqDCoMKgwqDCoMKgwqDCoCB8 IDExICsrKysrKy0tLS0tCj4gPj4+IMKgaW5jbHVkZS9saW51eC9rdm1faG9zdC5owqDCoCB8wqAg MiArLQo+ID4+PiDCoHZpcnQva3ZtL2FybS9hcm0uY8KgwqDCoMKgwqDCoMKgwqAgfMKgIDYgKysr LS0tCj4gPj4+IMKgdmlydC9rdm0va3ZtX21haW4uY8KgwqDCoMKgwqDCoMKgIHzCoCAyICstCj4g Pj4+IMKgNyBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkK Cj4gPiBPdmVyYWxsLCB0aGVyZSBpcyBhIGxhcmdlIHNldCBvZiBjbGVhbnVwcyB0byBiZSBkb25l IHdoZW4gYm90aCB0aGUgdmNwdSAKPiA+IGFuZCB0aGUgcnVuCj4gPiBzdHJ1Y3R1cmVzIGFyZSBw YXNzZWQgYXMgcGFyYW1ldGVycyBhdCB0aGUgc2FtZSB0aW1lLiBKdXN0IGdyZXBwaW5nIHRoZSAK PiA+IHRyZWUgZm9yCj4gPiBrdm1fcnVuIGlzIHByZXR0eSBpbnN0cnVjdGl2ZS4KPiA+IAo+ID4g IMKgwqDCoMKgwqDCoMKgIE0uICAKPiAKPiBTb3JyeSwgaXQncyBteSBtaXN0YWtlLCBJIG9ubHkg Y29tcGlsZWQgdGhlIHg4NiBwbGF0Zm9ybSwgSSB3aWxsIHN1Ym1pdCAKPiBwYXRjaCBhZ2Fpbi4K CkkgdGhpbmsgaXQncyBjb21wbGV0ZWx5IGZpbmUgKGFuZCBldmVuIHByZWZlcmFibGUpIHRvIGRv IGNsZWFudXBzIGxpa2UKdGhhdCBvbiB0b3AuCgpbRldJVywgSSBjb21waWxlZCBzMzkwIGhlcmUu XQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK